Fix normal Profile Page displayed for invalid accountID by Kicu · Pull Request #42769 · Expensify/App

Kicu · 2024-05-29T15:05:01Z

Details

hotfix for displaying wrong ProfilePage
now if the accountID is not an actual account id but a string, we will display NotFound Page

Fixed Issues

$ #42750
PROPOSAL:

Tests

follow reproduction steps from: [HOLD for payment 2024-06-13] User profile - App shows Hidden profile instead of not here page when profile link is invalid #42750

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

rec-web-bugfix.mp4

MacOS: Desktop

Kicu · 2024-05-29T15:10:11Z

this is how it was working before my PR: https://github.com/Expensify/App/pull/41846/files#diff-9ec781fc7bf783309e61fa0ee95b25697a7d9aae9de9564e1a09055c4f65b3cbL120

I tried to re-create similar logic but I don't want to base it on existence of avatar.

melvin-bot · 2024-05-29T15:13:37Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-05-29T19:31:18Z


    const hasAvatar = Boolean(details.avatar);
    const isLoading = Boolean(personalDetailsMetadata?.[accountID]?.isLoading) || isEmptyObject(details);
+    const shouldShowBlockingView = !isValidAccountId && !isLoading;


Suggested change

const shouldShowBlockingView = !isValidAccountId && !isLoading;

const shouldShowBlockingView = (!isValidAccountId && !isLoading) || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

NAB

s77rt · 2024-05-29T19:55:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Networking issue

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Can't test due to a bug https://expensify.slack.com/archives/C01GTK53T8Q/p1717012386285909

mountiny · 2024-05-29T22:01:46Z

    const accountID = Number(route.params?.accountID ?? 0);
    const isCurrentUser = session?.accountID === accountID;
-    const details: PersonalDetails | EmptyObject = personalDetails?.[accountID] ?? (ValidationUtils.isValidAccountRoute(accountID) ? {} : {accountID: 0});
+    const isValidAccountId = ValidationUtils.isValidAccountRoute(accountID);


Naming styles

Suggested change

const isValidAccountId = ValidationUtils.isValidAccountRoute(accountID);

const isValidAccountID = ValidationUtils.isValidAccountRoute(accountID);

mountiny · 2024-05-29T22:01:51Z


    const hasAvatar = Boolean(details.avatar);
    const isLoading = Boolean(personalDetailsMetadata?.[accountID]?.isLoading) || isEmptyObject(details);
+    const shouldShowBlockingView = !isValidAccountId && !isLoading;


mountiny · 2024-05-29T22:02:17Z

    return (
        <ScreenWrapper testID={ProfilePage.displayName}>
-            <FullPageNotFoundView shouldShow={CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID)}>
+            <FullPageNotFoundView shouldShow={shouldShowBlockingView || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID)}>


the other suggestion

Suggested change

<FullPageNotFoundView shouldShow={shouldShowBlockingView || CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID)}>

<FullPageNotFoundView shouldShow={shouldShowBlockingView}>

Kicu · 2024-05-30T15:19:44Z

@mountiny suggestions implemented

mountiny

thanks @s77rt all good on your side too?

s77rt · 2024-05-31T01:01:46Z

@mountiny Yes! Looks good to me 🚀

OSBotify · 2024-06-03T10:44:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:35:54Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix normal Profile Page displayed for invalid accountID

773ea3d

Kicu marked this pull request as ready for review May 29, 2024 15:13

Kicu requested a review from a team as a code owner May 29, 2024 15:13

melvin-bot Bot requested review from s77rt and removed request for a team May 29, 2024 15:13

Kicu mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-13] User profile - App shows Hidden profile instead of not here page when profile link is invalid #42750

Closed

6 tasks

mountiny assigned Kicu May 29, 2024

s77rt reviewed May 29, 2024

View reviewed changes

s77rt approved these changes May 29, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny May 29, 2024 19:55

mountiny reviewed May 29, 2024

View reviewed changes

Add fixes after review

466639f

mountiny approved these changes May 30, 2024

View reviewed changes

mountiny merged commit e174f18 into Expensify:main Jun 3, 2024

This was referenced Jun 3, 2024

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-13] Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #42987

Closed

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

kosmydel mentioned this pull request Jun 5, 2024

cleanup: remove DetailsPage.tsx #42385

Merged

49 tasks

Kicu deleted the kicu/42750-profile-fix branch July 24, 2024 14:51

	const shouldShowBlockingView = !isValidAccountId && !isLoading;
	const shouldShowBlockingView = (!isValidAccountId && !isLoading) \|\| CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID);

	const isValidAccountId = ValidationUtils.isValidAccountRoute(accountID);
	const isValidAccountID = ValidationUtils.isValidAccountRoute(accountID);

	<FullPageNotFoundView shouldShow={shouldShowBlockingView \|\| CONST.RESTRICTED_ACCOUNT_IDS.includes(accountID)}>
	<FullPageNotFoundView shouldShow={shouldShowBlockingView}>

Uh oh!

Conversation

Kicu commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Kicu commented May 29, 2024

Uh oh!

melvin-bot Bot commented May 29, 2024

Uh oh!

s77rt May 29, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny May 29, 2024

Choose a reason for hiding this comment

Uh oh!

s77rt commented May 29, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny May 29, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny May 29, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny May 29, 2024

Choose a reason for hiding this comment

Uh oh!

Kicu commented May 30, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

s77rt commented May 31, 2024

Uh oh!

OSBotify commented Jun 3, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kicu commented May 29, 2024 •

edited

Loading