fix Unread message marker disappeared for next message by tienifr · Pull Request #42568 · Expensify/App

tienifr · 2024-05-24T01:18:30Z

Details

Fixed Issues

$ #39871
PROPOSAL: #39871 (comment)

Tests

User B send message to User A
Chat between users marked as unread (for user A)
User A navigates to chat with user B
User B send another message
Verify that after step 3, user A sees a new message marker with a green line above first message from user B. The new marker line is displayed over the original unread message
Verify that after step 4, the new marker line remains, as messages come through. It won’t go away unless user switches to another chat.

Verify that no errors appear in the JS console

Offline tests

QA Steps

User B send message to User A
Chat between users marked as unread (for user A)
User A navigates to chat with user B
User B send another message
Verify that after step 3, user A sees a new message marker with a green line above first message from user B. The new marker line is displayed over the original unread message
Verify that after step 4, the new marker line remains, as messages come through. It won’t go away unless user switches to another chat.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

output.mp4

Android: mWeb Chrome

output.mp4

iOS: Native

output.mp4

iOS: mWeb Safari

output.mp4

MacOS: Chrome / Safari

output.mp4

MacOS: Desktop

output.mp4

melvin-bot · 2024-05-24T01:53:47Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077 · 2024-05-26T16:45:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

0-android.mp4

Android: mWeb Chrome

0-mobile-chrome.mp4

iOS: Native

0-ios.mp4

iOS: mWeb Safari

0-mobile-safari.mp4

MacOS: Chrome / Safari

0-web.mp4

MacOS: Desktop

0-desktop.mp4

eh2077 · 2024-05-27T16:05:20Z

Did additional tests and looks good

0-additional_tests.mp4

MonilBhavsar · 2024-05-28T11:58:57Z


 /** Marks the new report actions as read */
-function readNewestAction(reportID: string) {
+function readNewestAction(reportID: string, shouldResetUnread = false) {


shouldResetUnreadMarker is a better name, IMO
And can we add a comment here to explain the parameter

@tienifr Friendly bump, wdyt about the naming suggestion ^ ?

MonilBhavsar · 2024-05-28T11:59:31Z

Thanks @eh2077 for additional testing! 🙌

tienifr · 2024-05-31T11:30:23Z

@MonilBhavsar @eh2077 I merged main and resolved comment

MonilBhavsar · 2024-05-31T12:08:04Z

-function readNewestAction(reportID: string) {
+/** Marks the new report actions as read
+ *
+ * @param shouldResetUnreadMarker Should we reset unread indicator


Thanks for adding! but this comment is self-explanatory by reading the name. Can you add more details like in which particular case we're adding it to not reset the marker

I updated the comment. @MonilBhavsar Can you help check it?

MonilBhavsar

Thanks!

OSBotify · 2024-06-04T05:40:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:35:19Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix Unread message marker disappeared for next message

3fec39f

tienifr marked this pull request as ready for review May 24, 2024 01:53

tienifr requested a review from a team as a code owner May 24, 2024 01:53

melvin-bot Bot removed the request for review from a team May 24, 2024 01:53

melvin-bot Bot requested a review from eh2077 May 24, 2024 01:53

tienifr mentioned this pull request May 24, 2024

[HOLD for payment 2024-06-13] [$250] Chat - Unread message marker disappeared for next message if user stays in chat #39871

Closed

6 tasks

eh2077 approved these changes May 27, 2024

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar May 27, 2024 16:05

MonilBhavsar reviewed May 28, 2024

View reviewed changes

tienifr added 2 commits May 31, 2024 18:27

fix merge main

9991e5c

fix rename param to shouldResetUnreadMarker

3a3e436

fix comment

7c2cdab

MonilBhavsar reviewed May 31, 2024

View reviewed changes

fix add comment

961e227

MonilBhavsar approved these changes Jun 4, 2024

View reviewed changes

MonilBhavsar merged commit d3e3920 into Expensify:main Jun 4, 2024

github-actions Bot mentioned this pull request Jun 4, 2024

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

lanitochka17 mentioned this pull request Jun 5, 2024

Chat - Green line is not displayed #43148

Closed

6 tasks

paultsimura mentioned this pull request Oct 8, 2024

[$250] Web - Chat - Message marked as new after reading it and scrolling up and down the conversation #50318

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix Unread message marker disappeared for next message#42568

fix Unread message marker disappeared for next message#42568
MonilBhavsar merged 5 commits into
Expensify:mainfrom
tienifr:fix/39871

tienifr commented May 24, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented May 24, 2024

Uh oh!

eh2077 commented May 26, 2024 •

edited

Loading

Uh oh!

eh2077 commented May 27, 2024

Uh oh!

MonilBhavsar May 28, 2024

Uh oh!

eh2077 May 29, 2024

Uh oh!

MonilBhavsar commented May 28, 2024

Uh oh!

tienifr commented May 31, 2024

Uh oh!

MonilBhavsar May 31, 2024

Uh oh!

tienifr Jun 3, 2024

Uh oh!

MonilBhavsar left a comment

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tienifr commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 24, 2024

Uh oh!

eh2077 commented May 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented May 27, 2024

Uh oh!

MonilBhavsar May 28, 2024

Choose a reason for hiding this comment

Uh oh!

eh2077 May 29, 2024

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented May 28, 2024

Uh oh!

tienifr commented May 31, 2024

Uh oh!

MonilBhavsar May 31, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

OSBotify commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented May 24, 2024 •

edited

Loading

eh2077 commented May 26, 2024 •

edited

Loading