Skip to content

Delay in removing mention list when pressing CMD+K #42255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 3 commits into from
Jun 3, 2024
Merged

Delay in removing mention list when pressing CMD+K #42255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c214f69
Fix bug with delay in removing mention list when pressing CMD+K
ZhenjaHorbach May 16, 2024
c5e1968
Merge branch 'main' into mention-delay-in-removing-mention-list-when-…
ZhenjaHorbach May 16, 2024
9d1c506
add a little explanation
ZhenjaHorbach May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,12 @@ function ComposerWithSuggestions(
// eslint-disable-next-line no-param-reassign
isNextModalWillOpenRef.current = false;
}

// We want to blur the input immediately when a screen is out of focus.
if (!isFocused) {
textInputRef.current?.blur();
}

// We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused.
// We avoid doing this on native platforms since the software keyboard popping
// open creates a jarring and broken UX.
Expand Down