Skip to content

Redirect user to concierge when onboarding completed #42087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 14 commits into from
May 30, 2024
Merged

Redirect user to concierge when onboarding completed #42087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2edff29
redirect user to concierge when onboarding completed
skyweb331 May 13, 2024
efc236a
set onboarding completed as initial
skyweb331 May 14, 2024
3dfb293
remove unused onboarding onyx type
skyweb331 May 15, 2024
3aa75e9
replace withOnyx HOC with useOnyx hook
skyweb331 May 15, 2024
06706c4
fix route change on component rendering
skyweb331 May 15, 2024
9fef64b
navigate to concierge when navigation is ready
skyweb331 May 17, 2024
37aaff4
fix comment for concerige
skyweb331 May 22, 2024
f2758fc
allow array for nvp_onboarding onyx
skyweb331 May 23, 2024
fd3dd47
add comment for nvp_onboarding type
skyweb331 May 23, 2024
bfeb14b
fix prettier
skyweb331 May 27, 2024
b97b952
Merge remote-tracking branch 'upstream/main' into onboarding
skyweb331 May 28, 2024
7a4c242
fix merge error
skyweb331 May 28, 2024
e4a2d44
fix onboarding modal flashing
skyweb331 May 28, 2024
2dd159d
fix return null
skyweb331 May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ONYXKEYS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,10 @@ type OnyxValuesMapping = {
[ONYXKEYS.ACCOUNT]: OnyxTypes.Account;
[ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID]: string;
[ONYXKEYS.NVP_IS_FIRST_TIME_NEW_EXPENSIFY_USER]: boolean;

// NVP_ONBOARDING is an array for old users.
Comment thread
mountiny marked this conversation as resolved.
[ONYXKEYS.NVP_ONBOARDING]: Onboarding | [];

[ONYXKEYS.ACTIVE_CLIENTS]: string[];
[ONYXKEYS.DEVICE_ID]: string;
[ONYXKEYS.IS_SIDEBAR_LOADED]: boolean;
Expand Down
24 changes: 23 additions & 1 deletion src/libs/Navigation/AppNavigator/Navigators/OnboardingModalNavigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
import {createStackNavigator} from '@react-navigation/stack';
import React, {useCallback} from 'react';
import React, {useCallback, useEffect} from 'react';
import {View} from 'react-native';
import {useOnyx} from 'react-native-onyx';
import NoDropZone from '@components/DragAndDrop/NoDropZone';
import useKeyboardShortcut from '@hooks/useKeyboardShortcut';
import useOnboardingLayout from '@hooks/useOnboardingLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import OnboardingModalNavigatorScreenOptions from '@libs/Navigation/AppNavigator/OnboardingModalNavigatorScreenOptions';
import Navigation from '@libs/Navigation/Navigation';
import type {OnboardingModalNavigatorParamList} from '@libs/Navigation/types';
import OnboardingRefManager from '@libs/OnboardingRefManager';
import OnboardingPersonalDetails from '@pages/OnboardingPersonalDetails';
import OnboardingPurpose from '@pages/OnboardingPurpose';
import OnboardingWork from '@pages/OnboardingWork';
import * as Report from '@userActions/Report';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import SCREENS from '@src/SCREENS';
import Overlay from './Overlay';

Expand All @@ -20,6 +24,21 @@ const Stack = createStackNavigator<OnboardingModalNavigatorParamList>();
function OnboardingModalNavigator() {
const styles = useThemeStyles();
const {shouldUseNarrowLayout} = useOnboardingLayout();
const [hasCompletedGuidedSetupFlow] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {
selector: (onboarding) => !Array.isArray(onboarding) && (onboarding?.hasCompletedGuidedSetupFlow ?? true),

@hungvu193 hungvu193 Jun 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line caused this issue: #43561
More detail in this comment

@skyweb331 skyweb331 Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, empty array means onboarding completed?

@mountiny mountiny Jun 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats a mistake. When the hasCompleted property is not defined it means the onboarding was completed given its old user and we do not want to show them the flow in that case

@skyweb331 skyweb331 Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, nvp_onbarding was empty array for new users in NewDot, which means, array indicates onboarding is not completed...
Is there any backend changes for this?

@mountiny mountiny Jun 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it should not be an empty array for new users. That is the case only for users that had account in OldDot before

});

useEffect(() => {
if (!hasCompletedGuidedSetupFlow) {
return;
}
Navigation.isNavigationReady().then(() => {
// Need to go back to previous route and then redirect to Concierge,
// otherwise going back on Concierge will go to onboarding and then redirected to Concierge again
Navigation.goBack();
Report.navigateToConciergeChat();
});
}, [hasCompletedGuidedSetupFlow]);

const outerViewRef = React.useRef<View>(null);

Expand All @@ -29,6 +48,9 @@ function OnboardingModalNavigator() {

useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ESCAPE, handleOuterClick, {shouldBubble: true});

if (hasCompletedGuidedSetupFlow) {
return null;
}
return (
<NoDropZone>
<Overlay />
Expand Down