Remove optimistic CLOSED actions on success by aldo-expensify · Pull Request #39008 · Expensify/App

aldo-expensify · 2024-03-26T18:09:54Z

Details

Deletes the optimistic CLOSED report action after the DeleteWorkspace has finalized. This is fine because we receive the server side CLOSED report actions in the request response.

Fixed Issues

$ #38839
PROPOSAL:

Tests

Go to staging.new.expensify.com.
Create a new workspace.
Go to #admin room.
Send a message.
Delete the workspace.
Go to #admin room.
Verify that it load fine

Verify that no errors appear in the JS console

Offline tests

Go to staging.new.expensify.com.
Create a new workspace.
Go to #admin room.
Send a message.
Go offline
Delete the workspace.
Check that everything looks normal, including the #admins room.
Go online
Go to #admin room.
Verify that it load fine

QA Steps

Go to staging.new.expensify.com.
Create a new workspace.
Go to #admin room.
Send a message.
Delete the workspace.
Go to #admin room.
Verify that it load fine

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Uploading Screen Recording 2024-03-26 at 11.11.02 AM.mov…

MacOS: Desktop

melvin-bot · 2024-03-26T18:09:59Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-03-26T22:37:00Z

Rory checked this solution here so I think we will proceed with this fix.

aldo-expensify · 2024-03-26T22:44:54Z

@sobitneupane are you around for reviewing?

situchan · 2024-03-26T22:47:33Z

I am around if @sobitneupane is sleeping

ishpaul777 · 2024-03-26T23:09:46Z

https://expensify.slack.com/archives/C01GTK53T8Q/p1711494040246099?thread_ts=1711394610.825829&cid=C01GTK53T8Q

ishpaul777 · 2024-03-26T23:10:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-03-27-05-06-07.mp4

Android: mWeb Chrome

Record_2024-03-27-05-13-17.mp4

iOS: Native

Screen.Recording.2024-03-27.at.4.37.24.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-27.at.4.47.06.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-27.at.4.38.39.AM.mov

MacOS: Desktop

Screen.Recording.2024-03-27.at.4.58.55.AM-1.mov

melvin-bot · 2024-03-26T23:41:41Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-03-26T23:51:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…d-reportactions Remove optimistic CLOSED actions on success (cherry picked from commit 29fd425)

OSBotify · 2024-03-27T00:38:36Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.56-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

aldo-expensify · 2024-03-27T00:47:40Z

Tested in staging and it works now:

Screen.Recording.2024-03-26.at.5.45.22.PM.mov

OSBotify · 2024-03-27T04:52:39Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify · 2024-03-28T23:38:28Z

Created issue to handle the follow up work for this: https://github.com/Expensify/Expensify/issues/383435

Remove optimistic CLOSED actions on success

2618a35

aldo-expensify self-assigned this Mar 26, 2024

aldo-expensify requested a review from a team as a code owner March 26, 2024 18:09

melvin-bot Bot removed the request for review from a team March 26, 2024 18:09

melvin-bot Bot requested a review from sobitneupane March 26, 2024 18:09

aldo-expensify mentioned this pull request Mar 26, 2024

[HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted #38839

Closed

6 tasks

aldo-expensify added 2 commits March 26, 2024 15:31

Use finallyData instead of optimisticData

7ecd3fe

Fix variable name

5b04afe

Prettier

33915d7

Add comment

704e854

yuwenmemon requested review from ishpaul777 and yuwenmemon March 26, 2024 23:37

yuwenmemon approved these changes Mar 26, 2024

View reviewed changes

ishpaul777 approved these changes Mar 26, 2024

View reviewed changes

melvin-bot Bot requested a review from grgia March 26, 2024 23:41

yuwenmemon merged commit 29fd425 into main Mar 26, 2024

yuwenmemon deleted the aldo_remove-optimistic-closed-reportactions branch March 26, 2024 23:44

OSBotify pushed a commit that referenced this pull request Mar 27, 2024

Merge pull request #39008 from Expensify/aldo_remove-optimistic-close…

856ac1a

…d-reportactions Remove optimistic CLOSED actions on success (cherry picked from commit 29fd425)

github-actions Bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove optimistic CLOSED actions on success#39008

Remove optimistic CLOSED actions on success#39008
yuwenmemon merged 5 commits into
mainfrom
aldo_remove-optimistic-closed-reportactions

aldo-expensify commented Mar 26, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

aldo-expensify commented Mar 26, 2024

Uh oh!

aldo-expensify commented Mar 26, 2024

Uh oh!

situchan commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 27, 2024

Uh oh!

aldo-expensify commented Mar 27, 2024 •

edited

Loading

Uh oh!

OSBotify commented Mar 27, 2024

Uh oh!

aldo-expensify commented Mar 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aldo-expensify commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

aldo-expensify commented Mar 26, 2024

Uh oh!

aldo-expensify commented Mar 26, 2024

Uh oh!

situchan commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 27, 2024

Uh oh!

aldo-expensify commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Mar 27, 2024

Uh oh!

aldo-expensify commented Mar 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aldo-expensify commented Mar 26, 2024 •

edited

Loading

ishpaul777 commented Mar 26, 2024 •

edited

Loading

aldo-expensify commented Mar 27, 2024 •

edited

Loading