[CP Stg] Make getContinuousReportActionChain consider any optimistic action by roryabraham · Pull Request #38968 · Expensify/App

roryabraham · 2024-03-25T23:17:53Z

Details

When generating reportActions optimistically, they are not given a previousReportActionID. This means that our rendering logic for generating the continuous chain of ReportActions in ReportActionsUtils.getContinuousReportActionChain has to have special handling of optimistic actions.

Currently, the way it works is we find the last non-pending action, then iterate from there to find the longest continuous chain, including any pending add actions.

This is complicated but works ok, except for that it only accounts for the optimistic ADD RBR pendingAction, and not for DELETE or UPDATE pendingActions.

This is meant to be a temporary solution - long term we should be optimistically generating previousReportActionID for any optimistic reportAction. We will create a follow-up task for that soon.

Fixed Issues

$ #38844

Tests

Open a report
Go offline
Send a message
Delete the message
verify that the action appears as strikethrough, and the other actions on the report are unaffected

Verify that no errors appear in the JS console

Offline tests

same as tests.

QA Steps

Follow the testing steps (simplified version of the original bug report)
Retest the original bug, verify that it's fixed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

…Delete

melvin-bot · 2024-03-26T17:01:58Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-03-26T17:02:04Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-03-26T17:02:26Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-03-26T17:03:32Z

On it! in 15 mins

ishpaul777 · 2024-03-26T17:38:23Z

@roryabraham looks like some thing is off with server, i am always offline can you confirm if that not only me please

ishpaul777 · 2024-03-26T17:54:43Z

Ok its resolved now

ishpaul777 · 2024-03-26T17:58:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-03-27-00-05-17.mp4

Android: mWeb Chrome

Record_2024-03-27-00-05-17.mp4

iOS: Native

Screen.Recording.2024-03-26.at.11.57.42.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-26.at.11.45.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-26.at.11.29.30.PM-1.mov

MacOS: Desktop

Screen.Recording.2024-03-27.at.12.10.32.AM-1.mov

ishpaul777 · 2024-03-26T18:09:39Z

Reliably able to reproduce https://expensify.slack.com/archives/C049HHMV9SM/p1711147499521539, following the test steps then turning on internet

Screen.Recording.2024-03-26.at.11.29.30.PM-1.mov

NikkiWines

Seems to work well

Screen.Recording.2024-03-26.at.10.58.56.mov

melvin-bot · 2024-03-26T22:39:45Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2024-03-26T22:42:20Z

discussed at length in slack here. Going to merge and CP to staging

…ainForOptimisticDelete Make getContinuousReportActionChain consider any optimistic action (cherry picked from commit 525b1ba)

OSBotify · 2024-03-26T23:07:25Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.56-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-03-26T23:33:33Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.56-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-03-27T04:52:36Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 2 commits March 25, 2024 16:17

Make getContinuousReportActionChain consider any optimistic action

ced6292

Ignore update actions

046780d

roryabraham mentioned this pull request Mar 25, 2024

[HOLD for payment 2024-04-05] Android - Chat - When offline, if a user requests money and then deletes the message, the page keeps loading #38844

Closed

6 tasks

roryabraham self-assigned this Mar 26, 2024

roryabraham added 2 commits March 26, 2024 09:55

Merge branch 'main' into Rory-IncorrectReportActionChainForOptimistic…

07217d5

…Delete

Remove debug logs

df38b41

roryabraham changed the title ~~[WIP] Make getContinuousReportActionChain consider any optimistic action~~ Make getContinuousReportActionChain consider any optimistic action Mar 26, 2024

roryabraham marked this pull request as ready for review March 26, 2024 17:01

roryabraham requested a review from a team as a code owner March 26, 2024 17:01

melvin-bot Bot requested review from situchan and removed request for a team March 26, 2024 17:01

roryabraham requested review from a team and NikkiWines and removed request for situchan March 26, 2024 17:01

melvin-bot Bot requested review from akinwale and removed request for a team March 26, 2024 17:02

roryabraham requested review from a team and ishpaul777 March 26, 2024 17:02

melvin-bot Bot removed the request for review from a team March 26, 2024 17:02

melvin-bot Bot requested a review from allroundexperts March 26, 2024 17:02

NikkiWines approved these changes Mar 26, 2024

View reviewed changes

ishpaul777 approved these changes Mar 26, 2024

View reviewed changes

melvin-bot Bot requested a review from amyevans March 26, 2024 22:39

roryabraham changed the title ~~Make getContinuousReportActionChain consider any optimistic action~~ [CP Stg] Make getContinuousReportActionChain consider any optimistic action Mar 26, 2024

roryabraham merged commit 525b1ba into main Mar 26, 2024

roryabraham deleted the Rory-IncorrectReportActionChainForOptimisticDelete branch March 26, 2024 22:42

OSBotify pushed a commit that referenced this pull request Mar 26, 2024

Merge pull request #38968 from Expensify/Rory-IncorrectReportActionCh…

9f2a7e3

…ainForOptimisticDelete Make getContinuousReportActionChain consider any optimistic action (cherry picked from commit 525b1ba)

github-actions Bot mentioned this pull request Mar 26, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

Uh oh!

Conversation

roryabraham commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024

Uh oh!

ishpaul777 commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Mar 26, 2024

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Mar 26, 2024

Uh oh!

roryabraham commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 26, 2024

Uh oh!

OSBotify commented Mar 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roryabraham commented Mar 25, 2024 •

edited

Loading

ishpaul777 commented Mar 26, 2024 •

edited

Loading