Skip to content

[No QA] [TS migration] Migrate 'withFailTimeout.js' HOC to TypeScript #38923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 3 commits into from
Mar 26, 2024
Merged

[No QA] [TS migration] Migrate 'withFailTimeout.js' HOC to TypeScript #38923

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0f6862
migrate the file
war-in Mar 25, 2024
9561f75
do not use `??`
war-in Mar 26, 2024
11c72ea
Merge branch 'main' into ts/war-in/with-fail-timeout-hoc
war-in Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/e2e/utils/withFailTimeout.js → tests/e2e/utils/withFailTimeout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import CONFIG from '../config';

const TIMEOUT = process.env.INTERACTION_TIMEOUT || CONFIG.INTERACTION_TIMEOUT;
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- nullish coalescing doesn't achieve the same result in this case
const TIMEOUT = Number(process.env.INTERACTION_TIMEOUT || CONFIG.INTERACTION_TIMEOUT);

const withFailTimeout = (promise, name) =>
const withFailTimeout = (promise: Promise<void>, name: string): Promise<void> =>
new Promise((resolve, reject) => {
const timeoutId = setTimeout(() => {
reject(new Error(`"${name}": Interaction timed out after ${(TIMEOUT / 1000).toFixed(0)}s`));
}, Number(TIMEOUT));
}, TIMEOUT);

promise
.then((value) => {
Expand Down