Skip to content

[NO QA] Update Card typescript Types #38747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariaHCD merged 6 commits into from
Apr 5, 2024
Merged

[NO QA] Update Card typescript Types #38747

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
177bd39
update card typescript types
grgia Mar 21, 2024
a641c83
nameValuePairs
grgia Mar 22, 2024
c7516ee
add other keys that may be returned
grgia Mar 22, 2024
35909dc
Fix Types
grgia Mar 25, 2024
36bdea8
remove unused keys
grgia Mar 25, 2024
efce082
fix comments
grgia Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/types/onyx/Card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,22 @@ type Card = {
bank: string;
availableSpend: number;
domainName: string;
maskedPan?: string; // do not reference, removing as part of Expensify/App#27943
lastFourPAN?: string;
cardName: string;
cardTitle: string; // used only for virtual limit cards
limitType: ValueOf<typeof CONST.EXPENSIFY_CARD.LIMIT_TYPES>;
isAdminIssuedVirtualCard: boolean;
isVirtual: boolean;
isVirtual: boolean; // Deprecating, use nameValuePairs.isVirtual
fraud: ValueOf<typeof CONST.EXPENSIFY_CARD.FRAUD_TYPES>;
cardholderFirstName: string;
cardholderLastName: string;
errors?: OnyxCommon.Errors;
isLoading?: boolean;
nameValuePairs?: {
limitType?: ValueOf<typeof CONST.EXPENSIFY_CARD.LIMIT_TYPES>;
cardTitle?: string; // Used only for admin-issued virtual cards
issuedBy?: number;
Comment thread
grgia marked this conversation as resolved.
hasCustomUnapprovedExpenseLimit?: boolean;
unapprovedExpenseLimit?: number;
feedCountry?: string;
isVirtual?: boolean;
previousState?: number;
expirationDate?: string;
};
};

type TCardDetails = {
Expand Down