Skip to content

[CP Staging] Revert "[TS migration] Migrate 'Sidebar' page to TypeScript"#38340

Merged
mountiny merged 1 commit into
mainfrom
revert-36847-ts-migration/Sidebar
Mar 15, 2024
Merged

[CP Staging] Revert "[TS migration] Migrate 'Sidebar' page to TypeScript"#38340
mountiny merged 1 commit into
mainfrom
revert-36847-ts-migration/Sidebar

Conversation

@AndrewGable

Copy link
Copy Markdown
Contributor

Reverts #36847

@github-actions

Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny
mountiny marked this pull request as ready for review March 15, 2024 10:26
@mountiny
mountiny requested a review from a team as a code owner March 15, 2024 10:26
@mountiny mountiny changed the title Revert "[TS migration] Migrate 'Sidebar' page to TypeScript" [CP Staging] Revert "[TS migration] Migrate 'Sidebar' page to TypeScript" Mar 15, 2024
@melvin-bot
melvin-bot Bot removed the request for review from a team March 15, 2024 10:26
@melvin-bot

melvin-bot Bot commented Mar 15, 2024

Copy link
Copy Markdown

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested a review from rlinoz March 15, 2024 10:26
@mountiny

Copy link
Copy Markdown
Contributor

Fixes a deploy blocker which can make staging unusable https://expensify.slack.com/archives/C049HHMV9SM/p1710497926061779

its a straight revert so we can proceed with the TS check failing

@mountiny
mountiny merged commit f09f2cb into main Mar 15, 2024
@mountiny
mountiny deleted the revert-36847-ts-migration/Sidebar branch March 15, 2024 10:27
@melvin-bot melvin-bot Bot added the Emergency label Mar 15, 2024
@melvin-bot

melvin-bot Bot commented Mar 15, 2024

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor

Explained above

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.53-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants