fix: allow selection list to be greyed for tags by allroundexperts · Pull Request #38332 · Expensify/App

allroundexperts · 2024-03-14T17:49:30Z

Details

This PR adds offline behaviour to the tag display list.

Fixed Issues

$ #38289
PROPOSAL: N/A

Tests

Create a Control workspace in OD
Enter the following in the console, while the workspace is open:

var p = Policy.getActive();
p.policy.areTagsEnabled = true;
p.save();

Open ND and go to workspace settings -> tags
Go offline
Create a new tag named 'Test' (Mind the casing please)
Verify that the tag is displayed as greyed out
Enter the following in console, replacing POLICY_ID_HERE with your workspace id:

Onyx.merge('policyTags_POLICY_ID_HERE', { Tag: { tags: { Test: { errors: { 'test': 'Random error' } } } } })

Verify that an error is displayed below the tag.
Click the x button next to the error.
Verify that the error is dismissed when pressed x.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Create a Control workspace in OD
Enter the following in the console, while the workspace is open:

var p = Policy.getActive();
p.policy.areTagsEnabled = true;
p.save();

Open ND and go to workspace settings -> tags
Go offline
Create a new tag named 'Test' (Mind the casing please)
Verify that the tag is displayed as greyed out
Enter the following in console, replacing POLICY_ID_HERE with your workspace id:

Onyx.merge('policyTags_POLICY_ID_HERE', { Tag: { tags: { Test: { errors: { 'test': 'Random error' } } } } })

Verify that an error is displayed below the tag.
Click the x button next to the error.
Verify that the error is dismissed when pressed x.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-14.at.10.39.14.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-14.at.10.41.07.PM.mov

iOS: Native

Screen.Recording.2024-03-14.at.10.33.06.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-14.at.10.31.03.PM.mov

Screen.Recording.2024-03-14.at.10.30.33.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-14.at.10.00.57.PM.mov

Screen.Recording.2024-03-14.at.10.20.48.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-14.at.10.27.10.PM.mov

Screen.Recording.2024-03-14.at.10.28.00.PM.mov

melvin-bot · 2024-03-14T17:49:35Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-03-14T22:11:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-03-15-04-48-42.mp4

Android: mWeb Chrome

Record_2024-03-15-04-55-22.mp4

iOS: Native

Screen.Recording.2024-03-15.at.3.51.36.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-15.at.4.13.51.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-15.at.4.11.46.AM.mov

MacOS: Desktop

mountiny

Looks good

ishpaul777 · 2024-03-14T22:25:17Z

+                [tagName]: {
+                    errors: null,
+                },


shouldn't we remove the tag also?

We can if we want to. @mountiny @luacmartins Please enlighten us!

Nice catch. Yes, I think in the ADD case, we should also remove the tag. For UPDATE or DELETE we just clear the error.

Commented above

ishpaul777 · 2024-03-14T23:07:00Z

@allroundexperts any update on when can you finish?

allroundexperts · 2024-03-14T23:42:48Z

@ishpaul777 done!

ishpaul777 · 2024-03-14T23:56:52Z

+                    tag.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD
+                        ? null
+                        : {
+                              errors: null,
+                          },
+            },


I dont think this is gonna work, we update pendingAction to null when request fail, check the failureData in function just above it.

Screen.Recording.2024-03-15.at.5.29.30.AM.mov

Let's follow the same pattern as we have in this PR

luacmartins · 2024-03-15T00:05:19Z

+                    tag.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD
+                        ? null
+                        : {
+                              errors: null,
+                          },
+            },


Let's follow the same pattern as we have in this PR

ishpaul777

Confirmed the fix works well!

Screen.Recording.2024-03-15.at.5.52.02.AM.mov

OSBotify · 2024-03-15T00:35:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-15T10:30:13Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-18T16:19:51Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.53-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: allow selection list to be greyed for tags

43a94aa

allroundexperts requested a review from a team as a code owner March 14, 2024 17:49

melvin-bot Bot requested review from ishpaul777 and removed request for a team March 14, 2024 17:49

allroundexperts mentioned this pull request Mar 14, 2024

[HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline #38289

Closed

6 tasks

luacmartins self-requested a review March 14, 2024 18:03

luacmartins previously approved these changes Mar 14, 2024

View reviewed changes

mountiny previously approved these changes Mar 14, 2024

View reviewed changes

mountiny assigned allroundexperts Mar 14, 2024

ishpaul777 reviewed Mar 14, 2024

View reviewed changes

fix: remove tags along with errors

c047c0b

allroundexperts dismissed stale reviews from mountiny and luacmartins via c047c0b March 14, 2024 23:42

ishpaul777 reviewed Mar 14, 2024

View reviewed changes

luacmartins approved these changes Mar 14, 2024

View reviewed changes

luacmartins requested changes Mar 15, 2024

View reviewed changes

fix: remove tags along with errors

861fa37

allroundexperts requested a review from luacmartins March 15, 2024 00:12

luacmartins approved these changes Mar 15, 2024

View reviewed changes

ishpaul777 approved these changes Mar 15, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny March 15, 2024 00:24

luacmartins merged commit be9a682 into Expensify:main Mar 15, 2024

github-actions Bot mentioned this pull request Mar 15, 2024

Deploy Checklist: New Expensify 2024-03-15 #38382

Closed

35 tasks

lanitochka17 mentioned this pull request Mar 15, 2024

Web - No error is displayed under the tag after executing the command in the consol #38410

Closed

6 tasks

allroundexperts mentioned this pull request Mar 17, 2024

fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

Merged

50 tasks

Uh oh!

Conversation

allroundexperts commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 14, 2024

Uh oh!

ishpaul777 commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Mar 14, 2024

Uh oh!

allroundexperts commented Mar 14, 2024

Uh oh!

ishpaul777 Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 15, 2024

Uh oh!

OSBotify commented Mar 15, 2024

Uh oh!

OSBotify commented Mar 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

allroundexperts commented Mar 14, 2024 •

edited

Loading

ishpaul777 commented Mar 14, 2024 •

edited

Loading

ishpaul777 Mar 14, 2024 •

edited

Loading