Skip to content

Clean up the PersonalDetails type #38306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 1 commit into from
Mar 15, 2024
Merged

Clean up the PersonalDetails type #38306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/report/ReportFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function ReportFooter({
if (email) {
assignee = Object.values(allPersonalDetails).find((value) => value?.login === email) ?? {};
}
Task.createTaskAndNavigate(report.reportID, title, '', assignee?.login ?? '', assignee.accountID, assignee.assigneeChatReport, report.policyID);
Task.createTaskAndNavigate(report.reportID, title, '', assignee?.login ?? '', assignee.accountID, undefined, report.policyID);
return true;
},
[allPersonalDetails, report.policyID, report.reportID],
Expand Down
4 changes: 0 additions & 4 deletions src/types/onyx/PersonalDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type {AvatarSource} from '@libs/UserUtils';
import type TIMEZONES from '@src/TIMEZONES';
import type * as OnyxCommon from './OnyxCommon';
import type Report from './Report';

type SelectedTimezone = (typeof TIMEZONES)[number];

Expand Down Expand Up @@ -80,9 +79,6 @@ type PersonalDetails = OnyxCommon.OnyxValueWithOfflineFeedback<{

/** Status of the current user from their personal details */
status?: Status;

/** Chat report with assignee of task */
assigneeChatReport?: Report;
}>;

type PersonalDetailsList = Record<string, PersonalDetails | null>;
Expand Down