Add optimistic created action for iou report and create created action for chat report by nkdengineer · Pull Request #38197 · Expensify/App

nkdengineer · 2024-03-13T04:23:12Z

~~HOLD https://github.com/Expensify/Web-Expensify/pull/41299~~

Details

Add optimistic created action for iou report and create created action for chat report

Fixed Issues

$ #38141
PROPOSAL: #38141 (comment)

Tests

Go FAB > Send money
Enter a valid amount and enter a new contact
Confirm to send money
From chat report, click on report preview
After IOU report is opened, verify that the total display in header

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go FAB > Send money
Enter a valid amount and enter a new contact
Confirm to send money
From chat report, click on report preview
After IOU report is opened, verify that the total display in header

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-13.at.11.07.22.mov

Android: mWeb Chrome

Screen.Recording.2024-03-13.at.11.00.08.mov

iOS: Native

Uploading Screen Recording 2024-03-13 at 11.22.43.mov…

iOS: mWeb Safari

Screen.Recording.2024-03-13.at.10.57.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-13.at.10.51.45.mov

MacOS: Desktop

Screen.Recording.2024-03-13.at.11.18.43.mov

…n for chat report

melvin-bot · 2024-03-13T04:23:45Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura

In general looks good, just minor optimisation suggestion.

paultsimura · 2024-03-13T12:58:27Z

+            [optimisticCreatedActionForIOUReport.reportActionID]: {
+                ...(optimisticCreatedActionForIOUReport as OnyxTypes.ReportAction),
+            },


Let's swap these 2 actions to keep them in the correct order. Also, I think we can use just:

[optimisticCreatedActionForIOUReport.reportActionID]: optimisticCreatedActionForIOUReport,

paultsimura · 2024-03-13T13:01:11Z

            true,
        );

+    const optimisticCreatedActionForChatReport = ReportUtils.buildOptimisticCreatedReportAction(recipientEmail);


With this change, now in every place where we call ReportUtils.buildOptimisticMoneyRequestEntities(), we build an optimistic CREATED action for the Chat Report.

Let's move this action creation inside the ReportUtils.buildOptimisticMoneyRequestEntities and reuse it in all 4 places.

…tEntities function

nkdengineer · 2024-03-14T07:46:50Z

@paultsimura I updated buildOptimisticMoneyRequestEntities function.

paultsimura

Thanks, the changes look good. Just one minor change request and we can hold for the BE changes.

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

paultsimura · 2024-03-14T11:52:27Z

The changes look good, we'll hold for the BE changes now.
cc: @rlinoz

paultsimura · 2024-03-15T17:41:21Z

@nkdengineer could you please update the logic to pass the param based on this comment? #38141 (comment)

nkdengineer · 2024-03-18T05:11:18Z

@paultsimura I updated.

paultsimura · 2024-03-18T08:06:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android09.10.mp4

Android: mWeb Chrome

chrome09.10.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-18.at.09.04.3309.05.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-03-18.at.09.01.5009.05.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-03-22.at.22.23.3622.24.mp4

MacOS: Desktop

Screen.Recording.2024-03-18.at.08.56.5608.57.mp4

paultsimura · 2024-03-18T08:17:01Z

Thanks, looks good – need to wait for the BE PR to hit production, I'll retest 1 case and we'll be good to go ✔️

paultsimura · 2024-03-22T15:01:00Z

@rlinoz any updates on the BE PR?

rlinoz · 2024-03-22T16:04:56Z

Got deployed to staging yesterday

paultsimura

LGTM ✔️

paultsimura · 2024-03-22T21:27:05Z

@rlinoz I tested against the Staging server – works well. Feel free to check and merge after the BE PR is in production.

rlinoz

Looks good, thanks!

OSBotify · 2024-03-26T14:04:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

add optimistic created action for iou report and create created actio…

6ab4523

…n for chat report

nkdengineer marked this pull request as ready for review March 13, 2024 04:23

nkdengineer requested a review from a team as a code owner March 13, 2024 04:23

melvin-bot Bot requested review from paultsimura and removed request for a team March 13, 2024 04:23

paultsimura suggested changes Mar 13, 2024

View reviewed changes

nkdengineer added 2 commits March 14, 2024 14:30

Merge branch 'main' into fix/38141

3164440

create created action for report report in buildOptimisticMoneyReques…

f327edf

…tEntities function

paultsimura suggested changes Mar 14, 2024

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

Update src/libs/ReportUtils.ts

d9eecf1

Co-authored-by: Pavlo Tsimura <paultsimura@gmail.com>

nkdengineer added 2 commits March 18, 2024 11:55

Merge branch 'main' into fix/38141

99f5576

add createdIOUReportActionID param to sendMoney API

3538559

paultsimura approved these changes Mar 22, 2024

View reviewed changes

melvin-bot Bot requested a review from rlinoz March 22, 2024 21:25

paultsimura approved these changes Mar 22, 2024

View reviewed changes

rlinoz changed the title ~~Add optimistic created action for iou report and create created action for chat report~~ [HOLD Web-E#41299] Add optimistic created action for iou report and create created action for chat report Mar 25, 2024

rlinoz changed the title ~~[HOLD Web-E#41299] Add optimistic created action for iou report and create created action for chat report~~ Add optimistic created action for iou report and create created action for chat report Mar 26, 2024

rlinoz approved these changes Mar 26, 2024

View reviewed changes

rlinoz merged commit e243425 into Expensify:main Mar 26, 2024

github-actions Bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

melvin-bot Bot mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-04-05] [$500] when sending money offline, the optimistically created IOU Report shows the top skeleton. #38141

Closed

6 tasks

Uh oh!

Conversation

nkdengineer commented Mar 13, 2024 • edited by rlinoz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 13, 2024

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

paultsimura Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

paultsimura Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Mar 14, 2024

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paultsimura commented Mar 14, 2024

Uh oh!

paultsimura commented Mar 15, 2024

Uh oh!

nkdengineer commented Mar 18, 2024

Uh oh!

paultsimura commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura commented Mar 18, 2024

Uh oh!

paultsimura commented Mar 22, 2024

Uh oh!

rlinoz commented Mar 22, 2024

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

paultsimura commented Mar 22, 2024

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Mar 13, 2024 •

edited by rlinoz

Loading

paultsimura commented Mar 18, 2024 •

edited

Loading