-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix - mWeb auto focus on reply in thread #37929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5e7121a
1450307
b7f306e
d7abc9d
f69df2a
69e6022
0d37448
c51602f
9e2c1d1
78d815b
1b9163c
aa4fe30
4c34830
31db23e
297cd03
2bf777e
822cf62
c27d74e
4a40236
335b5fa
6fd4517
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import ExpensiMark from 'expensify-common/lib/ExpensiMark'; | ||
| import type {MutableRefObject} from 'react'; | ||
| import React from 'react'; | ||
| import {InteractionManager} from 'react-native'; | ||
| // eslint-disable-next-line no-restricted-imports | ||
| import type {GestureResponderEvent, Text, View} from 'react-native'; | ||
| import type {OnyxEntry} from 'react-native-onyx'; | ||
|
|
@@ -200,7 +201,11 @@ const ContextMenuActions: ContextMenuAction[] = [ | |
| onPress: (closePopover, {reportAction, reportID}) => { | ||
| if (closePopover) { | ||
| hideContextMenu(false, () => { | ||
| ReportActionComposeFocusManager.focus(); | ||
| InteractionManager.runAfterInteractions(() => { | ||
| // Normally the focus callback of the main composer doesn't focus when willBlurTextInputOnTapOutside | ||
|
Comment on lines
+204
to
+205
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey guys, this failed for the case when keyboard was open, we fixed it in #55136 |
||
| // is false, so we need to pass true here to override this condition. | ||
| ReportActionComposeFocusManager.focus(true); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a comment here to explain why we are passing
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added but can u check the comments.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's avoid creating platform specific language. Can you answer this question without referencing "native": What behavior are we giving the callback by passing |
||
| }); | ||
| Report.navigateToAndOpenChildReport(reportAction?.childReportID ?? '0', reportAction, reportID); | ||
| }); | ||
| return; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.