Skip to content

Fix issues with the bold (unread) status on Workspace Item #37672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hayata-suenaga merged 3 commits into from
Mar 25, 2024
Merged

Fix issues with the bold (unread) status on Workspace Item #37672

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28326dd
add additional check for unread workspace utils
cdOut Mar 4, 2024
22f97e4
add clarifying comment
cdOut Mar 4, 2024
2c169b1
Merge branch 'main' into ideal-nav/fix-bold-issue
cdOut Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libs/WorkspacesSettingsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ function getWorkspacesUnreadStatuses(): Record<string, boolean> {
return;
}

workspacesUnreadStatuses[policyID] = ReportUtils.isUnread(report);
// When the only message of a report is deleted lastVisibileActionCreated is not reset leading to wrongly
// setting it Unread so we add additional condition here to avoid read workspace indicator from being bold.
workspacesUnreadStatuses[policyID] = ReportUtils.isUnread(report) && !!report.lastActorAccountID;
});

return workspacesUnreadStatuses;
Expand Down