Fix unable to adjust volume by clicking on any part of the volume slider by kowczarz · Pull Request #37094 · Expensify/App

kowczarz · 2024-02-22T17:15:36Z

Details

Fixed Issues

$ #36952

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

![android web](https://github.com/Expensify/App/assets/91068263/b847a5a9-6f10-47be-b7c0-7d78b55cd94b)

iOS: Native

![ios native](https://github.com/Expensify/App/assets/91068263/158d02e6-98d1-478d-82e3-e4a4066b5fb0)

iOS: mWeb Safari

![ios web](https://github.com/Expensify/App/assets/91068263/36a279a6-1278-4434-9db4-31966d929bf6)

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop_H.265.mp4

melvin-bot · 2024-02-22T17:38:23Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2024-02-22T19:03:40Z

+        volume.value = Math.min(Math.max(val, 0), 1);
+    };
+
    const pan = Gesture.Pan()


notable lack of memoization in this component. NAB without benchmarks though

jakub-trzebiatowski · 2024-02-23T12:12:03Z

        setSliderHeight(e.nativeEvent.layout.height);
    };

+    const gestureEventHandler = (event) => {


This name is against the Expensify guidelines. I believe it should be handleGestureEvent.

Or, even better, changeVolumeOnPan

@kowczarz Bump! 🙂

…ume-on-press

Skalakid · 2024-02-26T16:23:09Z

@roryabraham @cubuspl42 I've added review changes

jakub-trzebiatowski · 2024-02-27T11:35:33Z

A minor thing, but video links don't render correctly:

jakub-trzebiatowski · 2024-02-27T11:42:32Z

In the future, prefer videos over screenshots for interactive behaviors. Screenshots are good for CSS/styling/visual fixes of static (non-moving content).

jakub-trzebiatowski · 2024-02-27T11:43:50Z

You should always fill-in the "Tests" section, even when the testing steps are trivial. In this case, I can guess the reasonable testing steps, but this is especially bad when the videos are lacking.

jakub-trzebiatowski · 2024-02-27T12:31:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

volume-slider-adjust-android-compressed.mp4

Android: mWeb Chrome

volume-slider-adjust-android-web-compressed.mp4

iOS: Native

volume-slider-adjust-ios-compressed.mp4

iOS: mWeb Safari

volume-slider-adjust-ios-web-compressed.mp4

MacOS: Chrome / Safari

volume-slider-adjust-web-converted.mp4

MacOS: Desktop

volume-slider-adjust-desktop-converted.mp4

jakub-trzebiatowski

I've run into two (very likely unrelated) issues:

on iOS/Native, I hear no sound at all. I use a simulator, but I can hear the sound of the uploaded video both in the Photos app and in Expensify on iOS/Web (Safari)
on iOS/Web (Safari), muting by tapping the "🔊" icon doesn't work

@kowczarz
Do these cases work for you?

Skalakid · 2024-02-28T07:45:14Z

Since @kowczarz is unavailable, I took over this issue and PR. VIdeos should be muted when playing for the first time. Also, the video slider shouldn't be visible on native devices.
I tested iOS/Native and everything seems to work fine with the volume.

iOS.native.mov

However, you are right with the iOS/Safari, muting by tapping the "🔊" icon doesn't work. I will try to fix it in this PR

Skalakid · 2024-02-28T08:06:47Z

@cubuspl42 I've just fixed the problem with the volume button on iOS/Safari. Please check if it is working for you now

jakub-trzebiatowski · 2024-02-28T08:22:47Z

In the case the iOS/Native sound issue was codec-related, here's the testing video I used:

rain_10s.mp4

Anyway, there's no reason to block this PR on that.

OSBotify · 2024-02-28T22:40:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:07:28Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-29T23:31:56Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kowczarz added 2 commits February 22, 2024 18:09

Add on begin pan gesture event

21be35d

Cleanup

4726489

kowczarz marked this pull request as ready for review February 22, 2024 17:38

kowczarz requested a review from a team as a code owner February 22, 2024 17:38

melvin-bot Bot removed the request for review from a team February 22, 2024 17:38

melvin-bot Bot requested a review from jakub-trzebiatowski February 22, 2024 17:38

roryabraham reviewed Feb 22, 2024

View reviewed changes

jakub-trzebiatowski suggested changes Feb 23, 2024

View reviewed changes

Skalakid added 2 commits February 26, 2024 17:13

Add review changes

9112cce

Merge branch 'main' into video-player-followups/fix-not-adjusting-vol…

075507a

…ume-on-press

roryabraham requested a review from jakub-trzebiatowski February 26, 2024 21:16

roryabraham mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-03-07] [$500] Video - Unable to adjust volume by clicking on any part of the volume slider #36952

Closed

6 tasks

jakub-trzebiatowski reviewed Feb 27, 2024

View reviewed changes

Fix volume button on iOS/Safari

f3cdd23

jakub-trzebiatowski approved these changes Feb 28, 2024

View reviewed changes

melvin-bot Bot requested a review from roryabraham February 28, 2024 08:48

roryabraham approved these changes Feb 28, 2024

View reviewed changes

roryabraham merged commit 3acf39f into Expensify:main Feb 28, 2024

github-actions Bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

Uh oh!

Conversation

kowczarz commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 22, 2024

Uh oh!

Uh oh!

roryabraham Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

Skalakid commented Feb 26, 2024

Uh oh!

jakub-trzebiatowski commented Feb 27, 2024

Uh oh!

jakub-trzebiatowski commented Feb 27, 2024

Uh oh!

jakub-trzebiatowski commented Feb 27, 2024

Uh oh!

jakub-trzebiatowski commented Feb 27, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

jakub-trzebiatowski left a comment

Choose a reason for hiding this comment

Uh oh!

Skalakid commented Feb 28, 2024

Uh oh!

Skalakid commented Feb 28, 2024

Uh oh!

jakub-trzebiatowski commented Feb 28, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kowczarz commented Feb 22, 2024 •

edited

Loading