Emoji picker: Round down window width (estimated list size) by dragnoir · Pull Request #36674 · Expensify/App

dragnoir · 2024-02-16T11:38:41Z

Details

Fixed Issues

$ #34522
PROPOSAL: #34522 (comment)

Tests

Go to any chat
Open emoji picker
Verify that all emojies are well aligned

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat
Open emoji picker
Verify that all emojies are well aligned

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

20240216_105624.mp4

Android: mWeb Chrome

20240216_110201.mp4

iOS: Native

20240216_122115.mp4

iOS: mWeb Safari

20240216_123743.mp4

MacOS: Chrome / Safari

20240216_113823.mp4

MacOS: Desktop

20240216_114112.mp4

melvin-bot · 2024-02-16T11:38:46Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-02-16T14:38:17Z

                />
            )}
-            <View style={listWrapperStyle}>
+            <View style={[listWrapperStyle, {width: containerWidth}]}>


Revert. Instead edit the passed listWrapperStyle in index.native.ts

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

dragnoir · 2024-02-16T16:02:28Z

@s77rt when I changed the code the issue is back, I am turning to the original version, the 1st one I submitted.

The width should be passed throw BAseEmojiPicker

s77rt · 2024-02-16T16:03:23Z

Can you double check? I'm not able to reproduce the bug

dragnoir · 2024-02-16T16:04:18Z

What device? I am using Pixel 7 Pro

s77rt · 2024-02-16T16:05:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-02-16T16:06:05Z

Same Pixel 7 Pro

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

dragnoir · 2024-02-16T16:20:37Z

@s77rt all good, it was just cache issue. Thank you

s77rt · 2024-02-16T16:36:58Z

Please add clear testing steps i.e. specify that the user should have a well aligned list of emojis

Also change the PR to title to something more descriptive

dragnoir · 2024-02-16T16:41:58Z

Please add clear testing steps i.e. specify that the user should have a well aligned list of emojis

Also change the PR to title to something more descriptive

DONE

s77rt · 2024-02-16T17:12:56Z

Remove step 4 and change step 3 to: Verify that all emojies are well aligned

s77rt · 2024-02-16T17:13:45Z

@dragnoir Can you make the title describe the change and not what it fixes

dragnoir · 2024-02-16T17:17:43Z

@s77rt done

s77rt · 2024-02-16T17:21:57Z

Can you change to: Emoji picker: Round down window width (estimated list size)

aldo-expensify · 2024-02-16T19:11:25Z

Thanks for the quick and good work!

OSBotify · 2024-02-16T19:15:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:50:10Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:56:14Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dragnoir added 2 commits February 16, 2024 11:03

fix: emoji picker misaligned

7359135

fix: prettier

e044747

melvin-bot Bot requested review from s77rt and removed request for a team February 16, 2024 11:38

s77rt suggested changes Feb 16, 2024

View reviewed changes

Rachid L and others added 2 commits February 16, 2024 15:58

Update src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.js

3b1b71d

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

Fix; width passed via listWrapperStyle in index.native.ts

3cda170

s77rt suggested changes Feb 16, 2024

View reviewed changes

Comment thread src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.js Outdated

Comment thread src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.js Outdated

Rachid L and others added 3 commits February 16, 2024 17:06

Update src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.js

7675c58

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

Update src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.js

68c905d

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

fix: naming listWidth

75903f7

s77rt approved these changes Feb 16, 2024

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify February 16, 2024 17:22

aldo-expensify approved these changes Feb 16, 2024

View reviewed changes

aldo-expensify merged commit c050a90 into Expensify:main Feb 16, 2024

github-actions Bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

Uh oh!

Conversation

dragnoir commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 16, 2024

Uh oh!

s77rt Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dragnoir commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Feb 16, 2024

Uh oh!

dragnoir commented Feb 16, 2024

Uh oh!

s77rt commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Feb 16, 2024

Uh oh!

dragnoir commented Feb 16, 2024

Uh oh!

s77rt commented Feb 16, 2024

Uh oh!

dragnoir commented Feb 16, 2024

Uh oh!

s77rt commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Feb 16, 2024

Uh oh!

dragnoir commented Feb 16, 2024

Uh oh!

s77rt commented Feb 16, 2024

Uh oh!

aldo-expensify commented Feb 16, 2024

Uh oh!

OSBotify commented Feb 16, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dragnoir commented Feb 16, 2024 •

edited

Loading

dragnoir commented Feb 16, 2024 •

edited

Loading

s77rt commented Feb 16, 2024 •

edited

Loading

s77rt commented Feb 16, 2024 •

edited

Loading