Move violation message below billable field by trevor-coleman · Pull Request #36533 · Expensify/App

trevor-coleman · 2024-02-14T18:07:30Z

Details

Moves the error message below the field on billable.

To do this I:

added a wrapper view around the violation messages
added style override props to to allow for alignment of the text

Fixed Issues

$ #36481

Tests

Pre-requisite: as an employee of a workspace, create an expense with Billable option toggled on.

As the admin of the workspace on OD, set "Re-bill expenses to clients" to Disabled.
As the employee on ND, go to the details page of the created expense.
The message "Billable no longer valid" should be displayed below the billable field.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Pre-requisite: as an employee of a workspace, create an expense with Billable option toggled on.

As the admin of the workspace on OldDot, set "Re-bill expenses to clients" to Disabled
As the employee on NewDot, go to the details page of the created expense.
The message "Billable no longer valid" should be displayed below the billable field.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Having HTTPS issues with the website on iOS, but didn't want to hold up the PR for them. I checked in desktop safari and it was fine.

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-02-14T18:47:38Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2024-02-14T18:52:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aimane-chnaif · 2024-02-14T19:25:57Z

@trevor-coleman I am confused by your comment

Because of the difference between web and native, just moving the messages below wasn't working, so I ended up leaving the violation messages where they are adding override props to the container and text styles that let me put them where they needed to be.

I am seeing that this PR just moved the message below View

aimane-chnaif · 2024-02-14T19:39:07Z

+                                violations={getViolationsForField('billable')}
+                                isLast
+                            />
+                        )}


I think you didn't push latest changes

Ah looks like not -- they are up now.

trevor-coleman · 2024-02-14T20:55:56Z

@trevor-coleman I am confused by your comment

Because of the difference between web and native, just moving the messages below wasn't working, so I ended up leaving the violation messages where they are adding override props to the container and text styles that let me put them where they needed to be.

I am seeing that this PR just moved the message below View

Sorry in the original issue we talked about moving the ViolationMessages component below the containing view in the code.

aimane-chnaif · 2024-02-14T20:58:38Z

ok so this PR is in good shape right now?

aimane-chnaif · 2024-02-14T21:11:00Z

what is expected design?

trevor-coleman · 2024-02-14T23:22:34Z

Should be good to go now.

aimane-chnaif · 2024-02-14T23:30:01Z

Looks good!

trevor-coleman · 2024-02-15T18:26:59Z

Just want to flag that tomorrow is my last day on the project, and I won't be available for further updates after that.

amyevans

LGTM, thanks!

OSBotify · 2024-02-15T19:01:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:48:55Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:54:59Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pecanoro · 2024-02-29T01:22:15Z

@aimane-chnaif Was an issue created when you reviewed this to pay for this issue? Making sure so we can close the original one

aimane-chnaif · 2024-02-29T03:54:20Z

@aimane-chnaif Was an issue created when you reviewed this to pay for this issue? Making sure so we can close the original one

I don't see any. Still expecting to be paid in #36481

pecanoro · 2024-02-29T15:18:39Z

@aimane-chnaif Ok, I will create an issue for the payment then

fix(Violations): move violation below billable field

87be2a3

trevor-coleman marked this pull request as ready for review February 14, 2024 18:47

trevor-coleman requested a review from a team as a code owner February 14, 2024 18:47

melvin-bot Bot removed the request for review from a team February 14, 2024 18:47

melvin-bot Bot requested a review from aimane-chnaif February 14, 2024 18:47

trevor-coleman mentioned this pull request Feb 14, 2024

IOU - Billable no longer valid violation is not displayed under the field #36481

Closed

6 tasks

aimane-chnaif reviewed Feb 14, 2024

View reviewed changes

add style overrides

872f22c

aimane-chnaif reviewed Feb 14, 2024

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestView.tsx Outdated

aimane-chnaif approved these changes Feb 14, 2024

View reviewed changes

melvin-bot Bot requested a review from amyevans February 14, 2024 23:32

fix(Violations): make boolean

1bb7027

amyevans approved these changes Feb 15, 2024

View reviewed changes

amyevans merged commit 96cb556 into Expensify:main Feb 15, 2024

github-actions Bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

pecanoro mentioned this pull request Feb 29, 2024

[Awaiting Payment 4th March] Payment issue for E/App PR#36533 #37516

Closed

Uh oh!

Conversation

trevor-coleman commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 14, 2024

Uh oh!

aimane-chnaif commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Feb 14, 2024

Uh oh!

aimane-chnaif Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

trevor-coleman Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

trevor-coleman commented Feb 14, 2024

Uh oh!

aimane-chnaif commented Feb 14, 2024

Uh oh!

aimane-chnaif commented Feb 14, 2024

Uh oh!

trevor-coleman commented Feb 14, 2024

Uh oh!

Uh oh!

aimane-chnaif commented Feb 14, 2024

Uh oh!

trevor-coleman commented Feb 15, 2024

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 15, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

pecanoro commented Feb 29, 2024

Uh oh!

aimane-chnaif commented Feb 29, 2024

Uh oh!

pecanoro commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

trevor-coleman commented Feb 14, 2024 •

edited

Loading

aimane-chnaif commented Feb 14, 2024 •

edited

Loading