Group chat stacked avatars are different in Search list and LHN by ZhenjaHorbach · Pull Request #36403 · Expensify/App

ZhenjaHorbach · 2024-02-13T11:21:12Z

Details

Group chat - Group chat stacked avatars are different in Search list and LHN

Fixed Issues

$ #36229
PROPOSAL: #36229 (comment)

Tests

Open app
Create a group chat.
Open the search list.
Verify that avatars on Search list item look the same as in LHN and Header chat

Verify that no errors appear in the JS console

Offline tests

Open app
Create a group chat.
Open the search list.
Verify that avatars on Search list item look the same as in LHN and Header chat

QA Steps

Open app
Create a group chat.
Open the search list.
Verify that avatars on Search list item look the same as in LHN and Header chat

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-13.at.12.11.39.mov

Android: mWeb Chrome

Screen.Recording.2024-02-13.at.12.11.39.mov

iOS: Native

Screen.Recording.2024-02-13.at.12.13.54.mov

iOS: mWeb Safari

Screen.Recording.2024-02-13.at.12.13.35.mov

MacOS: Chrome / Safari

MacOS: Desktop

…and LHN

melvin-bot · 2024-02-13T11:21:17Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-02-13T11:24:31Z

@mollfpr
Hello )
PR is ready )

mollfpr · 2024-02-13T12:14:38Z

    onDismissError = () => {},
    rightHandSideComponent,
    keyForList,
+    shouldUseOnySubscriptAvatar = true,


Typo

Suggested change

shouldUseOnySubscriptAvatar = true,

shouldUseOnlySubscriptAvatar = true,

Could you give the case for this specific prop? I see that we pass false on the search page.

Just so as not to change the display logic on other places where we use UserListItem
I added this parameter so that we display SubscriptAvatar or MultipleAvatars only on the Search screen

mollfpr · 2024-02-13T12:26:52Z

-                    showTooltip={showTooltip}
-                />
+                <>
+                    {item.shouldShowSubscript ?? shouldUseOnySubscriptAvatar ? (


Could you explain more about this condition and give the example for the case?

Oh )
Sorry )
It should be like this
shouldUseOnySubscriptAvatar || item.shouldShowSubscript
By default shouldUseOnySubscriptAvatar is true this means that we will display only SubscriptAvatar as before
But for Search this value is false, so depending on item.shouldShowSubscript we will show SubscriptAvatar or MultipleAvatars as on LHN or Header chat

Can we not using shouldUseOnySubscriptAvatar? I don't see any scenario for the props to exist.

I think we can)
I'm just afraid
So that this does not cause regression)

I understand that. Let's see how it goes, and I'll help test it thoroughly.

No problem )
Give me few minutes )

Actually, I found only one place where we use UserListItem except Search
When we create request money and select participants
And everything looks good )

…search-list-and-lhn

mollfpr · 2024-02-15T17:17:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

36403.Android.mp4

Android: mWeb Chrome

36403.mWeb-Chrome.mp4

iOS: Native

36403.iOS.mp4

iOS: mWeb Safari

36403.mWeb-Safari.mp4

MacOS: Chrome / Safari

36403.Web.mp4

MacOS: Desktop

36403.Desktop.mp4

OSBotify · 2024-02-19T09:12:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:48:22Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:54:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bug with Group chat stacked avatars are different in Search list …

4a1a2ab

…and LHN

ZhenjaHorbach requested a review from a team as a code owner February 13, 2024 11:21

melvin-bot Bot requested review from mollfpr and removed request for a team February 13, 2024 11:21

Fix prettier issues

4fd550f

mollfpr reviewed Feb 13, 2024

View reviewed changes

ZhenjaHorbach added 4 commits February 13, 2024 13:39

Update condition for UserListItem icons

a2663b8

Remove shouldUseOnySubscriptAvatar

34309fe

Merge branch 'main' into group-chat-stacked-avatars-are-different-in-…

1fdc1a9

…search-list-and-lhn

Merge branch 'main' into group-chat-stacked-avatars-are-different-in-…

b2f6e7e

…search-list-and-lhn

mollfpr approved these changes Feb 15, 2024

View reviewed changes

melvin-bot Bot requested a review from MariaHCD February 15, 2024 17:23

MariaHCD approved these changes Feb 19, 2024

View reviewed changes

MariaHCD merged commit 1caa218 into Expensify:main Feb 19, 2024

github-actions Bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

mkhutornyi mentioned this pull request Feb 22, 2024

[HOLD #37199][$500] Remove members out of a workspace are not crossed out in offline mode #37109

Closed

6 tasks

	shouldUseOnySubscriptAvatar = true,
	shouldUseOnlySubscriptAvatar = true,

Uh oh!

Conversation

ZhenjaHorbach commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 13, 2024

Uh oh!

ZhenjaHorbach commented Feb 13, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZhenjaHorbach commented Feb 13, 2024 •

edited

Loading

ZhenjaHorbach Feb 13, 2024 •

edited

Loading

mollfpr commented Feb 15, 2024 •

edited

Loading