Create create-a-workspace-for-yourself.md#36163
Merged
Merged
Conversation
New help article for getting started guides
melvin-bot
Bot
requested review from
Beamanator
and removed request for
a team
|
@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
rushatgabhane
suggested changes
Feb 8, 2024
rushatgabhane
left a comment
rushatgabhane
left a comment
Member
There was a problem hiding this comment.
Few changes to fix formatting.
@ren-jones please change the file name to uppercase. Create-a-Workspace...
Because we use file name as the title.
| <ol type="a"> | ||
| <li>Open the mobile app and tap the camera icon in the bottom right corner.</li> | ||
| <li>Upload or take a photo of your receipt.</li> | ||
| <ul> |
Member
There was a problem hiding this comment.
we forgot to close this ul tag.
| <ul> | ||
| <li>Upload a photo: Click the photo icon in the left corner and select the image from your device.</li> | ||
| <li>Take a photo: Click the camera icon in the right corner to select the mode, make sure all of the transaction details are clearly visible, and then take the photo.</li> | ||
| <ul> |
Member
There was a problem hiding this comment.
same here. we should close this tag
Member
|
@ren-jones does this look ok to you? 
|
…pace-for-yourself.md Add closing } Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
Added missing closing tags
Contributor
|
Is there an issue for this? If so, please link in the OP! 🙏 |
…ourself.md Capitalized first word in title (For article titles, we're using sentence case - only the first word will be capitalized). Folders will use title case.
ren-jones
commented
Feb 9, 2024
ren-jones
left a comment
ren-jones
left a comment
Contributor
Author
There was a problem hiding this comment.
@rushatgabhane I believe I made all the corrections—thank you for your help!
Contributor
|
@Beamanator - added the tracking issue for "Improve Helpdot" to the OP - https://github.com/Expensify/Expensify/issues/337748 |
rushatgabhane
approved these changes
Feb 15, 2024
rushatgabhane
left a comment
rushatgabhane
left a comment
Member
There was a problem hiding this comment.
LGTM!
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #36588. |
Member
|
@Beamanator all yours |
Beamanator
reviewed
Feb 15, 2024
| title: Create a workspace for yourself | ||
| description: Get started with Expensify by creating an individual workspace for yourself | ||
| --- | ||
| <div id="expensify-classic" markdown="1"> |
Contributor
There was a problem hiding this comment.
Hmm what does this do? I don't see it anywhere else in our codebase?
Member
There was a problem hiding this comment.
@Beamanator great question!
Let me introduce you to platform switcher. You can toggle between olddot and newdot on the same page.
Screen.Recording.2024-02-16.at.09.21.23.mov
Member
There was a problem hiding this comment.
it can be abstracted to a jekyll command but i didn't do it yet to ship faster
Contributor
There was a problem hiding this comment.
oooh niftay!!! thanks for showing me that!!
Beamanator
approved these changes
Feb 15, 2024
Beamanator
left a comment
Beamanator
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but curious what that div is for 😅 any explanation @ren-jones @rushatgabhane ?
|
@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
I believe that deploy check always fails on forks |
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.43-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New help article for getting started guides - https://github.com/Expensify/Expensify/issues/337748
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined