-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Update Account Settings] Preferences, About, Security #35672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0f80d69
d836214
bd0d930
beebe04
1b2d2a7
9571905
4397fc5
3124444
3a8cd2d
330fb72
9f2b8f8
1d0e5a9
c74a873
715eacd
426632c
b6d1789
3601b3f
3e44c6f
3769321
028d355
eab2a13
479203f
56fd657
42d1233
782d2ca
8941626
31e513d
a33f3a8
5f13923
1743d97
0375e27
0993456
a9ef0cc
f2ca240
5e5bce0
4f30355
404b3c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| import colors from '@styles/theme/colors'; | ||
| import variables from '@styles/variables'; | ||
| import type DotLottieAnimation from './types'; | ||
|
|
||
| const DotLottieAnimations: Record<string, DotLottieAnimation> = { | ||
| const DotLottieAnimations = { | ||
| ExpensifyLounge: { | ||
| file: require('@assets/animations/ExpensifyLounge.lottie'), | ||
| w: 1920, | ||
|
|
@@ -26,6 +27,7 @@ const DotLottieAnimations: Record<string, DotLottieAnimation> = { | |
| file: require('@assets/animations/PreferencesDJ.lottie'), | ||
| w: 375, | ||
| h: 240, | ||
| backgroundColor: colors.blue500, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes it hard to use same illustration with a different background. Why don't we just pass
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I theoretically couldn't use Currently, we didn't have any case where we changed the background color of illustration. If someone needs it, he can possibly do that by passing
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I move it anyway, and import
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not.a blocker. Let's keep it as is for now
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! If internal decides we want to change it, I will do it as a follow-up!
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tmight be nice to add this as a follow up but I would say once we will need this dynamic which we dont right now as far as I know |
||
| }, | ||
| ReviewingBankInfo: { | ||
| file: require('@assets/animations/ReviewingBankInfo.lottie'), | ||
|
|
@@ -36,6 +38,7 @@ const DotLottieAnimations: Record<string, DotLottieAnimation> = { | |
| file: require('@assets/animations/WorkspacePlanet.lottie'), | ||
| w: 375, | ||
| h: 240, | ||
| backgroundColor: colors.pink800, | ||
| }, | ||
| SaveTheWorld: { | ||
| file: require('@assets/animations/SaveTheWorld.lottie'), | ||
|
|
@@ -46,6 +49,7 @@ const DotLottieAnimations: Record<string, DotLottieAnimation> = { | |
| file: require('@assets/animations/Safe.lottie'), | ||
| w: 625, | ||
| h: 400, | ||
| backgroundColor: colors.ice500, | ||
| }, | ||
| Magician: { | ||
| file: require('@assets/animations/Magician.lottie'), | ||
|
|
@@ -61,7 +65,8 @@ const DotLottieAnimations: Record<string, DotLottieAnimation> = { | |
| file: require('@assets/animations/Coin.lottie'), | ||
| w: 375, | ||
| h: 240, | ||
| backgroundColor: colors.yellow600, | ||
| }, | ||
| }; | ||
| } satisfies Record<string, DotLottieAnimation>; | ||
|
|
||
| export default DotLottieAnimations; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| import type {LottieViewProps} from 'lottie-react-native'; | ||
| import type {ColorValue} from '@styles/utils/types'; | ||
|
|
||
| type DotLottieAnimation = { | ||
| file: LottieViewProps['source']; | ||
| w: number; | ||
| h: number; | ||
| backgroundColor?: ColorValue; | ||
| }; | ||
|
|
||
| export default DotLottieAnimation; |
Uh oh!
There was an error while loading. Please reload this page.