Fix: Pin & Delete request appear on Receipt image when quickly tap on receipt and 3-Dot menu by tienifr · Pull Request #34720 · Expensify/App

tienifr · 2024-01-18T11:37:43Z

Details

Fixed Issues

$ #33541
PROPOSAL: #33541 (comment)

Tests

Navigate to New dot app as Employee
Go to workspace chat> create Scan request
On detail page tap receipt and 3-Dot menu in a quick manner
Verify that the receipt is open and no 3-Dot menu is open

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Navigate to New dot app as Employee
Go to workspace chat> create Scan request
On detail page tap receipt and 3-Dot menu in a quick manner
Verify that the receipt is open and no 3-Dot menu is open

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-25.at.15.26.52.mov

Android: mWeb Chrome

Screen.Recording.2024-01-25.at.15.13.44.mov

iOS: Native

Screen.Recording.2024-01-25.at.15.26.00.mov

iOS: mWeb Safari

Screen.Recording.2024-01-18.at.17.45.00.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-18.at.17.42.58.mov

MacOS: Desktop

Screen.Recording.2024-01-18.at.18.27.42.mov

… receipt and 3-Dot menu

melvin-bot · 2024-01-18T11:37:55Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-01-24T06:42:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

pindeleteAndroidNative.mp4

Android: mWeb Chrome

pindeleteAndroidChrome.mp4

iOS: Native

pindeleteiOSNative.mp4

iOS: mWeb Safari

pindeleteiOSSafari.mp4

MacOS: Chrome / Safari

pindeleteChrome.mp4

MacOS: Desktop

pindeleteDesktop.mp4

c3024 · 2024-01-24T06:48:24Z

@tienifr please attach videos of other platforms also.

tienifr · 2024-01-25T08:30:20Z

@c3024 done

c3024 · 2024-01-25T11:22:36Z

 */
-function willAlertModalBecomeVisible(isVisible: boolean) {
-    Onyx.merge(ONYXKEYS.MODAL, {willAlertModalBecomeVisible: isVisible});
+function willAlertModalBecomeVisible(isVisible: boolean, isPopover = false) {


Please add comment for why this param isPopover is required.

c3024 · 2024-01-25T11:24:21Z

    const styles = useThemeStyles();
    const [isPopupMenuVisible, setPopupMenuVisible] = useState(false);
    const buttonRef = useRef(null);
    const {translate} = useLocalize();


NIT: In here

const isBehindModal = modal?.willAlertModalBecomeVisible && !modal?.isPopover && !shouldOverlay;

I think if modal?.willAlertModalBecomeVisible is true, the next ? after modal is not necessary.

although we have default value {} for modal but its type is modal: OnyxEntry, not modal?: Modal, and OnyxEntry can be null -> ? is necessary here

I meant at line 86

const isBehindModal = modal?.willAlertModalBecomeVisible && !modal?.isPopover && !shouldOverlay;

it will reach to checking !modal?.isPopover only when modal?.willAlertModalBecomeVisible is true which guarantees that modal is not null so in the modal?.isPopover being evaluated only after modal?.willAlertModalBecomeVisible is true, modal check for null in modal?.isPopover does not appear to be required.

It is a non issue and a very minor nitpick anyway 😁 . Need not be changed.

c3024 · 2024-01-25T17:01:49Z

Regression here - the three dot menu is disappearing

Screen.Recording.2024-01-25.at.10.30.47.PM.mov

c3024 · 2024-01-25T17:04:57Z

Please verify the three dot menus in all pages and all components where the field willAlertModalBecomeVisible is used to ensure that this PR does not introduce any regressions like these. @tienifr

c3024 · 2024-01-25T17:07:30Z

Please take extra care for these steps in the checklist

I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

c3024

Please fix the three dot menu regression attached in the video in the other comment.

puneetlath · 2024-01-26T16:52:52Z

It doesn't look like this is ready for me to review yet. Please ping me when it is!

tienifr · 2024-01-29T09:21:48Z

Sorry for missing checking three dot on native. I fixed

Screen.Recording.2024-01-29.at.16.17.37.mov

c3024 · 2024-02-02T11:36:34Z

Testing well. However I am seeing a couple of warnings one on web and another on Android Native.

Web - menuItemPropTypes.js:115 Warning: Invalid argument supplied to oneOfType, expected an instance of array.

Android - FlashList's rendered size is not usable. Either the height or width is too small (<2px). Please make sure that the parent view of the list has a valid size. FlashList will match the size of the parent.

I don't think they are related to these changes.

Nevertheless could you merge main so that we can just double check again?

@tienifr

tienifr · 2024-02-05T11:01:42Z

@c3024 After merge main. I don't face with these above warnings ^. I believe they're not related to this PR because we didn't change anythings about MenuItem or FlashList

c3024

LGTM

puneetlath · 2024-02-05T21:23:50Z

                onLayout={onLayout}
                animationIn={animationIn}
                animationOut={animationOut}
+                isPopover


Why do we need this new prop? Isn't it redundant with the type prop?

Yah, I think we can remove it and use type. Thank you

puneetlath · 2024-02-08T21:12:14Z

@tienifr bump on my question.

tienifr · 2024-02-15T09:50:06Z

@puneetlath Thanks for your suggestion. We can lean on type instead of creating the new prop. I tested on all platforms and worked well. Can you help review again @c3024?

c3024 · 2024-02-18T06:41:22Z

Tested again

Screenshots/Videos

Android: Native

pinDeleteAndroidNew.mp4

Android: mWeb Chrome

pinDeleteAndroidChromeNew.mp4

iOS: Native

pinDeleteiOSNew.mp4

iOS: mWeb Safari

pinDeleteiOSSafariNew.mp4

MacOS: Chrome / Safari

pinDeleteChromeNew.mp4

MacOS: Desktop

pinDeleteDesktopNew.mp4

c3024

Tests well.

OSBotify · 2024-02-19T17:26:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:46:46Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:52:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Pin & Delete request appear on Receipt image when quickly tap on…

00e958e

… receipt and 3-Dot menu

tienifr marked this pull request as ready for review January 18, 2024 11:37

tienifr requested a review from a team as a code owner January 18, 2024 11:37

melvin-bot Bot requested review from c3024 and removed request for a team January 18, 2024 11:37

tienifr added 2 commits January 24, 2024 16:42

resolve conflict

ed4bd8e

resolve conflict

b9dcb28

c3024 reviewed Jan 25, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

melvin-bot Bot requested a review from puneetlath January 25, 2024 11:25

c3024 suggested changes Jan 25, 2024

View reviewed changes

tienifr added 2 commits January 29, 2024 11:25

Merge branch 'main' into fix/33541

7013594

fix three dot

dde9079

add comment

a1ebabc

Merge branch 'main' into fix/33541

63edee6

c3024 approved these changes Feb 5, 2024

View reviewed changes

puneetlath reviewed Feb 5, 2024

View reviewed changes

Christinadobrzyn mentioned this pull request Feb 7, 2024

[Payment due 03-04][$500] Menu - Pin & Delete request appear on Receipt image when quickly tap on receipt and 3-Dot menu #33541

Closed

6 tasks

revove isPopover

74c06a0

puneetlath requested a review from c3024 February 15, 2024 14:19

c3024 approved these changes Feb 18, 2024

View reviewed changes

melvin-bot Bot requested a review from puneetlath February 18, 2024 07:32

puneetlath approved these changes Feb 19, 2024

View reviewed changes

puneetlath merged commit f91b2a7 into Expensify:main Feb 19, 2024

github-actions Bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

Uh oh!

Conversation

tienifr commented Jan 18, 2024 • edited by puneetlath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 18, 2024

Uh oh!

c3024 commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 commented Jan 24, 2024

Uh oh!

tienifr commented Jan 25, 2024

Uh oh!

c3024 Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

c3024 Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

c3024 Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

c3024 commented Jan 25, 2024

Uh oh!

c3024 commented Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 commented Jan 25, 2024

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Jan 26, 2024

Uh oh!

tienifr commented Jan 29, 2024

Uh oh!

c3024 commented Feb 2, 2024

Uh oh!

tienifr commented Feb 5, 2024

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Feb 8, 2024

Uh oh!

tienifr commented Feb 15, 2024

Uh oh!

c3024 commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 19, 2024

tienifr commented Jan 18, 2024 •

edited by puneetlath

Loading

c3024 commented Jan 24, 2024 •

edited

Loading

c3024 Jan 25, 2024 •

edited

Loading

c3024 Jan 31, 2024 •

edited

Loading

c3024 commented Jan 25, 2024 •

edited

Loading

c3024 commented Feb 18, 2024 •

edited

Loading