[TS migration] Migrate 'ValuePicker' component to TypeScript by filip-solecki · Pull Request #34654 · Expensify/App

filip-solecki · 2024-01-17T16:02:22Z

Details

Fixed Issues

$ #31965
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Log in to app
Click "+" icon
Select "Start Chat"
Pick "Room" from top bar
Try to change eg. visibility field
Check if everything is ok

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

VickyStash

Please add test steps/recordings

VickyStash

LGTM

melvin-bot · 2024-02-02T08:27:04Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan

please resolve conflict

filip-solecki · 2024-02-07T08:55:48Z

@situchan - conflicts resolved

situchan · 2024-02-08T22:09:29Z

Thanks. I will complete review asap

filip-solecki · 2024-02-09T20:46:37Z

@situchan kind bump :)

situchan · 2024-02-13T14:31:49Z

@filip-solecki conflicts again

filip-solecki · 2024-02-15T09:00:16Z

@situchan - please re-review

situchan · 2024-02-15T22:36:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

filip-solecki · 2024-02-19T11:31:35Z

@situchan please finish review asap - there are conflicts really often that I have to resolve

situchan · 2024-02-19T11:33:43Z

on this right now

situchan

If one of this PR or #34742 is merged, another one should be synced with main

situchan · 2024-02-19T14:17:10Z

                _.filter(PolicyUtils.getActivePolicies(props.policies), (policy) => policy.type !== CONST.POLICY.TYPE.PERSONAL),
                (policy) => ({
                    label: policy.name,
-                    key: policy.id,


Any reason for this removal?

Yes, it is not used - keyForList is taking value from value prop so there is no need to pass the same value twice

situchan

melvin-bot · 2024-02-19T14:58:29Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31965 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2024-02-19T16:12:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:46:43Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:52:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ValuePicker migration

bc0a36a

blazejkustra approved these changes Jan 17, 2024

View reviewed changes

Comment thread src/components/ValuePicker/types.ts Outdated

Add optional mark to props

8045ca6

VickyStash reviewed Jan 26, 2024

View reviewed changes

filip-solecki added 2 commits January 26, 2024 12:42

Merge branch 'main' into ts/ValuePicker

9344a97

review fixes

b64181c

VickyStash reviewed Jan 26, 2024

View reviewed changes

Comment thread src/components/ValuePicker/types.ts Outdated

filip-solecki added 3 commits January 26, 2024 13:51

Change onInputChange function type

9633be5

Merge branch 'main' into ts/ValuePicker

1da70d4

Fix typing for ValuePicker

1e8cff3

VickyStash approved these changes Feb 1, 2024

View reviewed changes

Merge branch 'main' into ts/ValuePicker

e82fd09

filip-solecki marked this pull request as ready for review February 2, 2024 08:27

filip-solecki requested a review from a team as a code owner February 2, 2024 08:27

melvin-bot Bot removed the request for review from a team February 2, 2024 08:27

melvin-bot Bot requested a review from situchan February 2, 2024 08:27

situchan reviewed Feb 5, 2024

View reviewed changes

Merge branch 'main' into ts/ValuePicker

ca6c2b2

filip-solecki added 2 commits February 7, 2024 12:34

Merge branch 'main' into ts/ValuePicker

93ea736

Merge branch 'main' into ts/ValuePicker

16e42bc

situchan reviewed Feb 13, 2024

View reviewed changes

Comment thread src/components/ValuePicker/ValueSelectorModal.tsx Outdated

situchan reviewed Feb 13, 2024

View reviewed changes

Comment thread src/components/ValuePicker/index.tsx Outdated

filip-solecki added 3 commits February 15, 2024 08:52

Merge branch 'main' into ts/ValuePicker

db3ac2a

C+ review fixes

cfb47f6

Fix failing typescript

19c5c0d

Merge branch 'main' into ts/ValuePicker

ec73a6c

Fix typescript

3e3d5b0

situchan mentioned this pull request Feb 19, 2024

[TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #34742

Merged

48 tasks

situchan reviewed Feb 19, 2024

View reviewed changes

situchan approved these changes Feb 19, 2024

View reviewed changes

melvin-bot Bot requested a review from Gonals February 19, 2024 14:58

Gonals approved these changes Feb 19, 2024

View reviewed changes

Gonals merged commit 8bb5b9d into Expensify:main Feb 19, 2024

github-actions Bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

sonialiap mentioned this pull request Feb 26, 2024

[TS migration] Migrate 'ValuePicker' component to TypeScript #31965

Closed

Uh oh!

Conversation

filip-solecki commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

VickyStash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 2, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

filip-solecki commented Feb 7, 2024

Uh oh!

situchan commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filip-solecki commented Feb 9, 2024

Uh oh!

situchan commented Feb 13, 2024

Uh oh!

Uh oh!

Uh oh!

filip-solecki commented Feb 15, 2024

Uh oh!

situchan commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

filip-solecki commented Feb 19, 2024

Uh oh!

situchan commented Feb 19, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

situchan Feb 19, 2024

Choose a reason for hiding this comment

Uh oh!

filip-solecki Feb 19, 2024

Choose a reason for hiding this comment

Uh oh!

filip-solecki Feb 19, 2024

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

filip-solecki commented Jan 17, 2024 •

edited

Loading

situchan commented Feb 8, 2024 •

edited

Loading

situchan commented Feb 15, 2024 •

edited

Loading