Skip to content

[CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator"#34552

Merged
mountiny merged 1 commit into
mainfrom
revert-33426-add-the-isInRHP-prop-to-the-ModalStackNavigator
Jan 16, 2024
Merged

[CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator"#34552
mountiny merged 1 commit into
mainfrom
revert-33426-add-the-isInRHP-prop-to-the-ModalStackNavigator

Conversation

@marcochavezf

@marcochavezf marcochavezf commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

Reverts #33426

Fixing #34532

@marcochavezf marcochavezf marked this pull request as ready for review January 16, 2024 04:43
@marcochavezf marcochavezf requested a review from a team as a code owner January 16, 2024 04:43
@melvin-bot melvin-bot Bot requested review from yuwenmemon and removed request for a team January 16, 2024 04:44
@melvin-bot

melvin-bot Bot commented Jan 16, 2024

Copy link
Copy Markdown

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Add layout=narrow initial param to the ModalStackNavigator" [CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator" Jan 16, 2024
@mountiny

Copy link
Copy Markdown
Contributor

Straight revert, no need for checklists

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 925dc3d into main Jan 16, 2024
@mountiny mountiny deleted the revert-33426-add-the-isInRHP-prop-to-the-ModalStackNavigator branch January 16, 2024 11:37
@melvin-bot melvin-bot Bot added the Emergency label Jan 16, 2024
@melvin-bot

melvin-bot Bot commented Jan 16, 2024

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor

Straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jan 16, 2024
…-prop-to-the-ModalStackNavigator

[CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator"

(cherry picked from commit 925dc3d)
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.25-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.25-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants