-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[TS migration] Migrate AnchorForAttachmentsOnly component #33429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gonals
merged 10 commits into
Expensify:main
from
ruben-rebelo:ts-migration/AnchorForAttachmentsOnly-component
Jan 12, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9ea9f18
[TS migration] Migrate AnchorForAttachmentsOnly component
ruben-rebelo 0d64fc9
[TS migration] AnchorForAttachmentsOnly - Code improvements
ruben-rebelo a97ff6d
[TS migration] AnchorForAttachmentsOnly - Minor comment changes
ruben-rebelo f9f4469
[TS migration] AnchorForAttachmentsOnly - Code improvements
ruben-rebelo a62150d
[ts migration] Removed unnecessary variable creation
ruben-rebelo 8e199e5
[TS migration] Prettier code changes
ruben-rebelo 27dd6eb
[TS migration] Added type on import of types
ruben-rebelo b2b3b84
Merge branch 'main' into ts-migration/AnchorForAttachmentsOnly-component
ruben-rebelo c8a0cc8
[TS migration] Lint issue fix
ruben-rebelo 8c5c752
[Ts migration] Prettified the code
ruben-rebelo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 0 additions & 21 deletions
21
src/components/AnchorForAttachmentsOnly/anchorForAttachmentsOnlyPropTypes.js
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import type {StyleProp, ViewStyle} from 'react-native'; | ||
|
|
||
| type AnchorForAttachmentsOnlyProps = { | ||
| /** The URL of the attachment */ | ||
| source?: string; | ||
|
|
||
| /** Filename for attachments. */ | ||
| displayName?: string; | ||
|
|
||
| /** Any additional styles to apply */ | ||
| style?: StyleProp<ViewStyle>; | ||
| }; | ||
|
|
||
| export default AnchorForAttachmentsOnlyProps; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.