[TS migration] Migrate 'LHNOptionsList' component to TypeScript by kubabutkiewicz · Pull Request #33108 · Expensify/App

kubabutkiewicz · 2023-12-14T18:32:12Z

Details

Fixed Issues

$ #25149

Tests

Reports should be rendered in LHN
Select one of the reports from LHN
Report should be opened
Click on unread report
Report should become read

Verify that no errors appear in the JS console

Offline tests

QA Steps

Reports should be rendered in LHN
Select one of the reports from LHN
Report should be opened
Click on unread report
Report should become read

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…s-migration/LHNOptionsList/component

…essableWithSecondaryInteraction, and SidebarUtils

VickyStash · 2023-12-20T17:24:46Z

                            // Ensure that we blur the composer when opening context menu, so that only one component is focused at a time
                            if (DomUtils.getActiveElement()) {
-                                DomUtils.getActiveElement().blur();
+                                (DomUtils.getActiveElement() as HTMLElement | TextInput)?.blur();


Is it possible to update DomUtils.getActiveElement() return type to escape assertion?

I think its not possible (or I dont know how to do it)

const getActiveElement: GetActiveElement = () => document.activeElement;

and activeElement is returning Element | null

…s-migration/LHNOptionsList/component

Fix type error in SidebarUtils

VickyStash · 2024-01-04T09:50:32Z

-    isFocused,
-    fullReport,
+    isFocused = false,
+    fullReport = null,


Do we need null default values?

I think its not needed , will test without that

blazejkustra

One minor comment, LGTM!

blazejkustra · 2024-01-12T08:56:36Z

+    preferredLocale = CONST.LOCALES.DEFAULT,
    comment,
-    policy,
+    policy = null,


No need for null default values:

Suggested change

policy = null,

policy,

…s-migration/LHNOptionsList/component

melvin-bot · 2024-01-15T16:33:22Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…s-migration/LHNOptionsList/component

rushatgabhane · 2024-01-17T05:56:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-17.at.12.25.37.mov

Android: mWeb Chrome

Screen.Recording.2024-01-17.at.12.24.27.mov

iOS: Native

Screen.Recording.2024-01-17.at.12.25.52.mov

iOS: mWeb Safari

Screen.Recording.2024-01-17.at.12.24.02.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-17.at.12.22.09.mov

MacOS: Desktop

rushatgabhane

LGTM

melvin-bot · 2024-01-17T07:03:46Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25149 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…s-migration/LHNOptionsList/component

kubabutkiewicz · 2024-01-22T10:06:46Z

Hi @mountiny ! can you assign Expensify engineer to this PR? I think the automation didnt work.
Thanks!

mountiny · 2024-01-22T19:46:31Z

@kubabutkiewicz merge conflicts

…s-migration/LHNOptionsList/component

OSBotify · 2024-01-23T14:45:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-25T08:50:52Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.31-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kubabutkiewicz added 19 commits November 20, 2023 17:17

ref: started migrating LHNOptionsList module

3e5c8b0

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

545fed2

…s-migration/LHNOptionsList/component

ref: working on migration to typescript

2418cd1

ref: contuniue migration

2e6f52a

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

5061170

…s-migration/LHNOptionsList/component

fix: add few type fixes

6c72cd9

fix: types

2bf40c8

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

cfeac24

…s-migration/LHNOptionsList/component

fix: few type issues

e205c9d

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

6e9072a

…s-migration/LHNOptionsList/component

fix: conflicts

c9378b4

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

7850de2

…s-migration/LHNOptionsList/component

fix: types

3025cde

fix: removed unused prop

e436a6c

fix: linter

01f2aa7

chore: added todos

ab774c9

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

72b4b67

…s-migration/LHNOptionsList/component

fix: adjust type

91e7c92

Refactor imports and types in LHNOptionsList, OfflineWithFeedback, Pr…

18352a7

…essableWithSecondaryInteraction, and SidebarUtils

VickyStash reviewed Dec 20, 2023

View reviewed changes

kubabutkiewicz added 2 commits December 21, 2023 10:02

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

3606125

…s-migration/LHNOptionsList/component

Refactor OptionRowLHN component and update types

097a03c

Fix type error in SidebarUtils

rezkiy37 reviewed Dec 21, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/LHNOptionsList.tsx Outdated

rezkiy37 reviewed Dec 21, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/LHNOptionsList.tsx Outdated

rezkiy37 reviewed Dec 21, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/OptionRowLHNData.tsx Outdated

kubabutkiewicz added 4 commits December 21, 2023 13:52

Update OptionData types and fix SubscriptAvatar props

8b5fe4b

fix: adjust code based on the comments

882d8d9

sync with main

9761483

fix: resolve comment

7d1c7f7

VickyStash reviewed Jan 4, 2024

View reviewed changes

blazejkustra approved these changes Jan 12, 2024

View reviewed changes

kubabutkiewicz added 3 commits January 15, 2024 13:36

fix: resolve comment

286adbd

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

6be3570

…s-migration/LHNOptionsList/component

fix: removed memo

950c62f

kubabutkiewicz marked this pull request as ready for review January 15, 2024 16:33

kubabutkiewicz requested a review from a team as a code owner January 15, 2024 16:33

melvin-bot Bot requested review from rushatgabhane and removed request for a team January 15, 2024 16:33

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

c79daa4

…s-migration/LHNOptionsList/component

rushatgabhane approved these changes Jan 17, 2024

View reviewed changes

kubabutkiewicz added 3 commits January 18, 2024 18:13

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

5e3a9e8

…s-migration/LHNOptionsList/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

3a007c9

…s-migration/LHNOptionsList/component

fix: typecheck

c82a4a7

mountiny requested a review from Gonals January 22, 2024 19:46

mountiny assigned kubabutkiewicz Jan 22, 2024

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

87f9b94

…s-migration/LHNOptionsList/component

Gonals approved these changes Jan 23, 2024

View reviewed changes

Gonals merged commit 5edf172 into Expensify:main Jan 23, 2024

github-actions Bot mentioned this pull request Jan 24, 2024

Deploy Checklist: New Expensify 2024-01-24 #35037

Closed

48 tasks

MonilBhavsar mentioned this pull request Jan 24, 2024

[CP Staging] Fix reggression after LHNOptionsList TS migration #35044

Merged

50 tasks

melvin-bot Bot mentioned this pull request Jan 25, 2024

[HOLD for payment 2024-02-01] [TS migration] Migrate 'LHNOptionsList' component to TypeScript #25149

Closed

c3024 mentioned this pull request Jun 20, 2024

[HOLD for payment 2024-06-20] [$250] LHN - Most recent priority mode displayed as #focus and the other way around on secondary device #43315

Closed

6 tasks

Uh oh!

Conversation

kubabutkiewicz commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VickyStash Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Jan 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra Jan 12, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 15, 2024

Uh oh!

rushatgabhane commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 17, 2024

Uh oh!

kubabutkiewicz commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jan 22, 2024

Uh oh!

OSBotify commented Jan 23, 2024

Uh oh!

OSBotify commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kubabutkiewicz commented Dec 14, 2023 •

edited

Loading

rushatgabhane commented Jan 17, 2024 •

edited

Loading

kubabutkiewicz commented Jan 22, 2024 •

edited

Loading