Skip to content

Fix - LoginScreen email keyboard type and autoCorrect#3288

Merged
HorusGoul merged 1 commit into
Expensify:mainfrom
dharammachra:Dharam-Emailkeyboard-Autocorrect
Jun 2, 2021
Merged

Fix - LoginScreen email keyboard type and autoCorrect#3288
HorusGoul merged 1 commit into
Expensify:mainfrom
dharammachra:Dharam-Emailkeyboard-Autocorrect

Conversation

@dharammachra

Copy link
Copy Markdown
Contributor

@HorusGoul

I have read the CLA Document and I hereby sign the CLA

Details

We are using the default react native text input props autoCompleteType={false} and keyboardType={email-address}.

Fixed Issues

Fixes #1524

Tests

Go to the login screen and click on the enter your phone or email field, email type keyboard will open and when user type the email auto correct is disabled.

QA Steps

1. Run the application
2. Login screen show
3. Click on the enter your phone or email field
4. Email type keyboard will show and auto correct is disabled

Tested On

  • [ ✅] Web
  • [ ✅] Mobile Web
  • [ ✅] Desktop
  • [✅ ] iOS
  • [✅] Android

Screenshots

Web

Web-Screen

Mobile Web

Desktop

Desk-Top

iOS

iOS

Android

Android

@dharammachra dharammachra requested a review from a team as a code owner June 2, 2021 10:57
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team June 2, 2021 10:58
@dharammachra

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@HorusGoul HorusGoul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Login screen use email keyboard type and disable auto complete

2 participants