Remove the hasOutstandingIOU key by rezkiy37 · Pull Request #32653 · Expensify/App

rezkiy37 · 2023-12-07T12:28:59Z

Details

We have been using the hasOutstandingIOU key to indicate that there is some active (ie processing or open) report linked to chat report or as a property on the money request report to indicate the same.

In case of IOU/expense report its however redundant as we know the state and status and total so we can derive if the report is active

In case of the parent chat reports (DM in case of IOU and workspace chat in case of expense report) we now have the hasChildOutstandingRequest property which indicates there is action required from the user.

The hasOutstandingIOU property now became redundant so we can remove it.

Fixed Issues

$ #32565
$ #32281
PROPOSAL: N/A

Tests

Precondition:

User is an employee of a Collect workspace

Log in to ND as the employee
Go to the workspace chat > "+" > Request money.
Create a manual request.
Click on the expense preview.
Click "Submit".
Take note of the content on the header.
Verify that the content contains "owes", not "paid".

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.Offline.mp4

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…ture/32187-referral-page-redesign

…/32565-deprecate-hasOutstandingIOU-key

melvin-bot · 2023-12-08T14:31:04Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rezkiy37 · 2023-12-08T16:36:48Z

Sorry, this one is a bit early for reviewing 😅

mountiny · 2023-12-11T11:37:57Z

@rezkiy37 Lets get this one ready for a review today if possible, thanks!

rezkiy37 · 2023-12-11T11:38:46Z

Yes, will be 👍

…/32565-deprecate-hasOutstandingIOU-key

rezkiy37 · 2023-12-11T12:02:18Z

@mountiny, I've removed hasOutstandingIOU completely. Just tested, looks like no errors/bugs found.

cc @cubuspl42

jakub-trzebiatowski · 2023-12-11T13:09:32Z

I've removed hasOutstandingIOU completely.

I think the title of this PR should be updated to catch up with this change. It will help with future navigation across our network of issues & PRs.

mountiny · 2023-12-11T13:32:56Z

Done

jakub-trzebiatowski · 2023-12-11T13:42:24Z

I meant that "deprecating" is like marking something as not recommended anymore, but keeping some usages. Did I understand correctly that we completely removed all uses of this property instead?

So this can be summed up as "Remove..." or "Nuke...", if I understood the change correctly

jakub-trzebiatowski · 2023-12-11T13:49:51Z

    }

-    if (!!report?.hasOutstandingIOU || isDraftExpenseReport(report) || moneyRequestTotal === 0) {
+    if ((report?.stateNum === CONST.REPORT.STATE_NUM.PROCESSING && report?.statusNum === CONST.REPORT.STATUS.SUBMITTED) || isDraftExpenseReport(report) || moneyRequestTotal === 0) {


I understand that this is the essential line, right?

Good that you updated the tests to reflect these assumptions here 👍

Yeah, @rezkiy37 could you add ReportUtils method which will be called: isProcessingReport which will do this state/ status check? thanks

Done - 9939213.

jakub-trzebiatowski · 2023-12-11T14:06:07Z

The code looks good, I'll get to testing

jakub-trzebiatowski · 2023-12-11T15:28:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

remove-hasOutstandingIOU-web.mp4

Mobile Web - Chrome

remove-hasOutstandingIOU-android-web-compressed.mp4

Mobile Web - Safari

remove-hasOutstandingIOU-ios-web.mp4

Desktop

iOS

remove-hasOutstandingIOU-ios.mp4

Android

remove-hasOutstandingIOU-android-compressed.mp4

mountiny

Thanks everyone

OSBotify · 2023-12-11T23:42:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-13T11:30:31Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:51:14Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T12:18:48Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T15:25:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rezkiy37 added 22 commits December 1, 2023 17:06

redesign page

e76adc4

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

6963583

…ture/32187-referral-page-redesign

remove body2

f969c88

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

1207fd8

…ture/32187-referral-page-redesign

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

4d91e45

…ture/32187-referral-page-redesign

update strings

8baed2d

rename key

c378ca3

update es strings

588b8a5

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

908885f

…ture/32187-referral-page-redesign

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

b647eca

…/32565-deprecate-hasOutstandingIOU-key

remove hasOutstandingIOU from MoneyRequestAction

b2aae83

remove hasOutstandingIOU from updateIOUOwnerAndTotal

f867e8b

remove hasOutstandingIOU from createOption

eeab94c

remove hasOutstandingIOU from hasNonReimbursableTransactions

066b288

remove hasOutstandingIOU from getMoneyRequestSpendBreakdown

506f306

remove hasOutstandingIOU from getMoneyRequestReportName

c80a014

remove hasOutstandingIOU from getOptionData

061d10e

remove hasOutstandingIOU from MoneyRequestAction

57e5fa4

revert changes

1148659

fix tests

5cba622

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

bef52ad

…/32565-deprecate-hasOutstandingIOU-key

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

fe544e2

…/32565-deprecate-hasOutstandingIOU-key

rezkiy37 marked this pull request as ready for review December 8, 2023 14:30

rezkiy37 requested a review from a team as a code owner December 8, 2023 14:30

melvin-bot Bot requested review from jakub-trzebiatowski and removed request for a team December 8, 2023 14:31

rezkiy37 marked this pull request as draft December 8, 2023 15:00

rezkiy37 added 3 commits December 11, 2023 12:39

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

e2481b5

…/32565-deprecate-hasOutstandingIOU-key

remove hasOutstandingIOU from src

f8a8381

remove hasOutstandingIOU from tests

ad9d3c2

rezkiy37 marked this pull request as ready for review December 11, 2023 12:01

mountiny assigned rezkiy37 Dec 11, 2023

mountiny changed the title ~~Deprecate the hasOutstandingIOU key on reports~~ Deprecate the hasOutstandingIOU key Dec 11, 2023

jakub-trzebiatowski reviewed Dec 11, 2023

View reviewed changes

mountiny changed the title ~~Deprecate the hasOutstandingIOU key~~ Remove the hasOutstandingIOU key Dec 11, 2023

integrate isProcessingReport helper

9939213

jakub-trzebiatowski approved these changes Dec 11, 2023

View reviewed changes

melvin-bot Bot requested a review from mountiny December 11, 2023 15:29

mountiny approved these changes Dec 11, 2023

View reviewed changes

mountiny merged commit 86a2521 into Expensify:main Dec 11, 2023

shubham1206agra mentioned this pull request Dec 12, 2023

[HOLD for payment 2024-02-07] [$500] Expense - Green dot does not appear in LHN when the request is created in workspace chat #32924

Closed

6 tasks

github-actions Bot mentioned this pull request Dec 13, 2023

[$500] Deploy Checklist: New Expensify 2023-12-13 #32963

Closed

64 tasks

jakub-trzebiatowski mentioned this pull request Dec 14, 2023

[HOLD for payment 2024-01-25] [$500] [Wave 6: Workspace Chats] IOU - Chat with IOU shows "This is beginning" in LHN after login and no Pay elsewhere in IOU preview #32658

Closed

6 tasks

bernhardoj mentioned this pull request Dec 14, 2023

[HOLD for payment 2024-02-05] [$500] IOU - "Total will update when you're back online" is missing on IOU request with foreign currency #33073

Closed

6 tasks

rezkiy37 mentioned this pull request Jan 16, 2024

[TS migration] Migrate 'IOU.js' lib to TypeScript #34092

Merged

50 tasks

Uh oh!

Conversation

rezkiy37 commented Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 8, 2023

Uh oh!

rezkiy37 commented Dec 8, 2023

Uh oh!

mountiny commented Dec 11, 2023

Uh oh!

rezkiy37 commented Dec 11, 2023

Uh oh!

rezkiy37 commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Uh oh!

mountiny commented Dec 11, 2023

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakub-trzebiatowski Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

rezkiy37 Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Uh oh!

jakub-trzebiatowski commented Dec 11, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rezkiy37 commented Dec 7, 2023 •

edited

Loading

rezkiy37 commented Dec 11, 2023 •

edited

Loading

jakub-trzebiatowski commented Dec 11, 2023 •

edited

Loading

jakub-trzebiatowski Dec 11, 2023 •

edited

Loading