[Bug resolution] for [#31822: Conversation disappears from LHN when creating an IOU with a new user in offline mode] by talhajavedmukhtar · Pull Request #32633 · Expensify/App

talhajavedmukhtar · 2023-12-07T08:17:37Z

Details

Fixed Issues

$ #31822
PROPOSAL: #31822 (comment)

Tests

Log into HT Expensify Account
Turn WiFi off
Create one or more IOUs with unique users
Confirm that new conversations remain in the sidebar
Turn WiFi back on for ~2 seconds (just enough time to trigger the loading of reports, but not enough time for the reports to load fully - this is crucial to reproduce the bug, as explained in the proposal comment.)
Turn WiFi back off before reports load (can be kept track of using console.log on the isLoadingReportData variable)
Create one or more IOUs with unique users
Confirm that new conversations remain in the sidebar (I confirmed, by console.log’ging the isLoadingReportData variable, that new conversations remain in the sidebar even in the case isLoadingReportData is stuck as true)
Turn WiFi back on
Confirm that all new conversations remain in the sidebar even after the user is back online
Verify that no errors appear in the JS console

Offline tests

All required info already included in the Tests section; the problem explicitly involves the offline state.

QA Steps

Log into HT Expensify Account
Turn WiFi off
Create one or more IOUs with unique users
Confirm that new conversations remain in the sidebar
Turn WiFi back on for ~2 seconds
Turn WiFi back off
Create one or more IOUs with unique users
Confirm that new conversations remain in the sidebar
Turn WiFi back on
Confirm that all new conversations remain in the sidebar even after the user is back online
Repeat the above steps ~10 times to be perfectly sure the bug is gone. (The bug state is not always triggered).
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Recording

MacOS: Desktop

Recording

… with a new user in offline mode

melvin-bot · 2023-12-07T08:17:43Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-12-07T08:17:52Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

talhajavedmukhtar · 2023-12-07T08:23:34Z

I have read the CLA Document and I hereby sign the CLA

talhajavedmukhtar · 2023-12-07T08:23:47Z

recheck

narefyev91 · 2023-12-07T10:43:43Z

        }
        return reportIDsRef.current || [];
-    }, [allReportActions, betas, chatReports, policies, priorityMode, isLoading]);
+    }, [allReportActions, betas, chatReports, policies, priorityMode, isLoading, network]);


can we specify directly network.isOffline in deps and not the whole network object?

Yes, that is what I originally tested with. That also works perfectly.

I changed it to be the whole object instead because it visually looked neater, and I didn't find that the network object has any other attributes apart from isOffline that change quite frequently.

Would you like me to commit the version where network is replaced with network.isOffline?

Yup let's just have network.isOffline in deps - maybe who knows in the future it will be more items in network - and we will prevent already any regression from it

…edmukhtar/ExpensifyApp into resolvingOfflineModeBug

narefyev91 · 2023-12-07T15:40:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

android-web.mp4

Mobile Web - Safari

ios-web.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

narefyev91 · 2023-12-07T15:41:22Z

@talhajavedmukhtar can you please resolve merge conflicts?

narefyev91

LGTM! Just needs to resolve merge conflicts
🎀 👀 🎀 C+ reviewed

talhajavedmukhtar · 2023-12-07T16:24:56Z

@narefyev91 merge conflicts resolved.

arosiclair

Looks like you also need to run prettier/eslint

edit SidebarLinksData props Co-authored-by: Andrew Rosiclair <arosiclair@gmail.com>

talhajavedmukhtar · 2023-12-08T04:04:34Z

@arosiclair ran the file through eslint and fixed the problems. No linting errors now.

arosiclair

Need to run prettier too (npm run prettier). If you're using vscode, you can also just use the extension.

talhajavedmukhtar · 2023-12-08T13:49:22Z

Done.

OSBotify · 2023-12-08T15:01:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-11T10:44:58Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:09:40Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

talhajavedmukhtar added 3 commits December 5, 2023 09:51

[Bug resolved]: Conversation disappears from LHN when creating an IOU…

a733043

… with a new user in offline mode

Merge branch 'Expensify:main' into resolvingOfflineModeBug

7e6afcb

Merge branch 'Expensify:main' into resolvingOfflineModeBug

cab8d7f

talhajavedmukhtar requested a review from a team as a code owner December 7, 2023 08:17

melvin-bot Bot requested review from narefyev91 and removed request for a team December 7, 2023 08:17

narefyev91 reviewed Dec 7, 2023

View reviewed changes

talhajavedmukhtar added 2 commits December 7, 2023 17:28

Made useMemo's offline dependency more specific

22dd63a

Merge branch 'resolvingOfflineModeBug' of https://github.com/talhajav…

6b05574

…edmukhtar/ExpensifyApp into resolvingOfflineModeBug

narefyev91 approved these changes Dec 7, 2023

View reviewed changes

melvin-bot Bot requested a review from arosiclair December 7, 2023 16:15

Merge branch 'main' into resolvingOfflineModeBug

ea4d9e1

arosiclair requested changes Dec 7, 2023

View reviewed changes

Comment thread src/pages/home/sidebar/SidebarLinksData.js Outdated

talhajavedmukhtar and others added 2 commits December 8, 2023 08:57

Update src/pages/home/sidebar/SidebarLinksData.js

e8f9fbc

edit SidebarLinksData props Co-authored-by: Andrew Rosiclair <arosiclair@gmail.com>

Fixed linting errors

bffe64a

arosiclair requested changes Dec 8, 2023

View reviewed changes

Ran prettier

812630f

arosiclair approved these changes Dec 8, 2023

View reviewed changes

arosiclair merged commit 21f5875 into Expensify:main Dec 8, 2023

github-actions Bot mentioned this pull request Dec 11, 2023

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

81 tasks

melvin-bot Bot mentioned this pull request Dec 13, 2023

[HOLD for payment 2023-12-20] [$500] iOS - LHN - Conversation disappears from LHN when creating an IOU with a new user in offline mode #31822

Closed

6 tasks

Uh oh!

Conversation

talhajavedmukhtar commented Dec 7, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 7, 2023

Uh oh!

github-actions Bot commented Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talhajavedmukhtar commented Dec 7, 2023

Uh oh!

talhajavedmukhtar commented Dec 7, 2023

Uh oh!

narefyev91 Dec 7, 2023

Choose a reason for hiding this comment

Uh oh!

talhajavedmukhtar Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narefyev91 Dec 7, 2023

Choose a reason for hiding this comment

Uh oh!

talhajavedmukhtar Dec 7, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 commented Dec 7, 2023

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

talhajavedmukhtar commented Dec 7, 2023

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

talhajavedmukhtar commented Dec 8, 2023

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

talhajavedmukhtar commented Dec 8, 2023

Uh oh!

OSBotify commented Dec 8, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Dec 7, 2023 •

edited

Loading

talhajavedmukhtar Dec 7, 2023 •

edited

Loading

narefyev91 commented Dec 7, 2023 •

edited

Loading