Skip to content

[IS-2850] Fixed scroll issue#3237

Merged
deetergp merged 1 commit into
Expensify:mainfrom
aliabbasmalik8:IS-2850-scroll-issue
Jun 1, 2021
Merged

[IS-2850] Fixed scroll issue#3237
deetergp merged 1 commit into
Expensify:mainfrom
aliabbasmalik8:IS-2850-scroll-issue

Conversation

@aliabbasmalik8

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

Fixes #2850

Tests

QA Steps

  • Log in with any account
  • Navigate to a conversation
  • Send a single emoji
  • Edit the message

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

IMG_20210531_114846

@aliabbasmalik8 aliabbasmalik8 requested a review from a team as a code owner May 31, 2021 06:49
@MelvinBot MelvinBot requested review from deetergp and removed request for a team May 31, 2021 06:50

@deetergp deetergp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a pretty straight forward solution. Thanks!

@deetergp deetergp merged commit 7928554 into Expensify:main Jun 1, 2021
@OSBotify

OSBotify commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@JmillsExpensify

JmillsExpensify commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Quick question @deetergp : Is QA still on-going?

@deetergp

deetergp commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

It doesn't look that way, @JmillsExpensify. Everything has been checked off the list and the list is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit box - Text scroller appears if the edited text contains a emoji

4 participants