[No QA] Update readme for auto-update to work with latest changes#3171
Merged
Conversation
Beamanator
reviewed
May 27, 2021
Beamanator
left a comment
Beamanator
left a comment
Contributor
There was a problem hiding this comment.
Looks solid to me, but I definitely think rory (or someone with related experience) should confirm 😅
Contributor
Author
|
Bump @roryabraham lmk if you need help testing |
Contributor
|
Okay, going to take a crack at this now |
roryabraham
requested changes
Jun 1, 2021
roryabraham
left a comment
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
We talked about some other clarifications 1:1 too
roryabraham
previously approved these changes
Jun 1, 2021
Contributor
Author
|
Updated! |
roryabraham
approved these changes
Jun 1, 2021
roryabraham
changed the title
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roryabraham will you please review this?
Details
This PR updates the steps to test auto-update on the desktop app.
Fixed Issues
Related to https://github.com/Expensify/Expensify/issues/151959
Tests
Run through the steps in https://github.com/Expensify/Expensify.cash/blob/joe-auto-update-readme/desktop/README.md, confirm everything works properly.
QA
No QA