Android - Fix scroll on requesting money by esh-g · Pull Request #31649 · Expensify/App

esh-g · 2023-11-21T17:09:28Z

Details

Fixed Issues

$ #31373
PROPOSAL: #31373 (comment)

Tests

Launch New Expensify app
Go to chat with long history
Scroll up as much as possible
Tap + > Request money
Send a manual request
Make sure that the newly created request is visible and page is scrolled down.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch New Expensify app
Go to chat with long history
Scroll up as much as possible
Tap + > Request money
Send a manual request
Make sure that the newly created request is visible and page is scrolled down.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-21.at.10.45.25.PM-1.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2023-11-21.at.11.17.19.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-21.at.10.43.11.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-21.at.10.40.09.PM-1.mov

MacOS: Desktop

Screen.Recording.2023-11-21.at.11.11.12.PM.mov

melvin-bot · 2023-11-21T17:09:56Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

esh-g · 2023-11-21T17:50:18Z

@narefyev91 I was unable to test on mWeb/android I seem to be getting this error on chrome: NET::ERR_CERT_AUTHORITY_INVALID because of the certificate issue with https for some reason...

narefyev91 · 2023-11-22T09:01:50Z

        }

-        flatListRef.current.scrollToOffset({animated: false, offset: 0});
+        setTimeout(() => {


@esh-g can you please add description why we could not avoid using setTimeout.. did you also try to avoid using it? Just to be 100% sure that we tried everything

can we use maybe here InteractionManager.runAfterInteractions - is should works well with native side - can you try that?

@narefyev91 After some more digging, I found the actual root cause! (very sneaky)
We are using a custom Flatlist for android and it saves the last scrolled point and goes to it after it comes into focus...

App/src/components/FlatList/index.android.js

Line 42 in b1f8bcc

props.innerRef.current.scrollToOffset({offset: scrollPosition.offset, animated: false});

When the navigation modal is dismissed, this scrolls to the last scrolled point and prevents the reportScrollManager from working correctly...

good point - i think we can fix that inside specific flatlist for android - can you try to do it?

The current logic seems to be that whenever we scroll the list, the offset is saved and when list is refocused, that offset it set again.
Here are some things that I can brainstorm:

We can modify the flatlist to make the scrollPosition available publicly (possibly with context) instead of using just state and then set the scrollPosition to 0 when dismissing modal

App/src/components/FlatList/index.android.js

Line 35 in b1f8bcc

const [scrollPosition, setScrollPosition] = useState({});

We can somehow prevent the offset from taking place after the focus

But still exploring the options

narefyev91 · 2023-11-27T12:51:23Z

Hey @esh-g any updates here?

esh-g · 2023-11-27T15:01:06Z

@narefyev91 I pushed a commit to use the context for scrollPosition. Let me know if that approach looks good. Yesterday, I was having some issues with scrolling but I think they get fixed after restarting the simulator. So please try that

narefyev91 · 2023-11-28T10:56:53Z

-    Navigation.dismissModal(isMoneyRequestReport ? report.reportID : chatReport.reportID);
-    Report.notifyNewAction(chatReport.reportID, payeeAccountID);
+    Navigation.dismissModal(activeReportID);
+    Report.notifyNewAction(activeReportID, payeeAccountID);


why do we change that from chatReport.reportID to activeReportID? Can you please explain

@narefyev91 We are always subscribed to the report opened in the report screen here:

App/src/pages/home/report/ReportActionsList.js

Line 257 in 70813db

const unsubscribe = Report.subscribeToNewActionEvent(report.reportID, (isFromCurrentUser) => {

So when we are in an expense report, chatReport.reportID which corresponds to currentChatReport passed to getMoneyRequestInformation

const currentChatReport = isMoneyRequestReport ? ReportUtils.getReport(report.chatReportID) : report;

So, currentChatReport actually becomes the original report with the other person and not the IOU or expense report. This means that when we notify a new action, we do it on parent report and not the actual expense report when using chatReport.reportID.
This is why we modified the Navigation.dismissModal line to use a different reportID so that the user is redirected to the expense report from where they requested the money. The same logic should be used for notifyNewAction.

narefyev91 · 2023-11-29T11:52:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

8mb.video-ji3-eNJbUG79.mp4

Mobile Web - Chrome

android-web.mp4

Mobile Web - Safari

ios-web.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

narefyev91

LGTM!
Nice that we were able to avoid usage of setTimeout!
🎀 👀 🎀 C+ reviewed

marcochavezf

Thank you guys! LGTM, good job for avoiding the setTimeout!

OSBotify · 2023-11-29T18:09:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-01T12:44:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.6-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Android - Fix scroll on requesting money

4b3f275

esh-g requested a review from a team as a code owner November 21, 2023 17:09

melvin-bot Bot requested review from narefyev91 and removed request for a team November 21, 2023 17:09

narefyev91 reviewed Nov 22, 2023

View reviewed changes

esh-g added 2 commits November 27, 2023 20:25

Android scrollPosition context

59698f5

Fix types

3afd5d5

Fix types

c36493a

narefyev91 reviewed Nov 28, 2023

View reviewed changes

narefyev91 approved these changes Nov 29, 2023

View reviewed changes

melvin-bot Bot requested a review from marcochavezf November 29, 2023 11:56

marcochavezf approved these changes Nov 29, 2023

View reviewed changes

marcochavezf merged commit 03386f5 into Expensify:main Nov 29, 2023

github-actions Bot mentioned this pull request Nov 30, 2023

Deploy Checklist: New Expensify 2023-11-30 #32266

Closed

42 tasks

melvin-bot Bot mentioned this pull request Dec 1, 2023

[HOLD for payment 2023-12-08] [$500] Android - Chat - Chat does not scroll down to the latest message after requesting money #31373

Closed

6 tasks

Uh oh!

Conversation

esh-g commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 21, 2023

Uh oh!

esh-g commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

narefyev91 Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

esh-g Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

esh-g Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Nov 27, 2023

Uh oh!

esh-g commented Nov 27, 2023

Uh oh!

narefyev91 Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

esh-g Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 29, 2023

Uh oh!

OSBotify commented Dec 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

esh-g commented Nov 21, 2023 •

edited

Loading

esh-g commented Nov 21, 2023 •

edited

Loading

narefyev91 commented Nov 29, 2023 •

edited

Loading