[HelpDot] Updates to HelpDot#31398
Conversation
|
@hoangzinh @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
aimane-chnaif
left a comment
There was a problem hiding this comment.
I didn't review this. Just pulling up engineer
NikkiWines
left a comment
There was a problem hiding this comment.
Generally looks good - only thing is we can remove docs/articles/new-expensify/chat/Get-to-know-Expensify-Chat.md because it's the same content as docs/articles/new-expensify/chat/Introducing-Expensify-Chat.md even though the issue says to move the former into Chat
Otherwise, coming from the issue it looks like everything's good:
Add the following category hub:
-
Chat
Remove the following category hubs:
-
Getting Started -
Expense & Report Features -
Insights & Custom Reporting -
Integrations -
Manage Employees & Report Approvals
Rename the following category hubs:
-
Bank Accounts & Credit CardstoBank Accounts
Move the following articles
- Expensify Chat For Admins to
Chat - Expensify Chat For Conference Attendees to
Chat - Expensify Chat For Conference Speakers to
Chat - Expensify Chat Playbook For Conferences to
Chat - Get to know Expensify Chat to
Chat
- Security to
Account Settings
- Referral Program to
Billing & Plan Types
Rename the following articles
-
Get to know Expensify ChattoIntroducing Expensify Chat
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Ignoring the failing |
|
@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
@allroundexperts Could you please provide clear testing steps for this PR? |
|
@kbecciv I think these are help dot changes and they don't require QA. @NikkiWines @maddylewis Can you confirm please? |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀
|




Details
More details here.
Fixed Issues
$ #31390
PROPOSAL: N/A
Tests
Op of #31390
Offline tests
N/A
QA Steps
Op of #31390
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2023-11-16.at.12.31.30.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-16.at.12.30.50.AM.mov
MacOS: Desktop