Fix: Name is not validated in Connect Bank account page by tienifr · Pull Request #30674 · Expensify/App

tienifr · 2023-11-01T04:54:36Z

Details

Name is not validated properly on client side in Connect Bank account page. This PR fixes that.

Fixed Issues

$ #27390
PROPOSAL: #27390 (comment)

Tests

Open app
Go to Settings >> Workspaces >> Any workspace >> Bank account >> Connect manually
Complete Step 1 and 2 to navigate to Step 3
Fill in invalid values for first name or last name (e.g. contains special charaters ^!#$%*=<>;{}" or numbers)
Verify that Please enter valid first name or Please enter valid last name error appears under first name or last name field

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Open app
Go to Settings >> Workspaces >> Any workspace >> Bank account >> Connect manually
Complete Step 1 and 2 to navigate to Step 3
Fill in invalid values for first name or last name (e.g. contains special charaters ^!#$%*=<>;{}" or numbers)
Verify that Please enter valid first name or Please enter valid last name error appears under first name or last name field

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-01T05:21:33Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiroslav · 2023-11-01T15:50:33Z

 }

+function isValidName(value: string) {
+    return /^[^\d\s!@#$%^&*(),.?":{}|<>]+$/.test(value);


I think we can have better regex than this. So allow only language alphabets

I think there're cases where names not only contain alphabet characters. For example Musk's daughter: X Æ A-12 Musk. Anw, there must be a reason why Onfindo did not forbid all special characters for names here.

Rename to isValidPersonName and move to Line 298 so it's below isValidDisplayName and isValidLegalName

I think there're cases where names not only contain alphabet characters. For example Musk's daughter: X Æ A-12 Musk. Anw, there must be a reason why Onfindo did not forbid all special characters for names here.

X Æ A-12 Musk what you said is treated as invalid

So what's your final approach? Only allow alphabetic and latin chars like we already did here, or follow Onfindo's rules as above?

I'm stuck on testing on Onfido since I don't have the API TOKEN. IMO, I think we should use the regex above because it matches the Onfido regex and prevent numbers. What do you think?

I am fine as long as frontend regex is equal to or more strict than backend/onfido regex.
So what I am just concerned is the case when frontend check pass but onfido check failure as this is what we're trying to fix here.

I'm stuck on testing on Onfido since I don't have the API TOKEN

You can test through newDot. Why not just check if fails in backend or not?

@0xmiroslav I believe my regex above above is more strict than onfido's one because it restricts the numbers.

So what I am just concerned is the case when frontend check pass but onfido check failure as this is what we're trying to fix here.

I checked the non-latin character and it passed

Screen.Recording.2023-11-17.at.14.44.37.mov

ok please add automated test cases as many corner cases as possible, both success and failure

tienifr · 2023-11-08T09:33:09Z

@0xmiroslav can we continue?

0xmiroslav · 2023-11-12T17:39:02Z

Also, add automated test cases

tienifr · 2023-11-20T06:36:11Z

@0xmiroslav Added tests

0xmiroslav · 2023-11-22T17:08:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

0xmiroslav

LGTM!

tienifr · 2023-11-27T07:15:25Z

@stitesExpensify Can you help review my PR when you have a chance? Thanks

stitesExpensify

LGTM, just one quick request please

stitesExpensify · 2023-11-27T17:40:21Z

+        test('Valid person name', () => {
+            expect(ValidationUtils.isValidPersonName('test name')).toBe(true);
+            expect(ValidationUtils.isValidPersonName(`X Æ A test`)).toBe(true);
+        });


Can we add a quick test for a hyphenated last name such as a hypenated-name? This is fairly common so I just want to make sure it doesn't ever get broken

tienifr · 2023-11-29T04:00:24Z

@stitesExpensify updated

stitesExpensify

Looks great, thanks!

OSBotify · 2023-11-29T13:56:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-01T12:44:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.6-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

paultsimura · 2024-01-26T13:40:47Z

+/**
+ * Checks that the provided name doesn't contain special characters or numbers
+ */
+function isValidPersonName(value: string) {
+    return /^[^\d^!#$%*=<>;{}"]+$/.test(value);
+}


Hi folks, this RegExp allows symbols like "?" or "@" – did you consider using the CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS here, or do we allow non-latin symbols in the names?

We allow non-latin symbols in the name to match Onfindo's validation rules. You can read more in our disucssion here.

Yes, just found it, thanks 👍

tienifr added 3 commits September 19, 2023 00:52

fix: 27390

eb9be0b

Merge branch 'main' into fix/27390

9f5e645

Merge branch 'main' of https://github.com/tienifr/App into fix/27390

789ae24

tienifr changed the title ~~Fix: Name not validated on client side in Connect Bank account page~~ Fix: Name is not validated in Connect Bank account page Nov 1, 2023

tienifr marked this pull request as ready for review November 1, 2023 05:21

tienifr requested a review from a team as a code owner November 1, 2023 05:21

melvin-bot Bot removed the request for review from a team November 1, 2023 05:21

melvin-bot Bot requested a review from 0xmiroslav November 1, 2023 05:21

tienifr mentioned this pull request Nov 1, 2023

[HOLD for payment 2023-12-08] [$500] Connect Bank Account - first name not being validated on client side when adding a bank account #27390

Closed

6 tasks

add type

233344f

0xmiroslav reviewed Nov 1, 2023

View reviewed changes

Merge branch 'main' of https://github.com/tienifr/App into fix/27390

cb38ee3

tienifr added 6 commits November 14, 2023 20:35

Merge branch 'main' into fix/27390

9145d57

fix merge errors

7984e1f

Merge branch 'main' into fix/27390

3bae979

Merge branch 'main' into fix/27390

5467d20

add tests

03951e6

change name

0d0fd0d

0xmiroslav approved these changes Nov 22, 2023

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify November 22, 2023 17:09

stitesExpensify requested changes Nov 27, 2023

View reviewed changes

tienifr added 2 commits November 29, 2023 10:57

Merge branch 'main' into fix/27390

807b964

add hyphenated test

e9a556e

stitesExpensify approved these changes Nov 29, 2023

View reviewed changes

stitesExpensify merged commit 2f9ae2d into Expensify:main Nov 29, 2023

github-actions Bot mentioned this pull request Nov 30, 2023

Deploy Checklist: New Expensify 2023-11-30 #32266

Closed

42 tasks

lanitochka17 mentioned this pull request Nov 30, 2023

[$500] BA - No validation error when emoji and certain symbols are entered in name field #32291

Closed

6 tasks

paultsimura reviewed Jan 26, 2024

View reviewed changes

Uh oh!

Conversation

tienifr commented Nov 1, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xmiroslav Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr commented Nov 8, 2023

Uh oh!

0xmiroslav commented Nov 12, 2023

Uh oh!

tienifr commented Nov 20, 2023

Uh oh!

0xmiroslav commented Nov 22, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Nov 27, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr commented Nov 29, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 29, 2023

Uh oh!

OSBotify commented Dec 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

tienifr commented Nov 1, 2023 •

edited by github-actions Bot

Loading

tienifr Nov 2, 2023 •

edited

Loading

tienifr Nov 14, 2023 •

edited

Loading

0xmiroslav Nov 17, 2023 •

edited

Loading

tienifr Jan 26, 2024 •

edited

Loading