Convert line-breaks to spaces in LHN message preview

[parasharrajat]

Details

Fixed Issues

Fixes #2965

Tests / QA Steps

1. Navigate to a conversation
2. Send this message

Cool
Test
Of
New line

3. Check the message preview in the LHN.
4. There should be a space between newlines text in the preview.
5. Multiple new lines should only add one space.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

lhn-w.mp4

Mobile Web

Desktop

iOS

Android

[parasharrajat]

Blocker: We also need to modify the backend so that it convert <Br> to spaces while sending data from Pusher & API

[parasharrajat]

Bumping here so that blocker can be resolved. Thanks.

[parasharrajat]

@deetergp Have you got a chance to review it? And could you please tag the right guy for backend blocker. Thanks

[deetergp]

Hey @parasharrajat 👋 Been a bit swamped with other stuff, but getting up to speed on this. I'm pretty sure the answer to this is "no" but do you know whether there was a GH made for the back end portion of this? If there is, then I don't want to step on someone else's toes, but if one hasn't been made, I will put one together and probably just do the work myself. Thanks!

[deetergp]

@parasharrajat Can you explain why backend changes are needed? Can you show examples of where not having these changes is causing problems?

[parasharrajat]

Yes. @deetergp. When we save the report using the Report_AddComment we send all the html and this api returns a response back which includes text as well. I saw that this text is different from what we have send. Also, other user will receive the Pusher event with the message payload that also contains the text. Let me know if I am missing something here.

[deetergp]

The blocking back-end portion has been merged, un-blocking this one. We're good to go! 🎉

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[isagoico]

@parasharrajat @deetergp
We found this issue in Android and iOS apps

2 spaces are displayed in LHN for a line break

Expected result

Only 1 space should be displayed for a line break

Actual result

2 spaces are displayed for a line break

Action Performed

1. Navigate to a conversation
2. Send this message

Cool
Test
Of
New line

3. Check the message preview in the LHN.

Platform

iOS ✔️
Android ✔️

Images/Notes/Video

[isagoico]

Will open a separate issue for the above 🔝 Following Rory's comment here #3059 (comment)