[No QA][TS migration] Migrate 'usePrevious.js' hook to TypeScript#29019
Conversation
usePrevious to TS|
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
LGTM ! |
Santhosh-Sellavel
left a comment
There was a problem hiding this comment.
I didn't review this
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24937 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.81-0 🚀
|
|
🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.83-0 🚀
|
Details
Fixed Issues
$ #24937
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web_H.265.mp4
Mobile Web - Chrome
android.web_H.265.mp4
Mobile Web - Safari
ios.native_H.265.mp4
Desktop
desktop_H.265.mp4
iOS
ios.native_H.265.mp4
Android
android.native_H.265.mp4