Skip to content

[No QA][TS migration] Migrate 'PersistedRequests.js' lib to TypeScript #27349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerkaraszewski merged 1 commit into from
Sep 19, 2023
Merged

[No QA][TS migration] Migrate 'PersistedRequests.js' lib to TypeScript #27349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions src/libs/actions/PersistedRequests.js → src/libs/actions/PersistedRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
import Onyx from 'react-native-onyx';
import _ from 'underscore';
import isEqual from 'lodash/isEqual';
import ONYXKEYS from '../../ONYXKEYS';
import {Request} from '../../types/onyx';

let persistedRequests = [];
let persistedRequests: Request[] = [];

Onyx.connect({
key: ONYXKEYS.PERSISTED_REQUESTS,
callback: (val) => (persistedRequests = val || []),
callback: (val) => (persistedRequests = val ?? []),
});

function clear() {
Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, []);
}

/**
* @param {Array} requestsToPersist
*/
function save(requestsToPersist) {
function save(requestsToPersist: Request[]) {
if (persistedRequests.length) {
persistedRequests = persistedRequests.concat(requestsToPersist);
} else {
Expand All @@ -25,16 +23,13 @@ function save(requestsToPersist) {
Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
}

/**
* @param {Object} requestToRemove
*/
function remove(requestToRemove) {
function remove(requestToRemove: Request) {
/**
* We only remove the first matching request because the order of requests matters.
* If we were to remove all matching requests, we can end up with a final state that is different than what the user intended.
*/
const requests = [...persistedRequests];
const index = _.findIndex(requests, (persistedRequest) => _.isEqual(persistedRequest, requestToRemove));
const index = requests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
if (index !== -1) {
requests.splice(index, 1);
}
Expand All @@ -43,10 +38,7 @@ function remove(requestToRemove) {
Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
}

/**
* @returns {Array}
*/
function getAll() {
function getAll(): Request[] {
return persistedRequests;
}

Expand Down