Fix Pronouns loses focus on coming back from new group page or search page

[hoangzinh]

Details

Fixed Issues

$ #26350
PROPOSAL: #26350 (comment)

Tests

On Web/Desktop

1. Open the app
2. Open settings->profile->pronouns
3. Open new group page or search page using keyboard shortcut
4. Go back
5. Verify that Pronouns input is still focused

• Verify that no errors appear in the JS console

Offline tests

Changes are not affected by network status

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-11.at.20.45.30.-.web.mov

Mobile Web - Chrome

Screen.Recording.2023-09-11.at.22.43.53.-.android.chrome.mov

Mobile Web - Safari

Screen.Recording.2023-09-11.at.22.45.12.-.ios.safari.mov

Desktop

Screen.Recording.2023-09-11.at.22.47.36.-.desktop.mov

iOS

Screen.Recording.2023-09-11.at.22.46.11.-.ios.mov

Android

Screen.Recording.2023-09-11.at.22.43.05.-.android.mov

[melvin-bot]

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Ollyws]

Perhaps it might be better to use the useIsFocused() hook instead of withNavigationFocus as this is a functional component.

[hoangzinh]

That's fair call. I just updated the PR to use hook instead of HOC

[Ollyws]

Why is the use of withNavigationFallback necessary here?

[hoangzinh]

This PR had perf-tests failed previously https://github.com/Expensify/App/actions/runs/6147658200/job/16679631094?pr=27147

After searching through the codebase, I found that in the Button component, we also use this fallback

App/src/components/Button/index.js

Lines 326 to 327 in bfc6468

	withNavigationFallback,
	withNavigationFocus,

After I tried to apply the fallback HOC, it passed the perf-tests

[Ollyws]

Ahh I guess because the perf-tests don't wrap it in a NavigationContainer. Any thoughts on this @tgolen?

[tgolen]

I don't have any general knowledge of either of those, so I don't have any thoughts, no. Do you have any questions specifically?

[Ollyws]

Ah ok no problem. Well the alternative to utilizing the fallback would be perhaps to modify the perf-tests themselves but that seems a little out of scope here so utilizing the navigation fallback is fine, in my opinion.

[Ollyws]

I think this may have just been fixed by #26415, @hoangzinh Can you confirm?

[hoangzinh]

I think this may have just been fixed by #26415, @hoangzinh Can you confirm?

You're right. It has been fixed by that PR

[tgolen]

Can this be closed then?

[Ollyws]

Yeah this can be closed.