Skip to content

Fix "Copy URL to clipboard" not working by long tap #25599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 2 commits into from
Aug 22, 2023
Merged

Fix "Copy URL to clipboard" not working by long tap #25599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0ad2a
fix: 24456
dukenv0307 Aug 18, 2023
f397714
Merge branch 'main' into fix/24456
dukenv0307 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ function BaseAnchorForCommentsOnly({onPressIn, onPressOut, href = '', rel = '',
lodashGet(linkRef, 'current'),
);
}}
onPress={linkProps.onPress}
onPress={(event) => {
if (!linkProps.onPress) {
return;
}

event.preventDefault();
linkProps.onPress();
}}
onPressIn={onPressIn}
onPressOut={onPressOut}
accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK}
Expand All @@ -80,14 +87,6 @@ function BaseAnchorForCommentsOnly({onPressIn, onPressOut, href = '', rel = '',
target: isEmail || !linkProps.href ? '_self' : target,
}}
href={linkProps.href || href}
onPress={(event) => {
if (!linkProps.onPress) {
return;
}

event.preventDefault();
linkProps.onPress();
}}
suppressHighlighting
// Add testID so it gets selected as an anchor tag by SelectionScraper
testID="a"
Expand Down