Create SaaStr Landing Page with new `DemoSetupPage` component by grgia · Pull Request #24649 · Expensify/App

grgia · 2023-08-16T21:20:31Z

Details

Creates the landing page located at /saastr

I created a new component DemoSetupPage as outlined in the Design Doc and refactored the Sign In Page so we can pass in a custom headline for future conferences. This can be done in two files by changing login.hero.demoHeadline in en.js and es.js:

    login: {
        hero: {
            ...
            demoHeadline: 'YOUR CUSTOM HEADLINE HERE',
        },
    },

Desktop:

Mobile:

Spanish:

NOTE
For future Demos, we may want to make this modification to passing in the headerPath:
#24649 (comment)

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/308667

Tests

Verify that no errors appear in the JS console

THIS IS A WEB-ONLY CHANGE

For Web and mWeb:

Go to the normal sign in page and follow sign in flow
Go to http://localhost:8082/saastr and follow sign in flow
- ensure copy is correct on mobile and desktop
- ensure user is signed in without error

For Native and Desktop:

Go to the normal sign in page and follow sign in flow, ensure user is signed in without error

Offline tests

QA Steps

Verify that no errors appear in the JS console

For Web and mWeb:

Go to staging.new.expensify.com for staging or new.expensify.com for prod and follow sign in flow
- ensure user is signed in without error
Go to staging.new.expensify.com/saastr for staging or new.expensify.com/saastr for prod and follow sign in flow
- ensure copy is correct on mobile and desktop
- ensure user is signed in without error

For Native and Desktop:

Go to staging.new.expensify.com for staging or new.expensify.com for prod and follow sign in flow
- ensure user is signed in without error

PR Author Checklist

Screenshots/Videos

Web

Desktop:

Mobile:

Mobile Web - Chrome

Mobile Web - Safari

Desktop

N/A - Custom Route

iOS

N/A - Custom Route

Android

N/A - Custom Route

melvin-bot · 2023-08-16T21:43:28Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-08-16T23:10:41Z


 const propTypes = {
+    /** Override the green headline copy */
+    customHeadline: PropTypes.string,


NAB. I think this should be headline or headlineText and marked as required.

The better alternative is to just make the default value props.translate('login.hero.header') but I don't think this is possible, we can't make the default value of one prop dependent on another prop.

but I don't think this is possible, we can't make the default value of one prop dependent on another prop.

Yeah this was my thought as well- I agree it would be better as required and then just pass the headline function as an option to the react navigator stack
I think for now, we can leave this as is, as it'll only be used for conferences and creating custom sign in pages for events such as in this PR

NAB too, but if you wanted to do what @s77rt is suggesting, headline would receive the translation key and default to login.hero.header

When you use the component in the Demo page, you would pass the prop like:

<SignInPage customHeadline="login.hero.demoHeadline" />

instead of

<SignInPage customHeadline={translate('login.hero.demoHeadline')} />

but again, NAB, I don't feel like this is better or worse, just an alternative

PD:

{props.customHeadline || props.translate('login.hero.header')}

would become

{props.translate(props.headline)}

To be honest, I don't think that this change is worth blocking the PR since this is a critical issue

I'll add a link to this comment in the description of this PR for the next time we update the demos?

Sounds good to me 👍

s77rt · 2023-08-16T23:37:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

s77rt

LGTM! 🚀

melvin-bot · 2023-08-17T13:52:30Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-08-17T13:52:34Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #25396.

grgia · 2023-08-17T13:53:24Z

cc @Beamanator if you want to review for SaaStr project!

OSBotify · 2023-08-17T19:40:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Beamanator · 2023-08-18T07:48:27Z

Innnnteresting, I didn't know we had a separate issue for this, I made my own version of this solution here - #24535

FYI we're going to have to do a very similar thing for SBE 😅

OSBotify · 2023-08-21T22:25:22Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:08:23Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

grgia added 2 commits August 16, 2023 16:01

Add /SaaStr Route and Mobile Heading

0032f16

Pass customHeadline down for desktop screens

1609b9e

grgia self-assigned this Aug 16, 2023

grgia added 2 commits August 16, 2023 16:29

Commit DemoSetUp component

1803a2e

Add translations

0310dbb

grgia marked this pull request as ready for review August 16, 2023 21:43

grgia requested a review from a team as a code owner August 16, 2023 21:43

melvin-bot Bot removed the request for review from a team August 16, 2023 21:43

melvin-bot Bot requested a review from s77rt August 16, 2023 21:43

prettier

4fb1754

s77rt suggested changes Aug 16, 2023

View reviewed changes

Update src/pages/signin/DemoSetupPage.js

3c492b5

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

s77rt approved these changes Aug 17, 2023

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify August 17, 2023 13:52

melvin-bot Bot mentioned this pull request Aug 17, 2023

[Aug 23] Payment issue for E/App PR#24649 #25396

Closed

aldo-expensify approved these changes Aug 17, 2023

View reviewed changes

aldo-expensify merged commit 0d4dfef into main Aug 17, 2023

aldo-expensify deleted the georgia-SaaStrLanding branch August 17, 2023 19:36

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

Uh oh!

Conversation

grgia commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 16, 2023

Uh oh!

Uh oh!

s77rt Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

grgia Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grgia Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

grgia Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

aldo-expensify Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 17, 2023

Uh oh!

melvin-bot Bot commented Aug 17, 2023

Uh oh!

grgia commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

Beamanator commented Aug 18, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

grgia commented Aug 16, 2023 •

edited

Loading

grgia Aug 17, 2023 •

edited

Loading

aldo-expensify Aug 17, 2023 •

edited

Loading

s77rt commented Aug 16, 2023 •

edited

Loading