Disable timezone list if automatic timezone is turned on by bernhardoj · Pull Request #24577 · Expensify/App

bernhardoj · 2023-08-15T13:03:40Z

Details

When the automatic timezone is turned on, we can go to the selection/list page and select manually a new one. We previously disabled the list here, but because of some regression, we need to refix this again.

Fixed Issues

$ #24516
PROPOSAL: #24516 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to Settings>Profile>Timezone
Turn on the automatic timezone
Open staging.new.expensify.com/settings/profile/timezone/select
Verify the timezone list is disabled (you can't select any timezone and the selected timezone does not have any highlight effect)
From other browser tabs/devices, turn off the automatic timezone
Verify the timezone list is now enabled (the selected timezone is now highlighted)
Select any timezone and verify the timezone is selected.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-15.at.20.22.16.mov

Mobile Web - Chrome

Screen.Recording.2023-08-15.at.20.40.39.mov

Mobile Web - Safari

Screen.Recording.2023-08-15.at.20.31.50.mov

Desktop

Screen.Recording.2023-08-15.at.20.26.17.mov

iOS

Screen.Recording.2023-08-15.at.20.30.30.mov

Android

Screen.Recording.2023-08-15.at.21.10.13.mov

melvin-bot · 2023-08-15T13:03:44Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-08-15T13:11:32Z

We can notice from the recording that the list item is highlighted when focused because it has a focusStyle here.

App/src/components/SelectionListRadio/RadioListItem.js

Line 37 in 70c5259

focusStyle={styles.hoveredComponentBG}

We have a similar issue previously here. Do we want to remove the focusStyle?

with focusStyle

Screen.Recording.2023-08-15.at.21.08.07.mov

without focusStyle

Screen.Recording.2023-08-15.at.21.08.53.mov

this is the only place that use focusStyle

bernhardoj · 2023-08-18T03:58:48Z

@0xmiroslav bump for review

0xmiroslav · 2023-08-18T06:15:57Z

@bernhardoj item should not be highlighted on click when disabled

Screen.Recording.2023-08-18.at.8.14.30.AM.mov

bernhardoj · 2023-08-18T06:17:15Z

That's the issue I mentioned in my previous comment.

0xmiroslav · 2023-08-18T06:19:36Z

@bernhardoj yes, but it's when not disabled, correct? The issue you mentioned is also the case when disabled?

bernhardoj · 2023-08-18T06:22:47Z

Yes, it's the same. Disabled or enabled, the pressable can receive a focus event. I think it makes sense to disable the focus event when the pressable (GenericPressable) is disabled (onFocus={!isDisabled && onFocus}), but I think what we need to care is the focusStyle. I think it should be removed.

0xmiroslav · 2023-08-18T06:23:24Z

This was original behavior before SelectionListRadio refactor:

219102821-485d5a8e-e2bf-4b1e-92e0-47ae3f611fb5.mov

0xmiroslav · 2023-08-18T06:24:53Z

Honestly I don't care about this UX too much (the issue itself is edge case) but someone will be sure to report this as regression

0xmiroslav · 2023-08-18T06:28:05Z

            focusStyle={props.isDisabled ? {} : styles.hoveredComponentBG}

Why can't we just do this?

0xmiroslav · 2023-08-18T06:32:07Z

@mountiny do you agree this won't be considered as bug? #24577 (comment) with focusStyle

bernhardoj · 2023-08-18T06:35:33Z

            focusStyle={props.isDisabled ? {} : styles.hoveredComponentBG}

Why can't we just do this?

We can totally do this, but I'm thinking why we want to keep the focus style.

I reported a similar issue about the focus style here applied in OptionRow. Here is the reason why the focus style is added. The solution then is to restructure the PressableWithFeedback and remove the focus style.

It's actually not related to our issue, but I think maybe we can remove it here.

0xmiroslav · 2023-08-18T06:38:07Z

            focusStyle={props.isDisabled ? {} : styles.hoveredComponentBG}

This is actually workaround. We should prevent highlight in root level on PressableWithFeedback component when disabled is true, not just visual fix.

0xmiroslav · 2023-08-18T06:38:44Z

So I'd say that concern is out of scope for this PR

0xmiroslav · 2023-08-18T06:49:43Z

I believe this inconsistency will be reported by someone:

mSafari: highlight on press

msafari.mov

iOS: no highlight on press

ios.mov

I think we can leave this for this PR but just to confirm that we're already aware of this

bernhardoj · 2023-08-18T06:57:28Z

I believe this inconsistency will be reported by someone:

technically, I think it's not inconsistent because onFocus is not available on native.

I think we can leave this for this PR but just to confirm that we're already aware of this

So, should I report this focus issue as a new bug?

0xmiroslav · 2023-08-18T07:00:21Z

So, should I report this focus issue as a new bug?

Maybe you can report and tag Shawn to get design feedback

0xmiroslav · 2023-08-18T07:06:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-ios.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiroslav

LGTM!

cc: @mountiny
Confirmation from you:
#24577 (comment)
#24577 (comment)

mountiny · 2023-08-18T11:54:40Z

@bernhardoj Could you please post in slack with the two options and tag Shawn to decide this? thanks!

bernhardoj · 2023-08-18T13:02:54Z

Reported it here https://expensify.slack.com/archives/C049HHMV9SM/p1692362806331939

…-is-on

bernhardoj · 2023-08-18T13:31:16Z

Merged with main and removed the focus style.

0xmiroslav · 2023-08-18T13:31:31Z

Works well

Screen.Recording.2023-08-18.at.3.30.06.PM.mov

mountiny

Thanks guys!

OSBotify · 2023-08-18T13:49:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:24:43Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2023-08-23T20:08:03Z

#24577 - Failing #24516

@mvtglobally Applause reported this PR as a QA fail. Not a deploy blocker, but fails to address the original issue. Can you provide some additional details here?

OSBotify · 2023-08-24T03:07:44Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

bernhardoj added 2 commits August 15, 2023 20:46

disable the list item if the section is disabled

0bb578b

fix user current timezone does not updated dynamically

8277925

bernhardoj requested a review from a team as a code owner August 15, 2023 13:03

melvin-bot Bot removed the request for review from a team August 15, 2023 13:03

melvin-bot Bot requested a review from 0xmiroslav August 15, 2023 13:03

mountiny assigned bernhardoj Aug 15, 2023

0xmiroslav approved these changes Aug 18, 2023

View reviewed changes

melvin-bot Bot requested a review from mountiny August 18, 2023 07:07

bernhardoj added 2 commits August 18, 2023 21:23

Merge branch 'main' into fix/24516-disable-timezone-list-if-automatic…

7d9fb9e

…-is-on

remove focus style

b7ae912

0xmiroslav approved these changes Aug 18, 2023

View reviewed changes

mountiny approved these changes Aug 18, 2023

View reviewed changes

mountiny merged commit a068ca5 into Expensify:main Aug 18, 2023

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

bernhardoj mentioned this pull request Sep 22, 2023

[$500] MacOS/Chrome - Background color is stuck on right click/long press on year in year search #27832

Closed

6 tasks

Uh oh!

Conversation

bernhardoj commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 15, 2023

Uh oh!

bernhardoj commented Aug 15, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Aug 18, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

bernhardoj commented Aug 18, 2023

Uh oh!

0xmiroslav commented Aug 18, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 18, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

roryabraham commented Aug 23, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

bernhardoj commented Aug 15, 2023 •

edited

Loading

0xmiroslav commented Aug 18, 2023 •

edited

Loading