Skip to content

Change position: absolute for position:fixed in getNavigationModalCard #24305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnmlee101 merged 2 commits into from
Aug 9, 2023
Merged

Change position: absolute for position:fixed in getNavigationModalCard #24305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3657fc7
Change position: absolute for position:fixed in getNavigationModalCar…
jscardona12 Aug 9, 2023
209cb76
Fix comment
jscardona12 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libs/Navigation/AppNavigator/AuthScreens.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ class AuthScreens extends React.Component {
// we want pop in RHP since there are some flows that would work weird otherwise
animationTypeForReplace: 'pop',
cardStyle: getNavigationModalCardStyle({
windowHeight: this.props.windowHeight,
isSmallScreenWidth: this.props.isSmallScreenWidth,
}),
};
Expand Down
8 changes: 3 additions & 5 deletions src/styles/getNavigationModalCardStyles/index.website.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import getBaseNavigationModalCardStyles from './getBaseNavigationModalCardStyles';

export default ({windowHeight, isSmallScreenWidth}) => ({
export default ({isSmallScreenWidth}) => ({
...getBaseNavigationModalCardStyles({isSmallScreenWidth}),

// This height is passed from JavaScript, instead of using CSS expressions like "100%" or "100vh", to work around
// position: fixed is set instead of position absolute to workaround Safari known issues of updating heights in DOM.
// Safari issues:
// https://github.com/Expensify/App/issues/12005
// https://github.com/Expensify/App/issues/17824
// https://github.com/Expensify/App/issues/20709

height: `${windowHeight}px`,
minHeight: `${windowHeight}px`,
position: 'fixed',
});