-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[No QA] Onyx type core data #24054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hayata-suenaga
merged 130 commits into
Expensify:main
from
blazejkustra:typescript/onyx-types
Aug 22, 2023
Merged
[No QA] Onyx type core data #24054
Changes from all commits
Commits
Show all changes
130 commits
Select commit
Hold shift + click to select a range
0989715
Initial work on onyx types
blazejkustra 13ee74d
Change comments to JSDOC
blazejkustra c8ed8f9
Improve onyx common types + finish account type
blazejkustra b8fdc46
Add type for ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID
blazejkustra 2e2f1e0
Add type for ONYXKEYS.NVP_IS_FIRST_TIME_NEW_EXPENSIFY_USER
blazejkustra fe9faf1
Add type for ONYXKEYS.ACTIVE_CLIENTS
blazejkustra 6d8223d
Add type for ONYXKEYS.DEVICE_ID
blazejkustra 418fd37
Add type for ONYXKEYS.IS_SIDEBAR_LOADED
blazejkustra 46a9fd0
Add type for ONYXKEYS.QUEUED_ONYX_UPDATES
blazejkustra e66f1f9
Add type for ONYXKEYS.CURRENT_DATE
blazejkustra 82671a0
Change the structure a bit
blazejkustra c78cd76
Add type for ONYXKEYS.CREDENTIALS
blazejkustra 47181cd
Add type for ONYXKEYS.IOU
blazejkustra 87d7c87
Add type for ONYXKEYS.MODAL
blazejkustra 08c951a
Add type for ONYXKEYS.NETWORK
blazejkustra 2c117f9
Add type for ONYXKEYS.PERSONAL_DETAILS_LIST
blazejkustra 8f28192
Add type for ONYXKEYS.PRIVATE_PERSONAL_DETAILS
blazejkustra 83d87c6
Add type for ONYXKEYS.TASK
blazejkustra d9dbcec
Add type for ONYXKEYS.CURRENCY_LIST
blazejkustra dbb9b63
Add type for ONYXKEYS.UPDATE_AVAILABLE
blazejkustra 9d33b9d
Add type for ONYXKEYS.SCREEN_SHARE_REQUEST
blazejkustra 1e0f66b
Add type for ONYXKEYS.COUNTRY_CODE
blazejkustra c9c0425
Add type for ONYXKEYS.USER
blazejkustra f9976ed
Add type for ONYXKEYS.LOGIN
blazejkustra 6990be1
Add type for ONYXKEYS.SESSION
blazejkustra 40e7bdc
Add type for ONYXKEYS.BETAS
blazejkustra c98189a
Add type for ONYXKEYS.PAYPAL
blazejkustra 85bfc4e
Add type for ONYXKEYS.NVP_PRIORITY_MODE
blazejkustra 548fd4a
Add type for ONYXKEYS.NVP_BLOCKED_FROM_CONCIERGE
blazejkustra 53b466f
Add type for ONYXKEYS.NVP_PRIVATE_PUSH_NOTIFICATION_ID
blazejkustra a748462
Add type for ONYXKEYS.NVP_LAST_PAYMENT_METHOD
blazejkustra 3c73f40
Add type for ONYXKEYS.PUSH_NOTIFICATIONS_ENABLED
blazejkustra d53b28d
Add type for ONYXKEYS.PLAID_DATA
blazejkustra 68350a0
Add all values and type booleans
blazejkustra c17349a
Add type for ONYXKEYS.PLAID_LINK_TOKEN
blazejkustra 358bd6e
Add type for ONYXKEYS.ONFIDO_TOKEN
blazejkustra 4e0728a
Add type for ONYXKEYS.NVP_PREFERRED_LOCALE
blazejkustra 8d0712c
Remove TRANSACTIONS_BEING_REJECTED as it is not used
blazejkustra 439e2e3
Add type for ONYXKEYS.USER_WALLET
blazejkustra 3631ceb
Add type for ONYXKEYS.WALLET_ONFIDO
blazejkustra 77840a3
Add type for ONYXKEYS.WALLET_ADDITIONAL_DETAILS
blazejkustra 49a0be1
Add type for ONYXKEYS.WALLET_TERMS
blazejkustra 96ddb62
Add type for ONYXKEYS.BANK_ACCOUNT_LIST
blazejkustra 7ad0a1c
Add type for ONYXKEYS.CARD_LIST
blazejkustra 8beae08
Add type for ONYXKEYS.WALLET_STATEMENT
blazejkustra 2efd61d
Add type for ONYXKEYS.PERSONAL_BANK_ACCOUNT
blazejkustra 61adcc2
Add type for ONYXKEYS.LAST_OPENED_PUBLIC_ROOM_ID
blazejkustra fa5da57
Add type for ONYXKEYS.MY_DOMAIN_SECURITY_GROUPS
blazejkustra 065b49a
Add type for ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT
blazejkustra d86d350
Add type for ONYXKEYS.LAST_ACCESSED_WORKSPACE_POLICY_ID
blazejkustra e7be147
Add type for ONYXKEYS.PREFERRED_EMOJI_SKIN_TONE
blazejkustra 084e6e3
Add type for ONYXKEYS.FREQUENTLY_USED_EMOJIS
blazejkustra 77a0047
Add type for ONYXKEYS.REIMBURSEMENT_ACCOUNT & REIMBURSEMENT_ACCOUNT_D…
blazejkustra 5d3877a
Add type for ONYXKEYS.WALLET_TRANSFER
blazejkustra e7b0ae5
Add type for FORMS
blazejkustra 4f0ea3e
Add types for ONYXKEYS.COLLECTIONS
blazejkustra dec3f7a
Add types for ONYXKEYS.COLLECTION.DEPRECATED_POLICY_MEMBER_LIST
blazejkustra 8b1dfb4
Move comment back to original place
blazejkustra 56b79d0
Add types for ONYXKEYS.COLLECTION.POLICY
blazejkustra 6291651
Add types for ONYXKEYS.COLLECTION.WORKSPACE_INVITE_MEMBERS_DRAFT
blazejkustra c875d5a
Add types for ONYXKEYS.COLLECTION.REPORT
blazejkustra 0a522fa
Add types for ONYXKEYS.COLLECTION.REPORT_ACTIONS
blazejkustra f21bb70
Add types for ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS
blazejkustra 3dbccd9
Remove COLLECTION.REPORT_ACTIONS_REACTIONS as it is not used
blazejkustra 422a1fc
Add types for ONYXKEYS.COLLECTION.REPORT related collections
blazejkustra 854a8f9
Add types for ONYXKEYS.COLLECTION.SECURITY_GROUP
blazejkustra 9276a22
Add types for ONYXKEYS.COLLECTION.TRANSACTION
blazejkustra 0b4146a
Changes after initial review
blazejkustra c3a7a87
Type errors better
blazejkustra 00ec1a4
Add missing types from ReportAction
blazejkustra 243377b
Replace REIMBURSEMENT_ACCOUNT_FORM with REIMBURSEMENT_ACCOUNT
blazejkustra f91267d
Add missing Report types
blazejkustra ac27dd3
Rename FieldErrors to ErrorFields
blazejkustra d218629
Correct types after review
blazejkustra 842985e
Type persisted requests
blazejkustra 6321e34
Fix namings and comments
blazejkustra b564671
Add changes to UserWallet
blazejkustra 96b72c9
Fix type utils structure
blazejkustra 88b548d
Add more changes to UserWallet
blazejkustra 178b697
Add accountId to Credentials
blazejkustra c258aaf
Update Account type
blazejkustra e2d2edb
Update ACHData type
blazejkustra 4568e0e
Update Currency type
blazejkustra 38b6280
Update User type
blazejkustra e511910
Add new onyx keys: PREFERRED_THEME and IS_USING_MEMORY_ONLY_KEYS
blazejkustra e97b29c
Change OnfidoWallet to WalletOnfido
blazejkustra 3ad2a94
Adjust WalletOnfido
blazejkustra af9ec42
Adjust PersonalDetails
blazejkustra 9854cdf
Adjust IOU
blazejkustra ce377f9
Adjust BlockedFromConcierge
blazejkustra 3197d7b
Adjust FrequentlyUsedEmoji
blazejkustra bd127d3
Adjust Paypal
blazejkustra 436e009
Fix a typo
blazejkustra 6da3ffb
Adjust BankAccount
blazejkustra c5e745e
Adjust ReportAction
blazejkustra 43e2812
Adjust Transaction
blazejkustra 9e17430
Adjust Card
blazejkustra f81d067
Adjust BlockedFromConcierge
blazejkustra aba2593
Adjust Transaction
blazejkustra 0824e2c
Adjust ReimbursementAccountDraft
blazejkustra 7fb38e8
Adjust ReimbursementAccount
blazejkustra 70d2443
Adjust PrivatePersonalDetails
blazejkustra 2e32657
Adjust Policy
blazejkustra 2f736a1
Adjust types after feedback
blazejkustra 0c9e3bc
Extract original message to a separate file
blazejkustra 0f8b1dd
Add remaining original messages types
blazejkustra ae25eb4
Make fields optional
blazejkustra 539f775
Adjust ReimbursementAccountDraft
blazejkustra e25861f
Remove BaseState completely
blazejkustra ba79ba6
Last adjustmnets to types
blazejkustra 68e8255
Fix a typo
blazejkustra de467c9
Merge branch 'blazejkustra/typescript-poc' into typescript/onyx-types
blazejkustra 2e14ef0
Fix eslint errors
blazejkustra e8b27af
Adjust the PR after last review
blazejkustra bcd4a90
Add types for ONYXKEYS.COLLECTION.REPORT_ACTIONS_REACTIONS
blazejkustra c7fb74a
Overwrite react-native-onyx in global.d.ts
blazejkustra 1cee790
Change how onyx collection values are defined
blazejkustra 62e479c
Merge branch 'main' into typescript/onyx-types
blazejkustra 4eb4797
Remove flipper-plugin-bridgespy-client package
blazejkustra 01bc2ec
Merge branch 'main' into typescript/onyx-types
blazejkustra 6a2ddf1
Adjust types after review
blazejkustra 4069588
Merge branch 'main' into typescript/onyx-types
blazejkustra 77456a9
Add MAPBOX_ACCESS_TOKEN & ONYX_UPDATES
blazejkustra e070872
Install typed version of react-native-onyx
blazejkustra d733647
Merge branch 'main' into typescript/onyx-types
blazejkustra 278183e
Fix CustomStatusDraft missing file
blazejkustra 3eb82ca
Merge branch 'main' into typescript/onyx-types
blazejkustra 23290ba
Reinstall deps
blazejkustra d58f198
Merge branch 'main' into typescript/onyx-types
blazejkustra e391b0f
Merge branch 'main' into typescript/onyx-types
blazejkustra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.