Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
e30d9d2
Revert "Merge pull request #23295 from Expensify/revert-16723-apple-s…
lindboe Jul 21, 2023
243c7eb
Added react-native-google-signin
cdanwards Jul 20, 2023
cee1a2d
Added contributing guide text
cdanwards Jul 20, 2023
409be2f
Ran pod install
cdanwards Jul 20, 2023
bf6fa12
Added url scheme to info plist
cdanwards Jul 20, 2023
75a205c
Add google ids to const
cdanwards Jul 20, 2023
7cf33eb
Adds Desktop Pages
cdanwards Jul 20, 2023
1e893fd
Adds jest config fix
cdanwards Jul 20, 2023
fa47fa7
Adds linkingConfig and Icon
cdanwards Jul 20, 2023
2dd569d
Adds Google Sign In Buttons
cdanwards Jul 20, 2023
7bdf16f
Adds begin google sign in function
cdanwards Jul 20, 2023
cbd132b
Updates LoginForm ThirdPartySignInPage and styles
cdanwards Jul 20, 2023
b052e1e
Create DesktopRedirectPage
cdanwards Jul 10, 2023
5a8e513
Added Desktop Login method to onyx
cdanwards Jul 10, 2023
4eb4ecb
Set up everything to display redirect screen
cdanwards Jul 11, 2023
75d01cf
Switch to using DeeplinkRedirectLoadingIndicator
cdanwards Jul 11, 2023
4153b86
Redirection to desktop flow is working
cdanwards Jul 14, 2023
11fd24c
Revert back Deeplinkredirectloadingindicator
cdanwards Jul 17, 2023
257e3c4
Updated logic on DesktopRedirectPage
cdanwards Jul 17, 2023
cb2b07e
Fix navigation logic when navigating back to Desktop
cdanwards Jul 17, 2023
22d0db4
Add navigation to HOME for continue to web app
cdanwards Jul 17, 2023
c0dc536
Cleanup after self review
cdanwards Jul 17, 2023
4e3a024
Fix issue with google sign in button
cdanwards Jul 18, 2023
60afcb0
Switch from onyx key to url pathname redirect approach
cdanwards Jul 18, 2023
518b912
Remove console log
cdanwards Jul 19, 2023
26676a6
Added Spanish Translations
cdanwards Jul 19, 2023
194e809
Removed unused line
cdanwards Jul 19, 2023
34fc06a
Some updates after self-review
cdanwards Jul 19, 2023
04d5d6e
Reverting a change
cdanwards Jul 19, 2023
78ad536
Adds loadingindicator when making expensify api call
cdanwards Jul 19, 2023
a4c611c
fixed prop
cdanwards Jul 19, 2023
2f13689
Fix build error
cdanwards Jul 21, 2023
8a110a6
Fix staging configuration
lindboe Jul 20, 2023
629a9cb
New fix: use shared values in CONFIG
lindboe Jul 20, 2023
a20d748
Remove unused const values
lindboe Jul 20, 2023
7787f80
Fix typos
lindboe Jul 21, 2023
b22d6dd
Fix Google button width
lindboe Jul 21, 2023
5dbe89e
Simplify Google Sign-In button
lindboe Jul 21, 2023
f0c8646
Rework to use DeeplinkRedirectLoadingIndicator
cdanwards Jul 24, 2023
1728d2c
Removed unused compose
cdanwards Jul 24, 2023
177b6dd
Fixes tests
cdanwards Jul 24, 2023
66990bb
Moved DeeplinkWrapper to include PublicScreens - Checks to see if rou…
cdanwards Jul 25, 2023
8c69342
Remove console logs
cdanwards Jul 25, 2023
21d0da9
Prevent voice over for sign in with - redundant with apple and google…
cdanwards Jul 25, 2023
02b7861
Fixed merge conflicts
cdanwards Jul 26, 2023
fabfe8f
Merged main
cdanwards Jul 26, 2023
54281af
Updated logic to check for authentication status as well as some addi…
cdanwards Aug 1, 2023
4cb1e95
Removed comments
cdanwards Aug 1, 2023
363b6e0
Added comment to file
cdanwards Aug 1, 2023
9ce878c
Removed config setter
cdanwards Aug 1, 2023
42f5431
Simplified if statements
cdanwards Aug 1, 2023
4edcfd9
Merge branch 'Expensify:main' into new-third-party-signin
cdanwards Aug 1, 2023
ea73785
Removed comment
cdanwards Aug 1, 2023
ae90aef
Fixes error on desktop google signin page and updates some variables …
cdanwards Aug 2, 2023
b7b7895
Update contributing guide
lindboe Jul 26, 2023
067f56b
Merge pull request #48 from infinitered/lindboe/contributing-guide-up…
lindboe Aug 2, 2023
f6aa694
Changes Navigation function to grab screenName off of the state event
cdanwards Aug 3, 2023
08581bc
Merge pull request #46 from infinitered/use-redirect-page
cdanwards Aug 3, 2023
afc7806
Fixed merge conflicts from main
cdanwards Aug 3, 2023
e50e46d
Update src/components/DeeplinkWrapper/index.website.js
cdanwards Aug 7, 2023
ee4be80
Update src/components/SignInButtons/AppleAuthWrapper/index.ios.js
cdanwards Aug 7, 2023
95baa1a
Update src/components/SignInButtons/AppleSignIn/index.android.js
cdanwards Aug 7, 2023
2142d86
Update src/components/SignInButtons/AppleSignIn/index.android.js
cdanwards Aug 7, 2023
f184558
Update src/components/SignInButtons/AppleSignIn/index.android.js
cdanwards Aug 7, 2023
d8e8312
Update src/components/SignInButtons/AppleSignIn/index.desktop.js
cdanwards Aug 7, 2023
899d1b9
Update src/components/SignInButtons/AppleSignIn/index.ios.js
cdanwards Aug 7, 2023
0471e59
Update src/components/SignInButtons/AppleSignIn/index.ios.js
cdanwards Aug 7, 2023
b6745b8
Update src/components/SignInButtons/AppleSignIn/index.website.js
cdanwards Aug 7, 2023
f7f3ace
Update src/components/SignInButtons/GoogleSignIn/index.desktop.js
cdanwards Aug 7, 2023
1b74f3e
Update src/components/SignInButtons/GoogleSignIn/index.native.js
cdanwards Aug 7, 2023
a21ef54
Update src/components/SignInButtons/GoogleSignIn/index.native.js
cdanwards Aug 7, 2023
15acfd8
Update src/components/SignInButtons/IconButton.js
cdanwards Aug 7, 2023
90d4423
Update src/libs/Navigation/Navigation.js
cdanwards Aug 7, 2023
6382c55
Update src/libs/Navigation/shouldPreventDeeplinkPrompt/index.js
cdanwards Aug 7, 2023
6554497
Update src/libs/actions/Session/index.js
cdanwards Aug 7, 2023
7be5abf
Update src/libs/actions/Session/index.js
cdanwards Aug 7, 2023
2a1bfec
Remove extra line
cdanwards Aug 7, 2023
ffba2b0
Fix lint errors for JSDoc
cdanwards Aug 7, 2023
9637688
Merge branch 'main' into new-third-party-signin
cdanwards Aug 8, 2023
5b9a8e9
Added required props and revert style change on mobile web
cdanwards Aug 9, 2023
f4f79e7
Move google config to the CONFIG file
cdanwards Aug 9, 2023
b3bc5e7
Reverte another style change
cdanwards Aug 9, 2023
c18f373
Change minHeight on TopSpacer to eliminate visual regression
cdanwards Aug 10, 2023
98f45a8
Merge main
cdanwards Aug 10, 2023
fa43cac
Removed unused import
cdanwards Aug 10, 2023
1ff0895
Update use of Log
cdanwards Aug 11, 2023
4682ca5
Merge branch 'main' into new-third-party-signin
cdanwards Aug 11, 2023
960f494
Fixed merge conflicts from main
cdanwards Aug 11, 2023
0250ce8
Merge branch 'main' into new-third-party-signin
cdanwards Aug 12, 2023
b994118
Fix lint error
cdanwards Aug 12, 2023
b7f161b
remove use of Log.error
cdanwards Aug 14, 2023
af93150
Added comment to clarify flow
cdanwards Aug 14, 2023
81f8450
Prevent rendering third party sign in buttons in development
cdanwards Aug 14, 2023
e8d1d8c
Make the page content top spacer minHeight conditional
cdanwards Aug 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/images/signIn/apple-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 14 additions & 0 deletions assets/images/signIn/google-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
267 changes: 267 additions & 0 deletions contributingGuides/APPLE_GOOGLE_SIGNIN.md

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions ios/NewExpensify.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@
"${PODS_CONFIGURATION_BUILD_DIR}/Airship/AirshipExtendedActionsResources.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/Airship/AirshipMessageCenterResources.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/Airship/AirshipPreferenceCenterResources.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/GoogleSignIn/GoogleSignIn.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/React-Core/AccessibilityResources.bundle",
);
name = "[CP] Copy Pods Resources";
Expand All @@ -426,6 +427,7 @@
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AirshipExtendedActionsResources.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AirshipMessageCenterResources.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AirshipPreferenceCenterResources.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/GoogleSignIn.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AccessibilityResources.bundle",
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down Expand Up @@ -508,6 +510,7 @@
"${PODS_CONFIGURATION_BUILD_DIR}/Airship/AirshipExtendedActionsResources.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/Airship/AirshipMessageCenterResources.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/Airship/AirshipPreferenceCenterResources.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/GoogleSignIn/GoogleSignIn.bundle",
"${PODS_CONFIGURATION_BUILD_DIR}/React-Core/AccessibilityResources.bundle",
);
name = "[CP] Copy Pods Resources";
Expand All @@ -517,6 +520,7 @@
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AirshipExtendedActionsResources.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AirshipMessageCenterResources.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AirshipPreferenceCenterResources.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/GoogleSignIn.bundle",
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AccessibilityResources.bundle",
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
4 changes: 4 additions & 0 deletions ios/NewExpensify/Chat.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
<dict>
<key>aps-environment</key>
<string>development</string>
<key>com.apple.developer.applesignin</key>
<array>
<string>Default</string>
</array>
<key>com.apple.developer.associated-domains</key>
<array>
<string>applinks:new.expensify.com</string>
Expand Down
8 changes: 8 additions & 0 deletions ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@
<string>new-expensify</string>
</array>
</dict>
<dict>
<key>CFBundleTypeRole</key>
<string>Editor</string>
<key>CFBundleURLSchemes</key>
<array>
<string>com.googleusercontent.apps.921154746561-s3uqn2oe4m85tufi6mqflbfbuajrm2i3</string>
</array>
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.3.53.1</string>
Expand Down
35 changes: 35 additions & 0 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ PODS:
- Airship (= 16.11.3)
- Airship/MessageCenter (= 16.11.3)
- Airship/PreferenceCenter (= 16.11.3)
- AppAuth (1.6.2):
- AppAuth/Core (= 1.6.2)
- AppAuth/ExternalUserAgent (= 1.6.2)
- AppAuth/Core (1.6.2)
- AppAuth/ExternalUserAgent (1.6.2):
- AppAuth/Core
- boost (1.76.0)
- BVLinearGradient (2.8.1):
- React-Core
Expand Down Expand Up @@ -186,6 +192,10 @@ PODS:
- GoogleUtilities/Environment (~> 7.7)
- nanopb (< 2.30910.0, >= 2.30908.0)
- PromisesObjC (< 3.0, >= 1.2)
- GoogleSignIn (7.0.0):
- AppAuth (~> 1.5)
- GTMAppAuth (< 3.0, >= 1.3)
- GTMSessionFetcher/Core (< 4.0, >= 1.1)
- GoogleUtilities/AppDelegateSwizzler (7.11.1):
- GoogleUtilities/Environment
- GoogleUtilities/Logger
Expand All @@ -206,6 +216,10 @@ PODS:
- GoogleUtilities/Logger
- GoogleUtilities/UserDefaults (7.11.1):
- GoogleUtilities/Logger
- GTMAppAuth (2.0.0):
- AppAuth/Core (~> 1.6)
- GTMSessionFetcher/Core (< 4.0, >= 1.5)
- GTMSessionFetcher/Core (3.1.1)
- hermes-engine (0.72.3):
- hermes-engine/Pre-built (= 0.72.3)
- hermes-engine/Pre-built (0.72.3)
Expand Down Expand Up @@ -701,6 +715,8 @@ PODS:
- React-jsi (= 0.72.3)
- React-logger (= 0.72.3)
- React-perflogger (= 0.72.3)
- RNAppleAuthentication (2.2.2):
- React-Core
- RNCAsyncStorage (1.17.11):
- React-Core
- RNCClipboard (1.5.1):
Expand Down Expand Up @@ -738,6 +754,9 @@ PODS:
- React-Core
- RNGestureHandler (2.12.0):
- React-Core
- RNGoogleSignin (10.0.1):
- GoogleSignIn (~> 7.0)
- React-Core
- RNLocalize (2.2.6):
- React-Core
- RNPermissions (3.6.1):
Expand Down Expand Up @@ -882,6 +901,7 @@ DEPENDENCIES:
- React-runtimescheduler (from `../node_modules/react-native/ReactCommon/react/renderer/runtimescheduler`)
- React-utils (from `../node_modules/react-native/ReactCommon/react/utils`)
- ReactCommon/turbomodule/core (from `../node_modules/react-native/ReactCommon`)
- "RNAppleAuthentication (from `../node_modules/@invertase/react-native-apple-authentication`)"
- "RNCAsyncStorage (from `../node_modules/@react-native-async-storage/async-storage`)"
- "RNCClipboard (from `../node_modules/@react-native-community/clipboard`)"
- "RNCPicker (from `../node_modules/@react-native-picker/picker`)"
Expand All @@ -895,6 +915,7 @@ DEPENDENCIES:
- "RNFBPerf (from `../node_modules/@react-native-firebase/perf`)"
- RNFS (from `../node_modules/react-native-fs`)
- RNGestureHandler (from `../node_modules/react-native-gesture-handler`)
- "RNGoogleSignin (from `../node_modules/@react-native-google-signin/google-signin`)"
- RNLocalize (from `../node_modules/react-native-localize`)
- RNPermissions (from `../node_modules/react-native-permissions`)
- RNReactNativeHapticFeedback (from `../node_modules/react-native-haptic-feedback`)
Expand All @@ -908,6 +929,7 @@ SPEC REPOS:
trunk:
- Airship
- AirshipFrameworkProxy
- AppAuth
- CocoaAsyncSocket
- Firebase
- FirebaseABTesting
Expand All @@ -929,7 +951,10 @@ SPEC REPOS:
- fmt
- GoogleAppMeasurement
- GoogleDataTransport
- GoogleSignIn
- GoogleUtilities
- GTMAppAuth
- GTMSessionFetcher
- libevent
- libwebp
- lottie-ios
Expand Down Expand Up @@ -1073,6 +1098,8 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/react/utils"
ReactCommon:
:path: "../node_modules/react-native/ReactCommon"
RNAppleAuthentication:
:path: "../node_modules/@invertase/react-native-apple-authentication"
RNCAsyncStorage:
:path: "../node_modules/@react-native-async-storage/async-storage"
RNCClipboard:
Expand All @@ -1099,6 +1126,8 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native-fs"
RNGestureHandler:
:path: "../node_modules/react-native-gesture-handler"
RNGoogleSignin:
:path: "../node_modules/@react-native-google-signin/google-signin"
RNLocalize:
:path: "../node_modules/react-native-localize"
RNPermissions:
Expand All @@ -1119,6 +1148,7 @@ EXTERNAL SOURCES:
SPEC CHECKSUMS:
Airship: c70eed50e429f97f5adb285423c7291fb7a032ae
AirshipFrameworkProxy: 7bc4130c668c6c98e2d4c60fe4c9eb61a999be99
AppAuth: 3bb1d1cd9340bd09f5ed189fb00b1cc28e1e8570
boost: 57d2868c099736d80fcd648bf211b4431e51a558
BVLinearGradient: 421743791a59d259aec53f4c58793aad031da2ca
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
Expand Down Expand Up @@ -1146,7 +1176,10 @@ SPEC CHECKSUMS:
glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b
GoogleAppMeasurement: 5ba1164e3c844ba84272555e916d0a6d3d977e91
GoogleDataTransport: f0308f5905a745f94fb91fea9c6cbaf3831cb1bd
GoogleSignIn: b232380cf495a429b8095d3178a8d5855b42e842
GoogleUtilities: 9aa0ad5a7bc171f8bae016300bfcfa3fb8425749
GTMAppAuth: 99fb010047ba3973b7026e45393f51f27ab965ae
GTMSessionFetcher: e8647203b65cee28c5f73d0f473d096653945e72
hermes-engine: 10fbd3f62405c41ea07e71973ea61e1878d07322
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
libwebp: f62cb61d0a484ba548448a4bd52aabf150ff6eef
Expand Down Expand Up @@ -1213,6 +1246,7 @@ SPEC CHECKSUMS:
React-runtimescheduler: 837c1bebd2f84572db17698cd702ceaf585b0d9a
React-utils: bcb57da67eec2711f8b353f6e3d33bd8e4b2efa3
ReactCommon: 3ccb8fb14e6b3277e38c73b0ff5e4a1b8db017a9
RNAppleAuthentication: 0571c08da8c327ae2afc0261b48b4a515b0286a6
RNCAsyncStorage: 8616bd5a58af409453ea4e1b246521bb76578d60
RNCClipboard: 41d8d918092ae8e676f18adada19104fa3e68495
RNCPicker: 0b65be85fe7954fbb2062ef079e3d1cde252d888
Expand All @@ -1226,6 +1260,7 @@ SPEC CHECKSUMS:
RNFBPerf: 389914cda4000fe0d996a752532a591132cbf3f9
RNFS: 4ac0f0ea233904cb798630b3c077808c06931688
RNGestureHandler: dec4645026e7401a0899f2846d864403478ff6a5
RNGoogleSignin: ccaa4a81582cf713eea562c5dd9dc1961a715fd0
RNLocalize: d4b8af4e442d4bcca54e68fc687a2129b4d71a81
RNPermissions: dcdb7b99796bbeda6975a6e79ad519c41b251b1c
RNReactNativeHapticFeedback: 1e3efeca9628ff9876ee7cdd9edec1b336913f8c
Expand Down
2 changes: 1 addition & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
doNotFake: ['nextTick'],
},
testEnvironment: 'jsdom',
setupFiles: ['<rootDir>/jest/setup.js'],
setupFiles: ['<rootDir>/jest/setup.js', './node_modules/@react-native-google-signin/google-signin/jest/build/setup.js'],
setupFilesAfterEnv: ['@testing-library/jest-native/extend-expect'],
cacheDirectory: '<rootDir>/.jest-cache',
};
1 change: 0 additions & 1 deletion main.jsbundle.map

This file was deleted.

33 changes: 33 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"@formatjs/intl-numberformat": "^8.5.0",
"@formatjs/intl-pluralrules": "^5.2.2",
"@gorhom/portal": "^1.0.14",
"@invertase/react-native-apple-authentication": "^2.2.2",
"@oguzhnatly/react-native-image-manipulator": "github:Expensify/react-native-image-manipulator#5cdae3d4455b03a04c57f50be3863e2fe6c92c52",
"@onfido/react-native-sdk": "7.4.0",
"@react-native-async-storage/async-storage": "^1.17.10",
Expand All @@ -67,6 +68,7 @@
"@react-native-firebase/app": "^12.3.0",
"@react-native-firebase/crashlytics": "^12.3.0",
"@react-native-firebase/perf": "^12.3.0",
"@react-native-google-signin/google-signin": "^10.0.1",
"@react-native-picker/picker": "^2.4.3",
"@react-navigation/material-top-tabs": "^6.6.3",
"@react-navigation/native": "6.1.6",
Expand Down
8 changes: 8 additions & 0 deletions src/CONFIG.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,12 @@ export default {
E2E_TESTING: lodashGet(Config, 'E2E_TESTING', 'false') === 'true',
SEND_CRASH_REPORTS: lodashGet(Config, 'SEND_CRASH_REPORTS', 'false') === 'true',
IS_USING_WEB_PROXY: getPlatform() === 'web' && useWebProxy,
APPLE_SIGN_IN: {
SERVICE_ID: 'com.chat.expensify.chat.AppleSignIn',
REDIRECT_URI: `${newExpensifyURL}appleauth`,
},
GOOGLE_SIGN_IN: {
WEB_CLIENT_ID: '921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com',
IOS_CLIENT_ID: '921154746561-s3uqn2oe4m85tufi6mqflbfbuajrm2i3.apps.googleusercontent.com',
},
};
10 changes: 10 additions & 0 deletions src/CONST.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import lodashGet from 'lodash/get';
import Config from 'react-native-config';
import * as KeyCommand from 'react-native-key-command';
import * as Url from './libs/Url';
import SCREENS from './SCREENS';

const CLOUDFRONT_DOMAIN = 'cloudfront.net';
const CLOUDFRONT_URL = `https://d2k5nsl2zxldvw.${CLOUDFRONT_DOMAIN}`;
Expand Down Expand Up @@ -425,6 +426,15 @@ const CONST = {
// Use Environment.getEnvironmentURL to get the complete URL with port number
DEV_NEW_EXPENSIFY_URL: 'http://localhost:',

SIGN_IN_FORM_WIDTH: 300,

DEEPLINK_PROMPT_DENYLIST: [SCREENS.HOME, SCREENS.SIGN_IN_WITH_APPLE_DESKTOP, SCREENS.SIGN_IN_WITH_GOOGLE_DESKTOP],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I thought HOME is another link than root /


SIGN_IN_METHOD: {
APPLE: 'Apple',
GOOGLE: 'Google',
},

OPTION_TYPE: {
REPORT: 'report',
PERSONAL_DETAIL: 'personalDetail',
Expand Down
7 changes: 4 additions & 3 deletions src/Expensify.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import PropTypes from 'prop-types';
import React, {useCallback, useState, useEffect, useRef, useLayoutEffect, useMemo} from 'react';
import {AppState, Linking} from 'react-native';
import Onyx, {withOnyx} from 'react-native-onyx';

import * as Report from './libs/actions/Report';
import BootSplash from './libs/BootSplash';
import * as ActiveClientManager from './libs/ActiveClientManager';
Expand All @@ -24,13 +23,14 @@ import withLocalize, {withLocalizePropTypes} from './components/withLocalize';
import * as User from './libs/actions/User';
import NetworkConnection from './libs/NetworkConnection';
import Navigation from './libs/Navigation/Navigation';
import DeeplinkWrapper from './components/DeeplinkWrapper';
import PopoverReportActionContextMenu from './pages/home/report/ContextMenu/PopoverReportActionContextMenu';
import * as ReportActionContextMenu from './pages/home/report/ContextMenu/ReportActionContextMenu';
import SplashScreenHider from './components/SplashScreenHider';
import KeyboardShortcutsModal from './components/KeyboardShortcutsModal';
import AppleAuthWrapper from './components/SignInButtons/AppleAuthWrapper';
import EmojiPicker from './components/EmojiPicker/EmojiPicker';
import * as EmojiPickerAction from './libs/actions/EmojiPickerAction';
import DeeplinkWrapper from './components/DeeplinkWrapper';

// This lib needs to be imported, but it has nothing to export since all it contains is an Onyx connection
// eslint-disable-next-line no-unused-vars
Expand Down Expand Up @@ -183,7 +183,7 @@ function Expensify(props) {
}

return (
<DeeplinkWrapper>
<DeeplinkWrapper isAuthenticated={isAuthenticated}>
{shouldInit && (
<>
<KeyboardShortcutsModal />
Expand All @@ -206,6 +206,7 @@ function Expensify(props) {
</>
)}

<AppleAuthWrapper />
{hasAttemptedToOpenPublicRoom && (
<NavigationRoot
onReady={setNavigationReady}
Expand Down
Loading