-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Apple & Google Sign In #23673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcochavezf
merged 94 commits into
Expensify:main
from
infinitered:new-third-party-signin
Aug 17, 2023
Merged
Apple & Google Sign In #23673
Changes from all commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
e30d9d2
Revert "Merge pull request #23295 from Expensify/revert-16723-apple-s…
lindboe 243c7eb
Added react-native-google-signin
cdanwards cee1a2d
Added contributing guide text
cdanwards 409be2f
Ran pod install
cdanwards bf6fa12
Added url scheme to info plist
cdanwards 75a205c
Add google ids to const
cdanwards 7cf33eb
Adds Desktop Pages
cdanwards 1e893fd
Adds jest config fix
cdanwards fa47fa7
Adds linkingConfig and Icon
cdanwards 2dd569d
Adds Google Sign In Buttons
cdanwards 7bdf16f
Adds begin google sign in function
cdanwards cbd132b
Updates LoginForm ThirdPartySignInPage and styles
cdanwards b052e1e
Create DesktopRedirectPage
cdanwards 5a8e513
Added Desktop Login method to onyx
cdanwards 4eb4ecb
Set up everything to display redirect screen
cdanwards 75d01cf
Switch to using DeeplinkRedirectLoadingIndicator
cdanwards 4153b86
Redirection to desktop flow is working
cdanwards 11fd24c
Revert back Deeplinkredirectloadingindicator
cdanwards 257e3c4
Updated logic on DesktopRedirectPage
cdanwards cb2b07e
Fix navigation logic when navigating back to Desktop
cdanwards 22d0db4
Add navigation to HOME for continue to web app
cdanwards c0dc536
Cleanup after self review
cdanwards 4e3a024
Fix issue with google sign in button
cdanwards 60afcb0
Switch from onyx key to url pathname redirect approach
cdanwards 518b912
Remove console log
cdanwards 26676a6
Added Spanish Translations
cdanwards 194e809
Removed unused line
cdanwards 34fc06a
Some updates after self-review
cdanwards 04d5d6e
Reverting a change
cdanwards 78ad536
Adds loadingindicator when making expensify api call
cdanwards a4c611c
fixed prop
cdanwards 2f13689
Fix build error
cdanwards 8a110a6
Fix staging configuration
lindboe 629a9cb
New fix: use shared values in CONFIG
lindboe a20d748
Remove unused const values
lindboe 7787f80
Fix typos
lindboe b22d6dd
Fix Google button width
lindboe 5dbe89e
Simplify Google Sign-In button
lindboe f0c8646
Rework to use DeeplinkRedirectLoadingIndicator
cdanwards 1728d2c
Removed unused compose
cdanwards 177b6dd
Fixes tests
cdanwards 66990bb
Moved DeeplinkWrapper to include PublicScreens - Checks to see if rou…
cdanwards 8c69342
Remove console logs
cdanwards 21d0da9
Prevent voice over for sign in with - redundant with apple and google…
cdanwards 02b7861
Fixed merge conflicts
cdanwards fabfe8f
Merged main
cdanwards 54281af
Updated logic to check for authentication status as well as some addi…
cdanwards 4cb1e95
Removed comments
cdanwards 363b6e0
Added comment to file
cdanwards 9ce878c
Removed config setter
cdanwards 42f5431
Simplified if statements
cdanwards 4edcfd9
Merge branch 'Expensify:main' into new-third-party-signin
cdanwards ea73785
Removed comment
cdanwards ae90aef
Fixes error on desktop google signin page and updates some variables …
cdanwards b7b7895
Update contributing guide
lindboe 067f56b
Merge pull request #48 from infinitered/lindboe/contributing-guide-up…
lindboe f6aa694
Changes Navigation function to grab screenName off of the state event
cdanwards 08581bc
Merge pull request #46 from infinitered/use-redirect-page
cdanwards afc7806
Fixed merge conflicts from main
cdanwards e50e46d
Update src/components/DeeplinkWrapper/index.website.js
cdanwards ee4be80
Update src/components/SignInButtons/AppleAuthWrapper/index.ios.js
cdanwards 95baa1a
Update src/components/SignInButtons/AppleSignIn/index.android.js
cdanwards 2142d86
Update src/components/SignInButtons/AppleSignIn/index.android.js
cdanwards f184558
Update src/components/SignInButtons/AppleSignIn/index.android.js
cdanwards d8e8312
Update src/components/SignInButtons/AppleSignIn/index.desktop.js
cdanwards 899d1b9
Update src/components/SignInButtons/AppleSignIn/index.ios.js
cdanwards 0471e59
Update src/components/SignInButtons/AppleSignIn/index.ios.js
cdanwards b6745b8
Update src/components/SignInButtons/AppleSignIn/index.website.js
cdanwards f7f3ace
Update src/components/SignInButtons/GoogleSignIn/index.desktop.js
cdanwards 1b74f3e
Update src/components/SignInButtons/GoogleSignIn/index.native.js
cdanwards a21ef54
Update src/components/SignInButtons/GoogleSignIn/index.native.js
cdanwards 15acfd8
Update src/components/SignInButtons/IconButton.js
cdanwards 90d4423
Update src/libs/Navigation/Navigation.js
cdanwards 6382c55
Update src/libs/Navigation/shouldPreventDeeplinkPrompt/index.js
cdanwards 6554497
Update src/libs/actions/Session/index.js
cdanwards 7be5abf
Update src/libs/actions/Session/index.js
cdanwards 2a1bfec
Remove extra line
cdanwards ffba2b0
Fix lint errors for JSDoc
cdanwards 9637688
Merge branch 'main' into new-third-party-signin
cdanwards 5b9a8e9
Added required props and revert style change on mobile web
cdanwards f4f79e7
Move google config to the CONFIG file
cdanwards b3bc5e7
Reverte another style change
cdanwards c18f373
Change minHeight on TopSpacer to eliminate visual regression
cdanwards 98f45a8
Merge main
cdanwards fa43cac
Removed unused import
cdanwards 1ff0895
Update use of Log
cdanwards 4682ca5
Merge branch 'main' into new-third-party-signin
cdanwards 960f494
Fixed merge conflicts from main
cdanwards 0250ce8
Merge branch 'main' into new-third-party-signin
cdanwards b994118
Fix lint error
cdanwards b7f161b
remove use of Log.error
cdanwards af93150
Added comment to clarify flow
cdanwards 81f8450
Prevent rendering third party sign in buttons in development
cdanwards e8d1d8c
Make the page content top spacer minHeight conditional
cdanwards File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I thought HOME is another link than root
/