Skip to content

Fix: cannot change assignee after task created #23530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 9 commits into from
Aug 8, 2023
Merged

Fix: cannot change assignee after task created #23530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94a04ac
use props.report instead of task.report
dukenv0307 Jul 25, 2023
5e5fd81
ussing reportID from route
dukenv0307 Aug 1, 2023
14073e8
run prettier
dukenv0307 Aug 1, 2023
f94b259
make code dry
dukenv0307 Aug 3, 2023
1c48cdd
merge main
dukenv0307 Aug 3, 2023
32efe36
remove lodashget
dukenv0307 Aug 3, 2023
47414f8
remove lodashget
dukenv0307 Aug 3, 2023
5644e7f
merge main
dukenv0307 Aug 8, 2023
a1e39d1
fix error when assign totalnew person
dukenv0307 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/actions/Task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,9 @@ function editTaskAndNavigate(report, ownerAccountID, {title, description, assign
let optimisticAssigneeAddComment;
let assigneeChatReportID;
if (assigneeAccountID && assigneeAccountID !== report.managerID && assigneeAccountID !== ownerAccountID) {
assigneeChatReportID = ReportUtils.getChatByParticipants([assigneeAccountID]).reportID;
assigneeChatReportID = lodashGet(ReportUtils.getChatByParticipants([assigneeAccountID]), ['reportID'], undefined);

if (assigneeChatReportID !== report.parentReportID.toString()) {
if (assigneeChatReportID && assigneeChatReportID !== report.parentReportID.toString()) {
optimisticAssigneeAddComment = ReportUtils.buildOptimisticTaskCommentReportAction(
report.reportID,
reportName,
Expand Down
15 changes: 11 additions & 4 deletions src/pages/tasks/TaskAssigneeSelectorModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* eslint-disable es/no-optional-chaining */
import React, {useState, useEffect, useMemo, useCallback} from 'react';
import {View} from 'react-native';
import lodashGet from 'lodash/get';
import _ from 'underscore';
import PropTypes from 'prop-types';
import {withOnyx} from 'react-native-onyx';
import lodashGet from 'lodash/get';
import OptionsSelector from '../../components/OptionsSelector';
import * as OptionsListUtils from '../../libs/OptionsListUtils';
import ONYXKEYS from '../../ONYXKEYS';
Expand Down Expand Up @@ -108,6 +108,13 @@ function TaskAssigneeSelectorModal(props) {
setSearchValue(newSearchTerm);
};

const report = useMemo(() => {
if (!props.route.params || !props.route.params.reportID) {
return null;
}
return props.reports[`${ONYXKEYS.COLLECTION.REPORT}${props.route.params.reportID}`];
}, [props.reports, props.route.params]);

const sections = useMemo(() => {
const sectionsList = [];
let indexOffset = 0;
Expand Down Expand Up @@ -164,13 +171,13 @@ function TaskAssigneeSelectorModal(props) {
}

// Check to see if we're editing a task and if so, update the assignee
if (props.route.params.reportID && props.task.report.reportID === props.route.params.reportID) {
if (report) {
// There was an issue where sometimes a new assignee didn't have a DM thread
// This would cause the app to crash, so we need to make sure we have a DM thread
Task.setAssigneeValue(option.login, option.accountID, props.task.shareDestination, OptionsListUtils.isCurrentUser(option));
Task.setAssigneeValue(option.login, option.accountID, props.route.params.reportID, OptionsListUtils.isCurrentUser(option));

// Pass through the selected assignee
Task.editTaskAndNavigate(props.task.report, props.session.accountID, {
Task.editTaskAndNavigate(report, props.session.accountID, {
assignee: option.login,
assigneeAccountID: option.accountID,
});
Expand Down