remove limit and add max length task description by namhihi237 · Pull Request #23246 · Expensify/App

namhihi237 · 2023-07-20T08:57:59Z

Details

Remove limit line view task description
Add limit length description when create and update task

Fixed Issues

$ #22493
PROPOSAL: #22493 (comment)

Tests

Create a task with a long description
Open task detail and verify that can view all description

Verify that no errors appear in the JS console

Offline tests

The same test

QA Steps

The same test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.mov

Mobile Web - Safari

safari.MP4

Desktop

desktop.mov

iOS

Android

melvin-bot · 2023-07-20T08:58:04Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-07-20T14:04:49Z

    isAnonymousAction: false,
    isSmallAvatarSubscriptMenu: false,
    title: '',
-    numberOfLinesTitle: 1,


I don't think we should be removing this prop. We should still retain the check, and instead set this to 0 from TaskPreview. I think this would break MenuItem at a few places.

cc - @stitesExpensify

yes, you're right, to make sure it not effect another place, I think we can set numberOfLLine={0} from TaskView

Yeah but we'll have to change the condition to numberOfLinesTitle > 1 to numberOfLinesTitle != 1

Yeah, also we don't need to pass the style.preWrap on TaskView, Thanks @mananjadhav for review

mananjadhav · 2023-07-20T14:24:17Z

I think we can deal with the limit when we hit it, we don't need to fix that right now.

@namhihi237 I think we decided not to implement the input limit. @stitesExpensify let's remove it from this PR right?

namhihi237 · 2023-07-20T14:26:41Z

oh right, I will remove this @mananjadhav

mananjadhav · 2023-07-21T12:38:42Z

@namhihi237 I am not sure how it is working for you on the Android? I thin you haven't tested/updated screenshots after pushing the last changes. numberOfLines={0} won't work on Android.

namhihi237 · 2023-07-21T13:09:49Z

@mananjadhav Sorry I forgot to test the last update on Android, just IOS. I just fixed it, here is a screenshot for both:

mananjadhav · 2023-07-21T13:11:44Z

@namhihi237 I don't think this fix works. It's a code smell, and doesn't make sense to repeat the same component twice?

namhihi237 · 2023-07-21T13:18:41Z

yeah @mananjadhav , version refactored

mananjadhav · 2023-07-21T13:19:48Z

Thanks I think this works. I can see we're refactoring numberOfLines in this PR. This would eventually get fixed there, but I think we're good with this change too.

namhihi237 · 2023-07-21T13:22:10Z

yes, Thanks @mananjadhav for review

mananjadhav · 2023-07-21T14:49:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-task-description-multiline.mov

Mobile Web - Chrome

mweb-chrome-task-description-multiline.mov

Mobile Web - Safari

mweb-safari-task-description-multiline.mov

Desktop

desktop-task-description-multiline.mov

iOS

ios-task-description-multiline.mov

Android

android-task-description-multiline.mov

mananjadhav · 2023-07-21T14:50:45Z

@stitesExpensify All yours.

🎀 👀 🎀 C+ reviewed.

stitesExpensify · 2023-07-21T15:13:48Z

Just to confirm @mananjadhav everything is testing well still after the recent changes?

stitesExpensify · 2023-07-21T15:14:16Z

Oops, my GH wasn't updated, Just saw your new checklist. Ignore me!

mananjadhav · 2023-07-21T15:15:00Z

Yes I checked after the last commit.

stitesExpensify

LGTM!

OSBotify · 2023-07-21T15:22:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-21T18:49:57Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav · 2023-07-24T13:58:58Z

@namhihi237 We have a regression when we put a continuous string without any space it overflows the description. #23410 (comment) Can we please post a PR to fix this please?

namhihi237 · 2023-07-24T14:07:15Z

Yes, I will raise PR sasp

namhihi237 · 2023-07-24T14:38:47Z

Hi @mananjadhav PR is already, please take a look thanks.

OSBotify · 2023-07-25T01:23:54Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:15Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:53:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

namhihi237 added 2 commits July 20, 2023 14:34

remove limit and add max length task description

09a677c

fix for native

5d96218

namhihi237 requested a review from a team as a code owner July 20, 2023 08:57

melvin-bot Bot requested review from mananjadhav and removed request for a team July 20, 2023 08:58

namhihi237 added 2 commits July 20, 2023 16:00

remove prop not used

2ee907d

fix lint

2b30fcd

mananjadhav reviewed Jul 20, 2023

View reviewed changes

namhihi237 added 3 commits July 20, 2023 21:40

remove limit and set remove numOfline

b038d6b

set back prop

b528919

fix condition numberOfLinesTitle

6a894de

fix for android

1f2f42b

refactor code

9e2abfd

fix lint

80c573f

mananjadhav mentioned this pull request Jul 21, 2023

[HOLD for payment 2023-08-03] [$1000] NEW FEATURE: Don't truncate long room names in room details page #22613

Closed

6 tasks

mananjadhav approved these changes Jul 21, 2023

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify July 21, 2023 14:45

stitesExpensify approved these changes Jul 21, 2023

View reviewed changes

stitesExpensify merged commit b55fd83 into Expensify:main Jul 21, 2023

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

lanitochka17 mentioned this pull request Jul 22, 2023

[HOLD for payment 2023-08-02] Task - Long task description is truncated in chat and overlapped by expand button #23410

Closed

6 tasks

namhihi237 mentioned this pull request Jul 24, 2023

fix break description #23487

Merged

58 tasks

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

melvin-bot Bot mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-01] [$1000] dev: Inconsistency in showing task description when the number of rows increases #22493

Closed

6 tasks

twilight2294 mentioned this pull request Nov 20, 2024

[hold for payment 2024-12-17] [$125] Android - Room - Room name displayed truncated on header and details when using long name #52836

Closed

8 tasks

Uh oh!

Conversation

namhihi237 commented Jul 20, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 20, 2023

Uh oh!

mananjadhav Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

namhihi237 Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

namhihi237 Jul 20, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jul 20, 2023

Uh oh!

namhihi237 commented Jul 20, 2023

Uh oh!

mananjadhav commented Jul 21, 2023

Uh oh!

namhihi237 commented Jul 21, 2023

Uh oh!

mananjadhav commented Jul 21, 2023

Uh oh!

namhihi237 commented Jul 21, 2023

Uh oh!

mananjadhav commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

namhihi237 commented Jul 21, 2023

Uh oh!

mananjadhav commented Jul 21, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Jul 21, 2023

Uh oh!

stitesExpensify commented Jul 21, 2023

Uh oh!

stitesExpensify commented Jul 21, 2023

Uh oh!

mananjadhav commented Jul 21, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 21, 2023

Uh oh!

OSBotify commented Jul 21, 2023

Uh oh!

mananjadhav commented Jul 24, 2023

Uh oh!

namhihi237 commented Jul 24, 2023

Uh oh!

namhihi237 commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mananjadhav Jul 20, 2023 •

edited

Loading

mananjadhav commented Jul 21, 2023 •

edited

Loading