Skip to content

refactor: WindowDimensionsProvider to function component #22809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 2 commits into from
Jul 24, 2023
Merged

refactor: WindowDimensionsProvider to function component #22809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc347ce
refactor: WindowDimensionsProvider to function component
sangar-1028 Jul 13, 2023
daa90aa
fix: prettier
sangar-1028 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 50 additions & 64 deletions src/components/withWindowDimensions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {forwardRef, createContext} from 'react';
import React, {forwardRef, createContext, useState, useEffect} from 'react';
import PropTypes from 'prop-types';
import {Dimensions} from 'react-native';
import {SafeAreaInsetsContext} from 'react-native-safe-area-context';
Expand Down Expand Up @@ -32,77 +32,63 @@ const windowDimensionsProviderPropTypes = {
children: PropTypes.node.isRequired,
};

class WindowDimensionsProvider extends React.Component {
constructor(props) {
super(props);
function WindowDimensionsProvider(props) {
const [windowDimension, setWindowDimension] = useState(() => {
const initialDimensions = Dimensions.get('window');
return {
windowHeight: initialDimensions.height,
windowWidth: initialDimensions.width,
};
});

this.onDimensionChange = this.onDimensionChange.bind(this);
useEffect(() => {
const onDimensionChange = (newDimensions) => {
const {window} = newDimensions;

const initialDimensions = Dimensions.get('window');
setWindowDimension({
windowHeight: window.height,
windowWidth: window.width,
});
};

this.dimensionsEventListener = null;
const dimensionsEventListener = Dimensions.addEventListener('change', onDimensionChange);

this.state = {
windowHeight: initialDimensions.height,
windowWidth: initialDimensions.width,
return () => {
if (!dimensionsEventListener) {
return;
}
dimensionsEventListener.remove();
};
}

componentDidMount() {
this.dimensionsEventListener = Dimensions.addEventListener('change', this.onDimensionChange);
}

componentWillUnmount() {
if (!this.dimensionsEventListener) {
return;
}
this.dimensionsEventListener.remove();
}

/**
* Stores the application window's width and height in a component state variable.
* Called each time the application's window dimensions or screen dimensions change.
* @link https://reactnative.dev/docs/dimensions
* @param {Object} newDimensions Dimension object containing updated window and screen dimensions
*/
onDimensionChange(newDimensions) {
const {window} = newDimensions;

this.setState({
windowHeight: window.height,
windowWidth: window.width,
});
}

render() {
return (
<SafeAreaInsetsContext.Consumer>
{(insets) => {
const isExtraSmallScreenWidth = this.state.windowWidth <= variables.extraSmallMobileResponsiveWidthBreakpoint;
const isSmallScreenWidth = this.state.windowWidth <= variables.mobileResponsiveWidthBreakpoint;
const isMediumScreenWidth = !isSmallScreenWidth && this.state.windowWidth <= variables.tabletResponsiveWidthBreakpoint;
const isLargeScreenWidth = !isSmallScreenWidth && !isMediumScreenWidth;
return (
<WindowDimensionsContext.Provider
value={{
windowHeight: this.state.windowHeight + getWindowHeightAdjustment(insets),
windowWidth: this.state.windowWidth,
isExtraSmallScreenWidth,
isSmallScreenWidth,
isMediumScreenWidth,
isLargeScreenWidth,
}}
>
{this.props.children}
</WindowDimensionsContext.Provider>
);
}}
</SafeAreaInsetsContext.Consumer>
);
}
}, []);

return (
<SafeAreaInsetsContext.Consumer>
{(insets) => {
const isExtraSmallScreenWidth = windowDimension.windowWidth <= variables.extraSmallMobileResponsiveWidthBreakpoint;
const isSmallScreenWidth = windowDimension.windowWidth <= variables.mobileResponsiveWidthBreakpoint;
const isMediumScreenWidth = !isSmallScreenWidth && windowDimension.windowWidth <= variables.tabletResponsiveWidthBreakpoint;
const isLargeScreenWidth = !isSmallScreenWidth && !isMediumScreenWidth;
return (
<WindowDimensionsContext.Provider
value={{
windowHeight: windowDimension.windowHeight + getWindowHeightAdjustment(insets),
windowWidth: windowDimension.windowWidth,
isExtraSmallScreenWidth,
isSmallScreenWidth,
isMediumScreenWidth,
isLargeScreenWidth,
}}
>
{props.children}
</WindowDimensionsContext.Provider>
);
}}
</SafeAreaInsetsContext.Consumer>
);
}

WindowDimensionsProvider.propTypes = windowDimensionsProviderPropTypes;
WindowDimensionsProvider.displayName = 'WindowDimensionsProvider';

/**
* @param {React.Component} WrappedComponent
Expand Down