Fix mobile home background SVG opacity by waterim · Pull Request #21745 · Expensify/App

waterim · 2023-06-27T20:09:54Z

Details

Fixed Issues

$ #20829
PROPOSAL: #20829 (comment)

Tests

Open the app on IOS and Android
Open Login Screen
Look at the background image
Verify images both on IOS and Android looks correct

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open the app on IOS and Android
Open Login Screen
Look at the background image
Verify images both on IOS and Android looks correct

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web - Chrome

Web - Safari

Mobile Web - Chrome

Mobile Web - Safari

iOS

Android

Desktop

github-actions · 2023-06-27T20:10:12Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2023-06-28T09:04:59Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

waterim · 2023-06-28T09:05:49Z

I have read the CLA Document and I hereby sign the CLA

grgia · 2023-06-28T10:47:02Z

@Julesssss looks like this was your issue, added you as a reviewer. Let me know if you need me to review instead and I'll reassign!

allroundexperts · 2023-06-28T10:54:00Z

@waterim Can you please add screenshots for ALL the platforms? Also, can you please update the test section to mention that the user should open the login screen?

waterim · 2023-06-28T10:57:57Z

@allroundexperts Comment updated.
Do I need to add screenshots even for desktop web? We are using this image only on mobile View.
It means no changes on desktop.

allroundexperts · 2023-06-28T11:03:28Z

@allroundexperts Comment updated.

Do I need to add screenshots even for desktop web? We are using this image only on mobile View.

It means no changes on desktop.

According to our guidelines, the screenshots for all the platforms are required.

waterim · 2023-06-28T12:04:07Z

@allroundexperts After verifying mobile Safari I found that opacity is not applying from updated SVG. With a new commit I added Platform specific check to display updated SVG only on Android. All platforms are accepting opacity in the same way except Android.

allroundexperts · 2023-06-28T17:18:05Z

        scrollViewRef.current.scrollTo({y: 0, animated});
    };

+    const MobileBackgroundImage = Platform.OS === 'android' ? SignInHeroBackgroundImageMobileAndroid : SignInHeroBackgroundImageMobile;


@waterim We never add platform specific code inline like this. We always create a separate file which gets loaded during the build process. You can easily find examples of such files if you search the code.

@allroundexperts Okay, will change it, thank you

@allroundexperts Do you mean to create a separate component with 2 files, one is default and one with .android extension and move there this backgroundImage?

Instead of creating an android specific file for this whole component, I think we can create a file that just re-exports the svg and use that in this component. This way, we will avoid the component code duplication.

Agree with the above. Also, is there a reason we can't use the new SVG for all platforms?

@Julesssss on web mobile safari new SVG is working wrong, same as Android before changes, unfortunately

allroundexperts · 2023-06-29T12:37:09Z

Not required.

Accidentally added only podfile.lock. Reverted that commit.

This reverts commit b8fe9f6.

waterim · 2023-06-29T12:45:30Z

@allroundexperts Everything is ready for a review.

allroundexperts · 2023-06-29T12:47:34Z

 import themeColors from '../../../styles/themes/default';
 import SignInHeroBackgroundImage from '../../../../assets/images/home-background--desktop.svg';
-import SignInHeroBackgroundImageMobile from '../../../../assets/images/home-background--mobile.svg';
+import MobileBackgroundImage from './MobileBackgroundImage';


I think we can improve this further. In the src/pages/signin/SignInPageLayout/MobileBackgroundImage/index.js we can return the correct image based on the screen width. This way, we'll have to import a single file in this component that will work on all screen sizes and platforms.

Okay, added

allroundexperts · 2023-06-29T18:18:59Z

                            <View style={styles.signInPageHeroCenter}>
-                                <SignInHeroBackgroundImage
+                                <BackgroundImage
+                                    isSmallScreen={props.isSmallScreenWidth}


I think we're already checking for small screen above. As such, we can just add the following:

<BackgroundImage isSmallScreen . . />

allroundexperts · 2023-06-29T18:19:19Z

                    <View style={[styles.flex1, styles.flexColumn, StyleUtils.getMinimumHeight(Math.max(variables.signInContentMinHeight, containerHeight))]}>
-                        <SignInHeroBackgroundImageMobile
+                        <BackgroundImage
+                            isSmallScreen={props.isSmallScreenWidth}


Just add isSmallScreen={false}

allroundexperts · 2023-06-29T18:22:49Z

Solid work @waterim 🙌 🙌
One last small comment and then we should be good!

allroundexperts · 2023-06-29T19:30:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-06-30.at.12.31.19.AM.mov

iOS

Android

waterim · 2023-06-29T21:21:05Z

@allroundexperts Updated prop, thank you

allroundexperts · 2023-06-30T06:14:57Z

@waterim Can you please make sure that you have put in your proposal link correctly in the PR description? That is important for our automation to work. Normally, if they are entered correctly, the related reviewers are automatically assigned.

Here's how a correct link should look like:

Please update your description such that it matches our standard way.

allroundexperts

Looks good and tests well!

OSBotify · 2023-06-30T08:48:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-03T14:50:02Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.36-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-05T17:13:15Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rushatgabhane · 2023-09-05T04:31:23Z

+        <DesktopBackgroundImage
+            pointerEvents={props.pointerEvents}
+            width={props.width}
+        />


Hi, this PR caused a bug - #23137 (comment)

We should have passed styles as a prop for desktop too

update mobile home background SVG opacity

2bc5897

waterim marked this pull request as ready for review June 28, 2023 09:04

waterim requested a review from a team as a code owner June 28, 2023 09:04

melvin-bot Bot requested review from grgia and removed request for a team June 28, 2023 09:04

grgia requested review from Julesssss and allroundexperts and removed request for grgia June 28, 2023 10:46

added updated SVG only for android

ef7302f

allroundexperts reviewed Jun 28, 2023

View reviewed changes

Julesssss assigned waterim Jun 29, 2023

removed platform OS specific code

b8fe9f6

allroundexperts reviewed Jun 29, 2023

View reviewed changes

waterim added 3 commits June 29, 2023 14:38

Revert "removed platform OS specific code"

258debf

This reverts commit b8fe9f6.

removed platform OS specific code

47de097

remove spaces

c6738a3

allroundexperts reviewed Jun 29, 2023

View reviewed changes

waterim added 2 commits June 29, 2023 19:33

add component with desktop and mobile backgrounds

d28b63c

change propType of the style

0a771d9

allroundexperts reviewed Jun 29, 2023

View reviewed changes

smallScreen prop adjustment

4eff587

allroundexperts approved these changes Jun 30, 2023

View reviewed changes

Julesssss approved these changes Jun 30, 2023

View reviewed changes

Julesssss merged commit 3404111 into Expensify:main Jun 30, 2023

OSBotify mentioned this pull request Jul 3, 2023

Deploy Checklist: New Expensify 2023-07-03 #22116

Closed

40 tasks

Julesssss mentioned this pull request Jul 10, 2023

[HOLD FOR PAYMENT - 2023-07-12] [$1000] Background hero image on Android device looks distorted #20829

Closed

6 tasks

rushatgabhane reviewed Sep 5, 2023

View reviewed changes

rushatgabhane mentioned this pull request Sep 5, 2023

[HOLD C+ Payment] [$1000] Slow animation on sign in input #23137

Closed

6 tasks

mananjadhav mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-09-29] [$1000] Android - Sign in background image is missing #26069

Closed

6 tasks

Uh oh!

Conversation

waterim commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 28, 2023

Uh oh!

waterim commented Jun 28, 2023

Uh oh!

grgia commented Jun 28, 2023

Uh oh!

allroundexperts commented Jun 28, 2023

Uh oh!

waterim commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Jun 28, 2023

Uh oh!

waterim commented Jun 28, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waterim Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waterim commented Jun 29, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Jun 29, 2023

Uh oh!

allroundexperts commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

waterim commented Jun 29, 2023

Uh oh!

allroundexperts commented Jun 30, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 30, 2023

Uh oh!

waterim commented Jun 27, 2023 •

edited

Loading

github-actions Bot commented Jun 27, 2023 •

edited

Loading

waterim commented Jun 28, 2023 •

edited

Loading

Julesssss Jun 29, 2023 •

edited

Loading

waterim Jun 29, 2023 •

edited

Loading

allroundexperts commented Jun 29, 2023 •

edited

Loading