Use new path for share url by deetergp · Pull Request #21081 · Expensify/App

deetergp · 2023-06-19T20:53:26Z

Details

When we refactored Personal Details we didn't remember to update the QR Code/Share Link page. This PR addresses that with @hungvu193's proposed fix.

Fixed Issues

$ #20993
PROPOSAL: #20993 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

From test account A, click the user avatar icon (a.k.a. Settings button) and select "Share code > Copy URL to Clipboard"
In an incognito window, paste the URL, making sure to change it to staging. Log in as test user B.
Verify that test user B see's test user A's profile and avatar.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

2023-06-19_17-36-09.mp4

Mobile Web - Safari

Uploading Simulator Screen Recording - iPhone 13 - 2023-06-19 at 16.57.50.mp4…

Desktop

N/A

iOS

N/A

Android

N/A

melvin-bot · 2023-06-19T20:53:58Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-06-19T21:29:35Z

        const subtitle = ReportUtils.getChatRoomSubtitle(this.props.report);

-        const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}details?login=${encodeURIComponent(this.props.session.email)}`;
+        const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}a/${this.props.session.accountID}`;


Can we use getReportRoute and getProfileRoute instead?

deetergp · 2023-06-19T21:41:36Z

Updated!

luacmartins · 2023-06-19T21:58:13Z

Lint is failing, but code LGTM. @marcaaron all yours!

luacmartins

LGTM. Can we also add test steps and screenshots for all platforms?

deetergp · 2023-06-20T00:40:50Z

Doesn't this only apply to web?

marcaaron · 2023-06-20T01:28:38Z

Edit: nevermind, I figured this one out haha

marcaaron · 2023-06-20T01:32:03Z

Oh also I would say that maybe these links should work with deep links on native? But I see we have not set them up yet here (at least for Apple):

App/.well-known/apple-app-site-association

Lines 7 to 46 in b49ca20

    
           { 
        
              "/": "/r/*", 
        
              "comment": "Reports" 
        
           }, 
        
           { 
        
               "/": "/settings/*", 
        
               "comment": "Profile and app settings" 
        
           }, 
        
           { 
        
               "/": "/details/*", 
        
               "comment": "Details of another users" 
        
           }, 
        
           { 
        
               "/": "/v/*", 
        
               "comment": "Account validation" 
        
           }, 
        
           { 
        
               "/": "/bank-account/*", 
        
               "comment": "Bank account setup and its steps" 
        
           }, 
        
           { 
        
               "/": "/iou/*", 
        
               "comment": "I Owe You reports" 
        
           }, 
        
           { 
        
               "/": "/enable-payments/*", 
        
               "comment": "Payments setup" 
        
           }, 
        
           { 
        
               "/": "/partners/plaid/oauth_ios", 
        
               "comment": "Plaid setup" 
        
           }, 
        
           { 
        
               "/": "/statements/*", 
        
               "comment": "Wallet statements" 
        
           }, 
        
           { 
        
               "/": "/concierge/*", 
        
               "comment": "Concierge" 
        
           }

marcaaron · 2023-06-20T01:33:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcaaron · 2023-06-20T01:58:25Z

Oh sorry, did we want to CP this to staging? Maybe it must be done manually now?

OSBotify · 2023-06-20T02:02:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Use new path for share url (cherry picked from commit 3030d6f)

…ing-21081 🍒 Cherry pick PR #21081 to staging 🍒

OSBotify · 2023-06-20T15:46:20Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.29-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-21T02:17:01Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T22:17:43Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-06-26T09:38:50Z

We are facing strange behavior on mWeb where hidden name displays for a few seconds. Issue is not reproducible on PROD.

trim.5842B5A7-D5EE-418C-BCE2-FB6164B37F48.MOV

OSBotify · 2023-06-26T20:48:20Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use new path for share url

9304de4

deetergp requested a review from a team as a code owner June 19, 2023 20:53

deetergp self-assigned this Jun 19, 2023

melvin-bot Bot requested review from marcaaron and removed request for a team June 19, 2023 20:53

luacmartins reviewed Jun 19, 2023

View reviewed changes

Use ROUTES.getNRoute() instead

0a3d621

deetergp force-pushed the scott-fixShareAvatarBlocker branch from 158eefe to 0a3d621 Compare June 19, 2023 21:41

luacmartins previously approved these changes Jun 19, 2023

View reviewed changes

Making my code feel pretty

eb10b78

deetergp dismissed luacmartins’s stale review via eb10b78 June 19, 2023 23:37

luacmartins reviewed Jun 19, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

marcaaron approved these changes Jun 20, 2023

View reviewed changes

marcaaron merged commit 3030d6f into main Jun 20, 2023

marcaaron deleted the scott-fixShareAvatarBlocker branch June 20, 2023 01:57

OSBotify pushed a commit that referenced this pull request Jun 20, 2023

Merge pull request #21081 from Expensify/scott-fixShareAvatarBlocker

09b42f2

Use new path for share url (cherry picked from commit 3030d6f)

OSBotify mentioned this pull request Jun 20, 2023

🍒 Cherry pick PR #21081 to staging 🍒 #21130

Merged

OSBotify added a commit that referenced this pull request Jun 20, 2023

Merge pull request #21130 from Expensify/luacmartins-cherry-pick-stag…

f7eb7c4

…ing-21081 🍒 Cherry pick PR #21081 to staging 🍒

OSBotify mentioned this pull request Jun 20, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

melvin-bot Bot mentioned this pull request Jun 21, 2023

[$1000] [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Avatar is not loading when opening a 'share code' link #20993

Closed

6 tasks

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

OSBotify mentioned this pull request Jun 24, 2023

Deploy Checklist: New Expensify 2023-06-24 #21477

Closed

45 tasks

lanitochka17 mentioned this pull request Jun 26, 2023

[HOLD for payment 2023-07-10] [$1000] Profile- Hidden profile name displayed for few seconds #21571

Closed

6 tasks

Uh oh!

Conversation

deetergp commented Jun 19, 2023 • edited by marcaaron Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 19, 2023

Uh oh!

luacmartins Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

deetergp commented Jun 19, 2023

Uh oh!

luacmartins commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

deetergp commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcaaron commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

marcaaron commented Jun 20, 2023

Uh oh!

marcaaron commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

marcaaron commented Jun 20, 2023

Uh oh!

OSBotify commented Jun 20, 2023

Uh oh!

OSBotify commented Jun 20, 2023

Uh oh!

OSBotify commented Jun 21, 2023

Uh oh!

OSBotify commented Jun 23, 2023

Uh oh!

mvtglobally commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deetergp commented Jun 19, 2023 •

edited by marcaaron

Loading

luacmartins commented Jun 19, 2023 •

edited

Loading

deetergp commented Jun 20, 2023 •

edited

Loading

marcaaron commented Jun 20, 2023 •

edited

Loading

marcaaron commented Jun 20, 2023 •

edited

Loading

mvtglobally commented Jun 26, 2023 •

edited

Loading