Transform BigNumberPad.js from class component to functional one by mkhutornyi · Pull Request #20231 · Expensify/App

mkhutornyi · 2023-06-06T00:52:31Z

Details

Transform BigNumberPad.js from class component to functional one.

Fixed Issues

$ #16120

Tests

This can be only testable in mobile apps or browsers.

Click a user in the contact list.
Click + button in message box.
Click "Request money" or "Send money" in the popup menu.
Verify the currency pad appears and the pad is working as expected.

Verify that no errors appear in the JS console

Offline tests

This particular issue doesn't require offline tests but confirmed that it's working in offline environment too through the same test steps.

QA Steps

This can be only testable in mobile apps or browsers.

Click a user in the contact list.
Click + button in message box.
Click "Request money" or "Send money" in the popup menu.
Verify the currency pad appears and the pad is working as expected.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-06T00:52:40Z

@luacmartins @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-06-06T00:52:43Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mkhutornyi · 2023-06-06T01:02:00Z

I have read the CLA Document and I hereby sign the CLA

mkhutornyi · 2023-06-06T01:03:51Z

recheck

mkhutornyi · 2023-06-06T21:08:33Z

Fixed code style issues and removed useCallback. Please check again @luacmartins

luacmartins · 2023-06-06T22:07:04Z

@mkhutornyi we have some lint errors now

mkhutornyi · 2023-06-07T05:15:18Z

Fixed the lint error

luacmartins

LGTM!

thesahindia · 2023-06-07T16:14:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Screen.Recording.2023-06-07.at.9.31.18.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-07.at.9.38.13.PM.mov

Desktop

iOS

Screen.Recording.2023-06-07.at.9.36.11.PM.mov

Android

Screen.Recording.2023-06-07.at.9.32.58.PM.mov

thesahindia

LGTM! Didn't see any issues.

cc: @luacmartins

OSBotify · 2023-06-07T16:26:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-08T17:02:30Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:23:12Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jayeshmangwani · 2024-05-06T13:00:38Z

+        props.longPressHandlerStateChanged(true);
+
+        const newTimer = setInterval(() => {
+            props.numberPressed(key);


When changed from class to functional component, the native device's long press stopped working. It is just deleting the last text only; numberPressed was passing the old value, and due to that, the selection value doesn't have the the correct value, and the previous text is just deleted. More context here: #39079 (comment)

mkhutornyi added 3 commits June 5, 2023 16:39

Transform BigNumberPad component to functional one

0f38f7b

Revert removed comments

0146d59

Fix lint, prettier issues

53f5cf0

mkhutornyi requested a review from a team as a code owner June 6, 2023 00:52

melvin-bot Bot requested review from luacmartins and thesahindia and removed request for a team June 6, 2023 00:52

luacmartins requested changes Jun 6, 2023

View reviewed changes

Comment thread src/components/BigNumberPad.js Outdated

Comment thread src/components/BigNumberPad.js Outdated

Comment thread src/components/BigNumberPad.js Outdated

Fix code style issues

a49e09f

Fix prettier issue

2e02597

luacmartins approved these changes Jun 7, 2023

View reviewed changes

thesahindia approved these changes Jun 7, 2023

View reviewed changes

luacmartins merged commit 2fb8061 into Expensify:main Jun 7, 2023

mkhutornyi deleted the mkhutornyi-BigNumberPad-functional-component branch June 8, 2023 12:06

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

melvin-bot Bot mentioned this pull request Jun 12, 2023

[HOLD for payment 2023-06-19] [$250] Migrate BigNumberPad.js to function component #16120

Closed

1 task

rayane-d mentioned this pull request Aug 19, 2023

IOU - The backspace button on the keypad only deletes one digit at a time, not the entire number #25540

Closed

6 tasks

jayeshmangwani reviewed May 6, 2024

View reviewed changes

jayeshmangwani mentioned this pull request May 6, 2024

[HOLD for payment 2024-05-02] [$250] Taxes - Cursor continues to move after deleting one digit when long pressing on delete key #39079

Closed

6 tasks

Uh oh!

Conversation

mkhutornyi commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 6, 2023

Uh oh!

github-actions Bot commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkhutornyi commented Jun 6, 2023

Uh oh!

mkhutornyi commented Jun 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkhutornyi commented Jun 6, 2023

Uh oh!

luacmartins commented Jun 6, 2023

Uh oh!

mkhutornyi commented Jun 7, 2023

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Jun 7, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 7, 2023

Uh oh!

OSBotify commented Jun 8, 2023

Uh oh!

OSBotify commented Jun 13, 2023

Uh oh!

jayeshmangwani May 6, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mkhutornyi commented Jun 6, 2023 •

edited

Loading

github-actions Bot commented Jun 6, 2023 •

edited

Loading