Fix width of report header on mobile web#2001
Merged
Merged
Conversation
Contributor
|
Ohh interesting one - sorry to have introduced it! |
NikkiWines
approved these changes
Mar 22, 2021
Contributor
|
Dude, yes! I'm glad to see this fixed, it was bugging me 😄 |
Luke9389
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@NikkiWines I was having a hard time nailing this down, and I ended up doing a git bisect and found this was originally caused by the change here: 4ce6b36
Details
I believe that just adding
flex: 1fixes the width problem so that everything stays within the view.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157960Fixes https://github.com/Expensify/Expensify/issues/157960
Tests
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android